From patchwork Tue Aug 9 16:34:20 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 1050372 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p79GYeKP000514 for ; Tue, 9 Aug 2011 16:34:47 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753897Ab1HIQel (ORCPT ); Tue, 9 Aug 2011 12:34:41 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:45654 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752673Ab1HIQel (ORCPT ); Tue, 9 Aug 2011 12:34:41 -0400 Received: by mail-fx0-f46.google.com with SMTP id 19so192442fxh.19 for ; Tue, 09 Aug 2011 09:34:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=Q0SYMqL6Tmg2m0/a/zs3mRKpU5WCFXEfm2FUZ0KfXDw=; b=iE+Z59dB5Edwhqgf+3TysJPUim4BsA6KKdCtwRJ5uzzqkofO5D9TaB3nGFFa7+AB+O u+Di828o6OlFK1ba3F3HX6w6eEUOIa2kw8ENDkzSQaLVUheY0JkIAMIU1f+nQ8T19iQ7 H1LxysQD+NrTOM8vTbN9T53LyWtDV+ZIkLVys= Received: by 10.223.98.78 with SMTP id p14mr4906857fan.8.1312907680425; Tue, 09 Aug 2011 09:34:40 -0700 (PDT) Received: from xi ([83.249.240.82]) by mx.google.com with ESMTPS id d1sm63424fai.28.2011.08.09.09.34.38 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 09 Aug 2011 09:34:39 -0700 (PDT) Received: from johan by xi with local (Exim 4.76) (envelope-from ) id 1QqpGH-0006Nb-J7; Tue, 09 Aug 2011 18:34:37 +0200 From: Johan Hovold To: Tony Lindgren Cc: Kevin Hilman , linux-omap@vger.kernel.org, Johan Hovold Subject: [PATCH 2/3] OMAP2+: pm: clean up error messages Date: Tue, 9 Aug 2011 18:34:20 +0200 Message-Id: <1312907661-24436-2-git-send-email-jhovold@gmail.com> X-Mailer: git-send-email 1.7.6 In-Reply-To: <1312907661-24436-1-git-send-email-jhovold@gmail.com> References: <1312907661-24436-1-git-send-email-jhovold@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Tue, 09 Aug 2011 16:34:52 +0000 (UTC) Replace all printks with pr_err. Clean up error messages by adding missing whitespace, fixing capitalisations, removing double newlines, and reducing verbosity. Signed-off-by: Johan Hovold --- arch/arm/mach-omap2/pm.c | 18 ++++++++---------- 1 files changed, 8 insertions(+), 10 deletions(-) diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c index fd77cf4..3837818 100644 --- a/arch/arm/mach-omap2/pm.c +++ b/arch/arm/mach-omap2/pm.c @@ -137,8 +137,8 @@ int omap_set_pwrdm_state(struct powerdomain *pwrdm, u32 state) ret = pwrdm_set_next_pwrst(pwrdm, state); if (ret) { - printk(KERN_ERR "Unable to set state of powerdomain: %s\n", - pwrdm->name); + pr_err("%s: unable to set state of powerdomain: %s\n", + __func__, pwrdm->name); goto err; } @@ -179,21 +179,20 @@ static int __init omap2_set_init_voltage(char *vdd_name, char *clk_name, unsigned long freq, bootup_volt; if (!vdd_name || !clk_name || !dev) { - printk(KERN_ERR "%s: Invalid parameters!\n", __func__); + pr_err("%s: invalid parameters\n", __func__); goto exit; } voltdm = omap_voltage_domain_lookup(vdd_name); if (IS_ERR(voltdm)) { - printk(KERN_ERR "%s: Unable to get vdd pointer for vdd_%s\n", + pr_err("%s: unable to get vdd pointer for vdd_%s\n", __func__, vdd_name); goto exit; } clk = clk_get(NULL, clk_name); if (IS_ERR(clk)) { - printk(KERN_ERR "%s: unable to get clk %s\n", - __func__, clk_name); + pr_err("%s: unable to get clk %s\n", __func__, clk_name); goto exit; } @@ -202,14 +201,14 @@ static int __init omap2_set_init_voltage(char *vdd_name, char *clk_name, opp = opp_find_freq_ceil(dev, &freq); if (IS_ERR(opp)) { - printk(KERN_ERR "%s: unable to find boot up OPP for vdd_%s\n", + pr_err("%s: unable to find boot up OPP for vdd_%s\n", __func__, vdd_name); goto exit; } bootup_volt = opp_get_voltage(opp); if (!bootup_volt) { - printk(KERN_ERR "%s: unable to find voltage corresponding" + pr_err("%s: unable to find voltage corresponding " "to the bootup OPP for vdd_%s\n", __func__, vdd_name); goto exit; } @@ -218,8 +217,7 @@ static int __init omap2_set_init_voltage(char *vdd_name, char *clk_name, return 0; exit: - printk(KERN_ERR "%s: Unable to set vdd_%s to its init voltage\n\n", - __func__, vdd_name); + pr_err("%s: unable to set vdd_%s\n", __func__, vdd_name); return -EINVAL; }