From patchwork Thu Aug 18 10:44:31 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Gadiyar X-Patchwork-Id: 1076022 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p7IAj4DJ032661 for ; Thu, 18 Aug 2011 10:45:08 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755493Ab1HRKol (ORCPT ); Thu, 18 Aug 2011 06:44:41 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:46381 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755166Ab1HRKok (ORCPT ); Thu, 18 Aug 2011 06:44:40 -0400 Received: from dbdp20.itg.ti.com ([172.24.170.38]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id p7IAiZ0G014029 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 18 Aug 2011 05:44:37 -0500 Received: from dbde71.ent.ti.com (localhost [127.0.0.1]) by dbdp20.itg.ti.com (8.13.8/8.13.8) with ESMTP id p7IAiYii025408; Thu, 18 Aug 2011 16:14:34 +0530 (IST) Received: from dbdp31.itg.ti.com (172.24.170.98) by DBDE71.ent.ti.com (172.24.170.149) with Microsoft SMTP Server id 8.3.106.1; Thu, 18 Aug 2011 16:14:34 +0530 Received: from linfarm476.india.ti.com (linfarm476.india.ti.com [10.24.132.205]) by dbdp31.itg.ti.com (8.13.8/8.13.8) with ESMTP id p7IAiWmm009933; Thu, 18 Aug 2011 16:14:33 +0530 (IST) Received: (from a0393673@localhost) by linfarm476.india.ti.com (8.12.11/8.13.8/Submit) id p7IAiWGY000731; Thu, 18 Aug 2011 16:14:32 +0530 From: Anand Gadiyar To: , , CC: Anand Gadiyar , Keshava Munegowda , Samuel Ortiz Subject: [PATCH] mfd: omap-usb-host: Make TLL mode work again Date: Thu, 18 Aug 2011 16:14:31 +0530 Message-ID: <1313664271-694-1-git-send-email-gadiyar@ti.com> X-Mailer: git-send-email 1.5.6.6 MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Thu, 18 Aug 2011 10:45:08 +0000 (UTC) This code section seems to have been accidentally copy pasted. It causes incorrect bits to be set up in the TLL_CHANNEL_CONF register and prevents the TLL mode from working correctly. Signed-off-by: Anand Gadiyar Cc: Keshava Munegowda Cc: Samuel Ortiz Acked-by: Felipe Balbi --- Against v3.1-rc2; tested against linux-next as of 20110817 as well. This probably needs to go to -stable as well. The original code by me worked fine but this was broken during the code reorganization Keshava did. drivers/mfd/omap-usb-host.c | 1 - 1 file changed, 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: linux-2.6/drivers/mfd/omap-usb-host.c =================================================================== --- linux-2.6.orig/drivers/mfd/omap-usb-host.c +++ linux-2.6/drivers/mfd/omap-usb-host.c @@ -676,7 +676,6 @@ static void usbhs_omap_tll_init(struct d | OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF | OMAP_TLL_CHANNEL_CONF_ULPIDDRMODE); - reg |= (1 << (i + 1)); } else continue;