From patchwork Tue Sep 6 11:58:54 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "K, Mythri P" X-Patchwork-Id: 1126272 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p86C7CH6031200 for ; Tue, 6 Sep 2011 12:07:24 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754445Ab1IFMHX (ORCPT ); Tue, 6 Sep 2011 08:07:23 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:56101 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754350Ab1IFMHG (ORCPT ); Tue, 6 Sep 2011 08:07:06 -0400 Received: from dbdp20.itg.ti.com ([172.24.170.38]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id p86C73Ri009882 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 6 Sep 2011 07:07:05 -0500 Received: from dbde71.ent.ti.com (localhost [127.0.0.1]) by dbdp20.itg.ti.com (8.13.8/8.13.8) with ESMTP id p86C72Du001278 for ; Tue, 6 Sep 2011 17:37:02 +0530 (IST) Received: from dbdp31.itg.ti.com (172.24.170.98) by DBDE71.ent.ti.com (172.24.170.149) with Microsoft SMTP Server id 8.3.106.1; Tue, 6 Sep 2011 17:37:02 +0530 Received: from localhost.localdomain (graphicspc.apr.dhcp.ti.com [172.24.136.217]) by dbdp31.itg.ti.com (8.13.8/8.13.8) with ESMTP id p86C6wwL026724; Tue, 6 Sep 2011 17:37:02 +0530 (IST) From: To: , CC: Mythri P K Subject: [PATCH v4 10/11] OMAP4: DSS2: HDMI: Function pointer approach to call Date: Tue, 6 Sep 2011 17:28:54 +0530 Message-ID: <1315310335-26054-11-git-send-email-mythripk@ti.com> X-Mailer: git-send-email 1.5.6.3 In-Reply-To: <1315310335-26054-10-git-send-email-mythripk@ti.com> References: <1315310335-26054-1-git-send-email-mythripk@ti.com> <1315310335-26054-2-git-send-email-mythripk@ti.com> <1315310335-26054-3-git-send-email-mythripk@ti.com> <1315310335-26054-4-git-send-email-mythripk@ti.com> <1315310335-26054-5-git-send-email-mythripk@ti.com> <1315310335-26054-6-git-send-email-mythripk@ti.com> <1315310335-26054-7-git-send-email-mythripk@ti.com> <1315310335-26054-8-git-send-email-mythripk@ti.com> <1315310335-26054-9-git-send-email-mythripk@ti.com> <1315310335-26054-10-git-send-email-mythripk@ti.com> MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Tue, 06 Sep 2011 12:07:24 +0000 (UTC) From: Mythri P K To make the current hdmi DSS driver compatible with future OMAP having different IP blocks( A combination of different core, PHY, PLL blocks), Add HDMI hdmi functions as a function pointer in dss_features to abstract hdmi dss driver IP agnostic, hdmi dss driver which will now access generic functions irrespective of underlying IP. Signed-off-by: Mythri P K --- drivers/video/omap2/dss/dss_features.c | 20 ++++++++++++++++++++ drivers/video/omap2/dss/dss_features.h | 3 +++ drivers/video/omap2/dss/hdmi.c | 19 ++++++++++--------- include/video/omapdss.h | 23 +++++++++++++++++++++++ include/video/ti_hdmi.h | 1 + 5 files changed, 57 insertions(+), 9 deletions(-) diff --git a/drivers/video/omap2/dss/dss_features.c b/drivers/video/omap2/dss/dss_features.c index b63c5f8..4d50b30 100644 --- a/drivers/video/omap2/dss/dss_features.c +++ b/drivers/video/omap2/dss/dss_features.c @@ -429,6 +429,26 @@ static const struct omap_dss_features omap4_dss_features = { .burst_size_unit = 16, }; +#if defined(CONFIG_OMAP4_DSS_HDMI) +/* HDMI OMAP4 Functions*/ +static const struct omap_hdmi_ip_ops omap4_hdmi_functions = { + + .video_configure = ti_hdmi_4xxx_basic_configure, + .phy_enable = ti_hdmi_4xxx_phy_enable, + .phy_disable = ti_hdmi_4xxx_phy_disable, + .read_edid = ti_hdmi_4xxx_read_edid, + .pll_enable = ti_hdmi_4xxx_pll_enable, + .pll_disable = ti_hdmi_4xxx_pll_disable, + .video_enable = ti_hdmi_4xxx_wp_video_start, +}; + +void dss_init_hdmi_ip_ops(struct hdmi_ip_data *ip_data) +{ + if (cpu_is_omap44xx()) + ip_data->ops = &omap4_hdmi_functions; +} +#endif + /* Functions returning values related to a DSS feature */ int dss_feat_get_num_mgrs(void) { diff --git a/drivers/video/omap2/dss/dss_features.h b/drivers/video/omap2/dss/dss_features.h index 4271e96..8b74f69 100644 --- a/drivers/video/omap2/dss/dss_features.h +++ b/drivers/video/omap2/dss/dss_features.h @@ -99,4 +99,7 @@ u32 dss_feat_get_burst_size_unit(void); /* in bytes */ bool dss_has_feature(enum dss_feat_id id); void dss_feat_get_reg_field(enum dss_feat_reg_field id, u8 *start, u8 *end); void dss_features_init(void); +#if defined(CONFIG_OMAP4_DSS_HDMI) +void dss_init_hdmi_ip_ops(struct hdmi_ip_data *ip_data); +#endif #endif diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c index b11ac70..6284460 100644 --- a/drivers/video/omap2/dss/hdmi.c +++ b/drivers/video/omap2/dss/hdmi.c @@ -186,6 +186,7 @@ int hdmi_init_display(struct omap_dss_device *dssdev) { DSSDBG("init_display\n"); + dss_init_hdmi_ip_ops(&hdmi.ip_data); return 0; } @@ -366,7 +367,7 @@ static void hdmi_read_edid(struct omap_video_timings *dp) memset(hdmi.edid, 0, HDMI_EDID_MAX_LENGTH); if (!hdmi.edid_set) - ret = ti_hdmi_4xxx_read_edid(&hdmi.ip_data, hdmi.edid, + ret = hdmi.ip_data.ops->read_edid(&hdmi.ip_data, hdmi.edid, HDMI_EDID_MAX_LENGTH); if (!ret) { if (!memcmp(hdmi.edid, edid_header, sizeof(edid_header))) { @@ -480,16 +481,16 @@ static int hdmi_power_on(struct omap_dss_device *dssdev) hdmi_compute_pll(dssdev, phy, &hdmi.ip_data.pll_data); - ti_hdmi_4xxx_wp_video_start(&hdmi.ip_data, 0); + hdmi.ip_data.ops->video_enable(&hdmi.ip_data, 0); /* config the PLL and PHY hdmi_set_pll_pwrfirst */ - r = ti_hdmi_4xxx_pll_enable(&hdmi.ip_data); + r = hdmi.ip_data.ops->pll_enable(&hdmi.ip_data); if (r) { DSSDBG("Failed to lock PLL\n"); goto err; } - r = ti_hdmi_4xxx_phy_enable(&hdmi.ip_data); + r = hdmi.ip_data.ops->phy_enable(&hdmi.ip_data); if (r) { DSSDBG("Failed to start PHY\n"); goto err; @@ -497,7 +498,7 @@ static int hdmi_power_on(struct omap_dss_device *dssdev) hdmi.ip_data.cfg.cm.mode = hdmi.mode; hdmi.ip_data.cfg.cm.code = hdmi.code; - ti_hdmi_4xxx_basic_configure(&hdmi.ip_data); + hdmi.ip_data.ops->video_configure(&hdmi.ip_data); /* Make selection of HDMI in DSS */ dss_select_hdmi_venc_clk_source(DSS_HDMI_M_PCLK); @@ -519,7 +520,7 @@ static int hdmi_power_on(struct omap_dss_device *dssdev) dispc_mgr_enable(OMAP_DSS_CHANNEL_DIGIT, 1); - ti_hdmi_4xxx_wp_video_start(&hdmi.ip_data, 1); + hdmi.ip_data.ops->video_enable(&hdmi.ip_data, 1); return 0; err: @@ -531,9 +532,9 @@ static void hdmi_power_off(struct omap_dss_device *dssdev) { dispc_mgr_enable(OMAP_DSS_CHANNEL_DIGIT, 0); - ti_hdmi_4xxx_wp_video_start(&hdmi.ip_data, 0); - ti_hdmi_4xxx_phy_disable(&hdmi.ip_data); - ti_hdmi_4xxx_pll_disable(&hdmi.ip_data); + hdmi.ip_data.ops->video_enable(&hdmi.ip_data, 0); + hdmi.ip_data.ops->phy_disable(&hdmi.ip_data); + hdmi.ip_data.ops->pll_disable(&hdmi.ip_data); hdmi_runtime_put(); hdmi.edid_set = 0; diff --git a/include/video/omapdss.h b/include/video/omapdss.h index 9398dd3..c8891d1 100644 --- a/include/video/omapdss.h +++ b/include/video/omapdss.h @@ -21,6 +21,9 @@ #include #include #include +#if defined(CONFIG_OMAP4_DSS_HDMI) +#include