From patchwork Fri Jun 29 01:25:23 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 1130371 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-linux-omap@patchwork.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 7B16BDFFEB for ; Fri, 29 Jun 2012 01:26:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755897Ab2F2B0I (ORCPT ); Thu, 28 Jun 2012 21:26:08 -0400 Received: from mail-we0-f174.google.com ([74.125.82.174]:62600 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755866Ab2F2BZy (ORCPT ); Thu, 28 Jun 2012 21:25:54 -0400 Received: by werb14 with SMTP id b14so825534wer.19 for ; Thu, 28 Jun 2012 18:25:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:x-gm-message-state; bh=/gi9VYyaFQj3RYwjYVacwkGVTBLbLWazw3KF+nmBQtI=; b=pHXrkSnN+xS/q9p6YmHvZIrEbPb19yNU9RwIMyAFdrGPCKon4lpornO3iWEjf5qCY5 jlBGBXBCteAfdNtYQK6MUbx+UQPK3g1LhXnBZ+3J5i+ZbnsHAbg3fBTn5uSqZOjS8GUW cfgtHd+6ORlis9Qj0JGWxpzpcq+6VPYZHxmnI7MkL7ozSGiJ6ez3c+uM0yryUsy3D0HO PoDqnaZC3s+Q+G2dfUspUm6LL08vOGCIWOE0uGwVdVeEh1UFGqlLPzUIJ7pnQ+Bl/QQ5 iZsPfaFvriHixgW8XbwdBxBPX1IvicsRXv23pASOMEmQxwKP5+wXBYGLwKyFJLF34REL Ci0A== Received: by 10.216.133.71 with SMTP id p49mr2220479wei.107.1340933149455; Thu, 28 Jun 2012 18:25:49 -0700 (PDT) Received: from localhost.localdomain (219.229.79.188.dynamic.jazztel.es. [188.79.229.219]) by mx.google.com with ESMTPS id ce3sm3749352wib.11.2012.06.28.18.25.47 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 28 Jun 2012 18:25:48 -0700 (PDT) From: Javier Martinez Canillas To: Kevin Hilman Cc: Tony Lindgren , Russell King , Tero Kristo , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Javier Martinez Canillas Subject: [PATCH 1/1] ARM: OMAP3: PM: don't explicitly enable the IO-chain interrupt Date: Fri, 29 Jun 2012 03:25:23 +0200 Message-Id: <1340933123-30401-1-git-send-email-javier@dowhile0.org> X-Mailer: git-send-email 1.7.7.6 X-Gm-Message-State: ALoCoQlQ6XcPAVo9iiFJanYB1/Q8IlPNWHmq/aVSZ9+x+rjMgC3fYah4Gj89Mw9z+Rhb3bHah8nd Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org commit 99b59df0 ARM: OMAP3: PM: fix shared PRCM interrupt leave disabled at boot set the IRQ_NOAUTOEN flag to the PCRM IO-chain irq to avoid this interrupt until the PM core code is ready to handle the interrupts. It seems that this is not needed anymore after the OMAP PRCM I/O chain code re-implementation introduced on merge commit: 9a17d88 Merge tag 'omap-devel-c-for-3.6' of git://git.kernel.org/pub/scm/linux/kernel/ The IRQ_NOAUTOEN flags is not set for the PRCM I/O irq anymore on the new implementation. This has the effect that a request_irq() for the PRCM I/O chain irq will auto-enable the requested IRQ and a later call to enable_irq() will lead to the following warning: [ 3.849334] WARNING: at kernel/irq/manage.c:436 enable_irq+0x3c/0x78() [ 3.856231] Unbalanced enable for IRQ 297 [ 3.860473] Modules linked in: [ 3.863739] [] (unwind_backtrace+0x0/0xf0) from [] (warn_slowpath_common+0x4c/0x64) [ 3.873687] [] (warn_slowpath_common+0x4c/0x64) from [] (warn_slowpath_fmt+0x30/0x40) [ 3.883819] [] (warn_slowpath_fmt+0x30/0x40) from [] (enable_irq+0x3c/0x78) [ 3.893035] [] (enable_irq+0x3c/0x78) from [] (omap3_pm_init+0x328/0x5f4) [ 3.902099] [] (omap3_pm_init+0x328/0x5f4) from [] (init_machine_late+0x1c/0x28) [ 3.911773] [] (init_machine_late+0x1c/0x28) from [] (do_one_initcall+0x34/0x178) [ 3.921539] [] (do_one_initcall+0x34/0x178) from [] (kernel_init+0xfc/0x1c0) [ 3.930847] [] (kernel_init+0xfc/0x1c0) from [] (kernel_thread_exit+0x0/0x8) [ 3.940246] ---[ end trace 55a0ad32ca2ca682 ]--- Signed-off-by: Javier Martinez Canillas --- This patch was generated on top of git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git branch: master arch/arm/mach-omap2/pm34xx.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c index e4fc88c..6f14e26 100644 --- a/arch/arm/mach-omap2/pm34xx.c +++ b/arch/arm/mach-omap2/pm34xx.c @@ -693,7 +693,6 @@ int __init omap3_pm_init(void) ret = request_irq(omap_prcm_event_to_irq("io"), _prcm_int_handle_io, IRQF_SHARED | IRQF_NO_SUSPEND, "pm_io", omap3_pm_init); - enable_irq(omap_prcm_event_to_irq("io")); if (ret) { pr_err("pm: Failed to request pm_io irq\n");