From patchwork Tue Jul 24 08:47:20 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shubhrajyoti Datta X-Patchwork-Id: 1230551 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id AC45EDF25A for ; Tue, 24 Jul 2012 08:47:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751101Ab2GXIrm (ORCPT ); Tue, 24 Jul 2012 04:47:42 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:50208 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750943Ab2GXIrl (ORCPT ); Tue, 24 Jul 2012 04:47:41 -0400 Received: from dbdp20.itg.ti.com ([172.24.170.38]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id q6O8lTXL004051; Tue, 24 Jul 2012 03:47:30 -0500 Received: from DBDE70.ent.ti.com (localhost [127.0.0.1]) by dbdp20.itg.ti.com (8.13.8/8.13.8) with ESMTP id q6O8lSwk015254; Tue, 24 Jul 2012 14:17:28 +0530 (IST) Received: from dbdp33.itg.ti.com (172.24.170.252) by dbde70.ent.ti.com (172.24.170.148) with Microsoft SMTP Server id 14.1.323.3; Tue, 24 Jul 2012 14:17:27 +0530 Received: from ula0393217.india.ti.com (smtpvbd.itg.ti.com [172.24.170.250]) by dbdp33.itg.ti.com (8.13.8/8.13.8) with ESMTP id q6O8lQdB010890; Tue, 24 Jul 2012 14:17:27 +0530 From: Shubhrajyoti D To: CC: , , Shubhrajyoti D , Kevin Hilman Subject: [PATCH RFC] mmc: omap_hsmmc: Fix the warning Date: Tue, 24 Jul 2012 14:17:20 +0530 Message-ID: <1343119640-24516-1-git-send-email-shubhrajyoti@ti.com> X-Mailer: git-send-email 1.7.5.4 MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org The commit 9c17d08 [mmc: omap_hsmmc: ensure probe returns error upon resource failure] introduced the below warning. CC drivers/of/of_net.o drivers/mmc/host/omap_hsmmc.c: In function 'omap_hsmmc_probe': drivers/mmc/host/omap_hsmmc.c:1936: warning: statement with no effect Fix the same by assigning the error value to ret. Cc: Kevin Hilman Reported-by: Archit Taneja Signed-off-by: Shubhrajyoti D --- drivers/mmc/host/omap_hsmmc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index be8631d..3a09f93 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -1933,7 +1933,7 @@ static int __devinit omap_hsmmc_probe(struct platform_device *pdev) host->tx_chan = dma_request_channel(mask, omap_dma_filter_fn, &tx_req); if (!host->tx_chan) { dev_err(mmc_dev(host->mmc), "unable to obtain TX DMA engine channel %u\n", tx_req); - ret -ENXIO; + ret = -ENXIO; goto err_irq; }