From patchwork Fri Jul 27 08:32:00 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "B, Ravi" X-Patchwork-Id: 1247381 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 6667BDFFC0 for ; Fri, 27 Jul 2012 08:33:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752494Ab2G0Icy (ORCPT ); Fri, 27 Jul 2012 04:32:54 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:47976 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752189Ab2G0IcY (ORCPT ); Fri, 27 Jul 2012 04:32:24 -0400 Received: from dbdp20.itg.ti.com ([172.24.170.38]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id q6R8WHZ1011288; Fri, 27 Jul 2012 03:32:17 -0500 Received: from DBDE71.ent.ti.com (localhost [127.0.0.1]) by dbdp20.itg.ti.com (8.13.8/8.13.8) with ESMTP id q6R8WDcm015783; Fri, 27 Jul 2012 14:02:16 +0530 (IST) Received: from dbdp32.itg.ti.com (172.24.170.251) by DBDE71.ent.ti.com (172.24.170.149) with Microsoft SMTP Server id 14.1.323.3; Fri, 27 Jul 2012 14:02:14 +0530 Received: from localhost.localdomain (dbdp20.itg.ti.com [172.24.170.38]) by dbdp32.itg.ti.com (8.13.8/8.13.8) with ESMTP id q6R8W9qE012865; Fri, 27 Jul 2012 14:02:13 +0530 From: Ravi B To: CC: , , , , , , Ajay Kumar Gupta , Ravi B Subject: [PATCH v6 04/11] usb: otg: nop: add support for multiple tranceiver Date: Fri, 27 Jul 2012 14:02:00 +0530 Message-ID: <1343377927-7850-4-git-send-email-ravibabu@ti.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <1343377927-7850-1-git-send-email-ravibabu@ti.com> References: <1343377927-7850-1-git-send-email-ravibabu@ti.com> MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org From: Ajay Kumar Gupta Currently we have one single nop transceiver support as same is defined as a global variable in drivers/usb/otg/nop-usb-xceiv.c. This need to be changed to support multiple otg controller each using nop transceiver on a platform such as am335x. Signed-off-by: Ajay Kumar Gupta Signed-off-by: Ravi B --- drivers/usb/musb/am35x.c | 2 +- drivers/usb/musb/blackfin.c | 2 +- drivers/usb/musb/da8xx.c | 2 +- drivers/usb/musb/davinci.c | 4 +- drivers/usb/musb/musb_dsps.c | 8 +++--- drivers/usb/musb/tusb6010.c | 4 +- drivers/usb/otg/nop-usb-xceiv.c | 54 +++++++++++++++++++++++++++++++++----- include/linux/usb/otg.h | 4 +- 8 files changed, 60 insertions(+), 20 deletions(-) diff --git a/drivers/usb/musb/am35x.c b/drivers/usb/musb/am35x.c index 01203eb..984e439 100644 --- a/drivers/usb/musb/am35x.c +++ b/drivers/usb/musb/am35x.c @@ -408,7 +408,7 @@ static int am35x_musb_exit(struct musb *musb) data->set_phy_power(0); usb_put_phy(musb->xceiv); - usb_nop_xceiv_unregister(); + usb_nop_xceiv_unregister(musb->xceiv); return 0; } diff --git a/drivers/usb/musb/blackfin.c b/drivers/usb/musb/blackfin.c index c848b82..f1fe728 100644 --- a/drivers/usb/musb/blackfin.c +++ b/drivers/usb/musb/blackfin.c @@ -442,7 +442,7 @@ static int bfin_musb_exit(struct musb *musb) gpio_free(musb->config->gpio_vrsel); usb_put_phy(musb->xceiv); - usb_nop_xceiv_unregister(); + usb_nop_xceiv_unregister(musb->xceiv); return 0; } diff --git a/drivers/usb/musb/da8xx.c b/drivers/usb/musb/da8xx.c index cebd9d7..a5260b6 100644 --- a/drivers/usb/musb/da8xx.c +++ b/drivers/usb/musb/da8xx.c @@ -460,7 +460,7 @@ static int da8xx_musb_exit(struct musb *musb) phy_off(); usb_put_phy(musb->xceiv); - usb_nop_xceiv_unregister(); + usb_nop_xceiv_unregister(musb->xceiv); return 0; } diff --git a/drivers/usb/musb/davinci.c b/drivers/usb/musb/davinci.c index 3f094f2..c7ef654 100644 --- a/drivers/usb/musb/davinci.c +++ b/drivers/usb/musb/davinci.c @@ -447,7 +447,7 @@ static int davinci_musb_init(struct musb *musb) fail: usb_put_phy(musb->xceiv); unregister: - usb_nop_xceiv_unregister(); + usb_nop_xceiv_unregister(musb->xceiv); return -ENODEV; } @@ -496,7 +496,7 @@ static int davinci_musb_exit(struct musb *musb) phy_off(); usb_put_phy(musb->xceiv); - usb_nop_xceiv_unregister(); + usb_nop_xceiv_unregister(musb->xceiv); return 0; } diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c index 2fd5dc8..4fcfa1a 100644 --- a/drivers/usb/musb/musb_dsps.c +++ b/drivers/usb/musb/musb_dsps.c @@ -424,7 +424,7 @@ static int dsps_musb_init(struct musb *musb) /* mentor core register starts at offset of 0x400 from musb base */ musb->mregs += wrp->musb_core_offset; - /* NOP driver needs change if supporting dual instance */ + /* Register NOP driver */ usb_nop_xceiv_register(); musb->xceiv = usb_get_phy(USB_PHY_TYPE_USB2); if (IS_ERR_OR_NULL(musb->xceiv)) @@ -460,7 +460,7 @@ static int dsps_musb_init(struct musb *musb) return 0; err0: usb_put_phy(musb->xceiv); - usb_nop_xceiv_unregister(); + usb_nop_xceiv_unregister(musb->xceiv); return status; } @@ -477,9 +477,9 @@ static int dsps_musb_exit(struct musb *musb) /* Shutdown the on-chip PHY and its PLL. */ musb_dsps_phy_control(glue, pdev->id, 0); - /* NOP driver needs change if supporting dual instance */ + /* Unregister NOP driver */ usb_put_phy(musb->xceiv); - usb_nop_xceiv_unregister(); + usb_nop_xceiv_unregister(musb->xceiv); return 0; } diff --git a/drivers/usb/musb/tusb6010.c b/drivers/usb/musb/tusb6010.c index 64a0e95..3a12330 100644 --- a/drivers/usb/musb/tusb6010.c +++ b/drivers/usb/musb/tusb6010.c @@ -1132,7 +1132,7 @@ done: iounmap(sync); usb_put_phy(musb->xceiv); - usb_nop_xceiv_unregister(); + usb_nop_xceiv_unregister(musb->xceiv); } return ret; } @@ -1148,7 +1148,7 @@ static int tusb_musb_exit(struct musb *musb) iounmap(musb->sync_va); usb_put_phy(musb->xceiv); - usb_nop_xceiv_unregister(); + usb_nop_xceiv_unregister(musb->xceiv); return 0; } diff --git a/drivers/usb/otg/nop-usb-xceiv.c b/drivers/usb/otg/nop-usb-xceiv.c index 803f958..fc899e4 100644 --- a/drivers/usb/otg/nop-usb-xceiv.c +++ b/drivers/usb/otg/nop-usb-xceiv.c @@ -31,30 +31,69 @@ #include #include #include +#include struct nop_usb_xceiv { struct usb_phy phy; struct device *dev; + struct platform_device *pd; }; -static struct platform_device *pd; +static DEFINE_IDA(nop_ida); -void usb_nop_xceiv_register(void) +static int nop_get_id(gfp_t gfp_mask) { - if (pd) + int ret, id; + + ret = ida_pre_get(&nop_ida, gfp_mask); + if (!ret) { + pr_err("failed to reserve resource for id\n"); + return -ENOMEM; + } + + ret = ida_get_new(&nop_ida, &id); + if (ret < 0) { + pr_err("failed to allocate a new id\n"); + return ret; + } + + return id; +} + +static void nop_put_id(int id) +{ + + pr_info("removing id %d\n", id); + ida_remove(&nop_ida, id); +} + +void usb_nop_xceiv_register() +{ + struct platform_device *pd; + int id; + + id = nop_get_id(GFP_KERNEL); + if (id < 0) { + pr_err("failed to allocate a new id\n"); return; - pd = platform_device_register_simple("nop_usb_xceiv", -1, NULL, 0); + } + + pd = platform_device_register_simple("nop_usb_xceiv", id, NULL, 0); if (!pd) { - printk(KERN_ERR "Unable to register usb nop transceiver\n"); + pr_err("Unable to register usb nop transceiver\n"); return; } } EXPORT_SYMBOL(usb_nop_xceiv_register); -void usb_nop_xceiv_unregister(void) +void usb_nop_xceiv_unregister(struct usb_phy *phy) { + struct nop_usb_xceiv *nop = container_of(phy, + struct nop_usb_xceiv, phy); + struct platform_device *pd = nop->pd; + platform_device_unregister(pd); - pd = NULL; + nop_put_id(pd->id); } EXPORT_SYMBOL(usb_nop_xceiv_unregister); @@ -107,6 +146,7 @@ static int __devinit nop_usb_xceiv_probe(struct platform_device *pdev) return -ENOMEM; } + nop->pd = pdev; nop->dev = &pdev->dev; nop->phy.dev = nop->dev; nop->phy.label = "nop-xceiv"; diff --git a/include/linux/usb/otg.h b/include/linux/usb/otg.h index 4636d39..2d7704e 100644 --- a/include/linux/usb/otg.h +++ b/include/linux/usb/otg.h @@ -138,13 +138,13 @@ extern void usb_remove_phy(struct usb_phy *); #if defined(CONFIG_NOP_USB_XCEIV) || (defined(CONFIG_NOP_USB_XCEIV_MODULE) && defined(MODULE)) /* sometimes transceivers are accessed only through e.g. ULPI */ extern void usb_nop_xceiv_register(void); -extern void usb_nop_xceiv_unregister(void); +extern void usb_nop_xceiv_unregister(struct usb_phy *); #else static inline void usb_nop_xceiv_register(void) { } -static inline void usb_nop_xceiv_unregister(void) +static inline void usb_nop_xceiv_unregister(struct usb_phy *phy) { } #endif