From patchwork Thu Aug 23 10:32:54 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 1365721 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id A997EDFFCC for ; Thu, 23 Aug 2012 10:40:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030298Ab2HWKkF (ORCPT ); Thu, 23 Aug 2012 06:40:05 -0400 Received: from na3sys009aog132.obsmtp.com ([74.125.149.250]:48447 "EHLO na3sys009aog132.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933854Ab2HWKho (ORCPT ); Thu, 23 Aug 2012 06:37:44 -0400 Received: from mail-lb0-f177.google.com ([209.85.217.177]) (using TLSv1) by na3sys009aob132.postini.com ([74.125.148.12]) with SMTP ID DSNKUDYH93pp8vzGzNavA3FgUi5SetPXGZTz@postini.com; Thu, 23 Aug 2012 03:37:44 PDT Received: by lbbgf7 with SMTP id gf7so316157lbb.36 for ; Thu, 23 Aug 2012 03:37:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=N/oJUvvM493l3bjQtPL2rl2fyNWVAD2VU6fbbzPMT0Y=; b=Bz/dPq6Tj1cU6ZKVvv9fFaII7tcg9nQiO3bJumEdMnZkASyaJG6rKiYzOQ2HP2h4Zd LDD9IaOET+HAZpxwamVb3fC54oWPR5DS3D+eFC93u3ZYXhRO5fntfXGUY8n733QBPTIi PPXznvaL2GQlaj+Yby41bkfGws8DMbvs6rQruY6X5PDgnD81iyXmIRoKvKzEgOywmduf wHEpfLR0fQRlP8ZbR22PooNEwhWnAq8Jk/EIyr2W/zDcbEdO3f1wqpFW4JieYZfmT5p6 +b7Q0JtIImSWzoKRiHEL5w3DOBztN/lcPgAWRq0135tasKHxxD4C5cPtgM9uB/qOGiUL s6vQ== Received: by 10.112.47.133 with SMTP id d5mr674246lbn.47.1345718262044; Thu, 23 Aug 2012 03:37:42 -0700 (PDT) Received: from localhost (cs78217178.pp.htv.fi. [62.78.217.178]) by mx.google.com with ESMTPS id sm7sm7096157lab.5.2012.08.23.03.37.40 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 23 Aug 2012 03:37:41 -0700 (PDT) From: Felipe Balbi To: alan@linux.intel.com Cc: Tony Lindgren , Kevin Hilman , Linux OMAP Mailing List , Linux ARM Kernel Mailing List , linux-serial@vger.kernel.org, Linux Kernel Mailing List , Santosh Shilimkar , Shubhrajyoti Datta , Sourav Poddar , Ruchika Kharwar , Nishanth Menon , Felipe Balbi Subject: [PATCH v3 14/23] serial: omap: fix sequence of pm_runtime_* calls. Date: Thu, 23 Aug 2012 13:32:54 +0300 Message-Id: <1345717983-18179-15-git-send-email-balbi@ti.com> X-Mailer: git-send-email 1.7.12.rc3 In-Reply-To: <1345717983-18179-1-git-send-email-balbi@ti.com> References: <1345717983-18179-1-git-send-email-balbi@ti.com> X-Gm-Message-State: ALoCoQmw3EyZwblp1SnM08mpDBDwtnMiW9mUTlZnBFa+SGFh/h6SjYazwYDvifKRf87UKhXSNY9z Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org From: Ruchika Kharwar pm_runtime_enable() needs to be invoked before pm_runtime_use_autosuspend(), and pm_runtime_set_autosuspend_delay() functions. Tested-by: Shubhrajyoti D Signed-off-by: Nishanth Menon Signed-off-by: Ruchika Kharwar Signed-off-by: Felipe Balbi --- drivers/tty/serial/omap-serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c index 8a60212..8254561 100644 --- a/drivers/tty/serial/omap-serial.c +++ b/drivers/tty/serial/omap-serial.c @@ -1300,12 +1300,12 @@ static int serial_omap_probe(struct platform_device *pdev) INIT_WORK(&up->qos_work, serial_omap_uart_qos_work); platform_set_drvdata(pdev, up); + pm_runtime_enable(&pdev->dev); pm_runtime_use_autosuspend(&pdev->dev); pm_runtime_set_autosuspend_delay(&pdev->dev, omap_up_info->autosuspend_timeout); pm_runtime_irq_safe(&pdev->dev); - pm_runtime_enable(&pdev->dev); pm_runtime_get_sync(&pdev->dev); omap_serial_fill_features_erratas(up);