From patchwork Thu Aug 23 10:32:55 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 1365591 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 73B923FC66 for ; Thu, 23 Aug 2012 10:38:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933901Ab2HWKiK (ORCPT ); Thu, 23 Aug 2012 06:38:10 -0400 Received: from na3sys009aog122.obsmtp.com ([74.125.149.147]:40298 "EHLO na3sys009aog122.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933863Ab2HWKhs (ORCPT ); Thu, 23 Aug 2012 06:37:48 -0400 Received: from mail-lb0-f180.google.com ([209.85.217.180]) (using TLSv1) by na3sys009aob122.postini.com ([74.125.148.12]) with SMTP ID DSNKUDYH+pDOZeXpVeIRPXnz4GwAQaDLsaX6@postini.com; Thu, 23 Aug 2012 03:37:47 PDT Received: by lbon10 with SMTP id n10so319676lbo.11 for ; Thu, 23 Aug 2012 03:37:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=cKGuBs2o56mlWgf50bx4v5OIaiG7c2GetX+K4b0Ukmg=; b=CnsFmX6c+zPDlcaIP1mwzA+0yWGhyA+LuXs2TsDhDs7tyO3LEH5ex1kvNZZpTO7TSW KDUnRBcqY4GCptk7RNCEYqjYvI8ScXRaseVVO89f11vZ/Bw3OBkchWv6H0aBunO0S/NM cO7gAHtUGUdt9ivrJjoK8E897p0bCo3aI9u31f/65/hc0BvCBw3L245Nh08Q7Vgj3MR4 cYIikFAwCfn1gh+BeSa/EgF4m0SBdxKZr0rACB0Zc6yxhLR5AggOKvUNIeVIRXBduljZ TtNm0oYDj4XpwahIBANIBjxNHRC2w8QUueF+gQlTLqNs5gwRa0ALgr9foB/qSg5N2RiU MwkA== Received: by 10.112.100.65 with SMTP id ew1mr689939lbb.16.1345718264720; Thu, 23 Aug 2012 03:37:44 -0700 (PDT) Received: from localhost (cs78217178.pp.htv.fi. [62.78.217.178]) by mx.google.com with ESMTPS id hz16sm7092761lab.6.2012.08.23.03.37.43 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 23 Aug 2012 03:37:43 -0700 (PDT) From: Felipe Balbi To: alan@linux.intel.com Cc: Tony Lindgren , Kevin Hilman , Linux OMAP Mailing List , Linux ARM Kernel Mailing List , linux-serial@vger.kernel.org, Linux Kernel Mailing List , Santosh Shilimkar , Shubhrajyoti Datta , Sourav Poddar , Felipe Balbi , Ruchika Kharwar Subject: [PATCH v3 15/23] serial: omap: optimization with section annotations Date: Thu, 23 Aug 2012 13:32:55 +0300 Message-Id: <1345717983-18179-16-git-send-email-balbi@ti.com> X-Mailer: git-send-email 1.7.12.rc3 In-Reply-To: <1345717983-18179-1-git-send-email-balbi@ti.com> References: <1345717983-18179-1-git-send-email-balbi@ti.com> X-Gm-Message-State: ALoCoQn0g/fOIPHoQoZ3pYoULtKp2BqqixSFXNZZaSN7QM+P3qUxEXBC66oU+AwaSWfJVGhBO2/M Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Two functions: omap_serial_fill_features_erratas() and of_get_uart_port_info() are only called from probe(). Marking them as __devinit gives us another oportunity to free some code after .init.text is done. Tested-by: Shubhrajyoti D Signed-off-by: Ruchika Kharwar Signed-off-by: Felipe Balbi --- drivers/tty/serial/omap-serial.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c index 8254561..bdfd019 100644 --- a/drivers/tty/serial/omap-serial.c +++ b/drivers/tty/serial/omap-serial.c @@ -1154,7 +1154,7 @@ static int serial_omap_resume(struct device *dev) } #endif -static void omap_serial_fill_features_erratas(struct uart_omap_port *up) +static void __devinit omap_serial_fill_features_erratas(struct uart_omap_port *up) { u32 mvr, scheme; u16 revision, major, minor; @@ -1207,7 +1207,7 @@ static void omap_serial_fill_features_erratas(struct uart_omap_port *up) } } -static struct omap_uart_port_info *of_get_uart_port_info(struct device *dev) +static __devinit struct omap_uart_port_info *of_get_uart_port_info(struct device *dev) { struct omap_uart_port_info *omap_up_info; @@ -1220,7 +1220,7 @@ static struct omap_uart_port_info *of_get_uart_port_info(struct device *dev) return omap_up_info; } -static int serial_omap_probe(struct platform_device *pdev) +static int __devinit serial_omap_probe(struct platform_device *pdev) { struct uart_omap_port *up; struct resource *mem, *irq; @@ -1331,7 +1331,7 @@ err_port_line: return ret; } -static int serial_omap_remove(struct platform_device *dev) +static int __devexit serial_omap_remove(struct platform_device *dev) { struct uart_omap_port *up = platform_get_drvdata(dev); @@ -1475,7 +1475,7 @@ MODULE_DEVICE_TABLE(of, omap_serial_of_match); static struct platform_driver serial_omap_driver = { .probe = serial_omap_probe, - .remove = serial_omap_remove, + .remove = __devexit_p(serial_omap_remove), .driver = { .name = DRIVER_NAME, .pm = &serial_omap_dev_pm_ops,