From patchwork Thu Sep 6 10:02:05 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "AnilKumar, Chimata" X-Patchwork-Id: 1412741 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 33906DFFCF for ; Thu, 6 Sep 2012 10:03:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754306Ab2IFKDe (ORCPT ); Thu, 6 Sep 2012 06:03:34 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:58035 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753451Ab2IFKDd (ORCPT ); Thu, 6 Sep 2012 06:03:33 -0400 Received: from dbdp20.itg.ti.com ([172.24.170.38]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id q86A3QLL009835; Thu, 6 Sep 2012 05:03:27 -0500 Received: from DBDE71.ent.ti.com (localhost [127.0.0.1]) by dbdp20.itg.ti.com (8.13.8/8.13.8) with ESMTP id q86A3ODE012325; Thu, 6 Sep 2012 15:33:24 +0530 (IST) Received: from dbdp32.itg.ti.com (172.24.170.251) by DBDE71.ent.ti.com (172.24.170.149) with Microsoft SMTP Server id 14.1.323.3; Thu, 6 Sep 2012 15:33:24 +0530 Received: from localhost.localdomain (dbdp20.itg.ti.com [172.24.170.38]) by dbdp32.itg.ti.com (8.13.8/8.13.8) with ESMTP id q86A3L3D018141; Thu, 6 Sep 2012 15:33:22 +0530 From: AnilKumar Ch To: , CC: , , , , , AnilKumar Ch Subject: [PATCH v3] of: Modify c_can binding documentation Date: Thu, 6 Sep 2012 15:32:05 +0530 Message-ID: <1346925725-19873-1-git-send-email-anilkumar@ti.com> X-Mailer: git-send-email 1.7.0.4 MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Modify c_can binding documentation according to recent review comments on device tree data addition patches. Signed-off-by: AnilKumar Ch --- Changes from v2: - Incorporated Marc's comments on v2 * Fixed typo mistake by renaming d_can1 to dcan1 Changes from v1: - Separated from "Add DT for AM33XX devices" patch series - Incorporated Stephen Warren's review comments on v1 * Removed status and interrupt-parent description from c_can.txt file because these are device specific parameters. .../devicetree/bindings/net/can/c_can.txt | 24 +++++++++++++++----- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/net/can/c_can.txt b/Documentation/devicetree/bindings/net/can/c_can.txt index a43f083..8f1ae81 100644 --- a/Documentation/devicetree/bindings/net/can/c_can.txt +++ b/Documentation/devicetree/bindings/net/can/c_can.txt @@ -10,7 +10,6 @@ Required properties: number Optional properties: -- interrupt-parent : The parent interrupt controller - ti,hwmods : Must be "d_can" or "c_can", n being the instance number @@ -20,18 +19,31 @@ Future plan is to migrate hwmod data base contents into device tree blob so that, all the required data will be used from device tree dts file. -Examples: +Example: - d_can@481D0000 { +Step1: SoC common .dtsi file + + dcan1: d_can@481d0000 { compatible = "bosch,d_can"; - reg = <0x481D0000 0x1000>; - interrupts = <55 0x4>; + reg = <0x481d0000 0x2000>; + interrupts = <55>; interrupt-parent = <&intc>; + status = "disabled"; }; (or) - d_can@481D0000 { + dcan1: d_can@481d0000 { compatible = "bosch,d_can"; ti,hwmods = "d_can1"; + reg = <0x481d0000 0x2000>; + interrupts = <55>; + interrupt-parent = <&intc>; + status = "disabled"; + }; + +Step 2: board specific .dts file + + &dcan1 { + status = "okay"; };