From patchwork Tue Sep 11 06:28:54 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Afzal Mohammed X-Patchwork-Id: 1435571 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 4A53B3FC33 for ; Tue, 11 Sep 2012 06:29:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755537Ab2IKG3G (ORCPT ); Tue, 11 Sep 2012 02:29:06 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:39363 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753977Ab2IKG3F (ORCPT ); Tue, 11 Sep 2012 02:29:05 -0400 Received: from dbdp20.itg.ti.com ([172.24.170.38]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id q8B6Sx9g013889; Tue, 11 Sep 2012 01:29:00 -0500 Received: from DBDE71.ent.ti.com (localhost [127.0.0.1]) by dbdp20.itg.ti.com (8.13.8/8.13.8) with ESMTP id q8B6SvVc000498; Tue, 11 Sep 2012 11:58:57 +0530 (IST) Received: from dbdp32.itg.ti.com (172.24.170.251) by DBDE71.ent.ti.com (172.24.170.149) with Microsoft SMTP Server id 14.1.323.3; Tue, 11 Sep 2012 11:58:57 +0530 Received: from localhost.localdomain (dbdp20.itg.ti.com [172.24.170.38]) by dbdp32.itg.ti.com (8.13.8/8.13.8) with ESMTP id q8B6Sslh018351; Tue, 11 Sep 2012 11:58:55 +0530 From: Afzal Mohammed To: , , , CC: Afzal Mohammed Subject: [PATCH] mtd: nand: omap2: fix error path Date: Tue, 11 Sep 2012 11:58:54 +0530 Message-ID: <1347344934-28103-1-git-send-email-afzal@ti.com> X-Mailer: git-send-email 1.7.0.4 MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Let probe return error value if gpmc terminal count interrupt could not be obtained Signed-off-by: Afzal Mohammed --- Hi, My commit (now in l-o/devel-gpmc), "bd4156f mtd: nand: omap2: use gpmc provided irqs" did not propogate error code properly due to which this fix was required. But this has not been mentioned in commit message as it is not yet in mainline. Regards Afzal drivers/mtd/nand/omap2.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c index 337cf0a..27293e3 100644 --- a/drivers/mtd/nand/omap2.c +++ b/drivers/mtd/nand/omap2.c @@ -1404,6 +1404,7 @@ static int __devinit omap_nand_probe(struct platform_device *pdev) info->gpmc_irq_count = platform_get_irq(pdev, 1); if (info->gpmc_irq_count <= 0) { dev_err(&pdev->dev, "error getting count irq\n"); + err = -ENODEV; goto out_release_mem_region; } err = request_irq(info->gpmc_irq_count, omap_nand_irq,