| Message ID | 1351507226-10328-1-git-send-email-sourav.poddar@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Oct 29, 2012 at 04:10:26PM +0530, Sourav Poddar wrote: > Add keypad data node in omap5-evm. > > Based on I2C support patch for omap5, which has been > already posted as a different series. > > Tested on omap5430 evm with 3.7-rc1 kernel. > > Cc: Felipe Balbi <balbi@ti.com> you can change this into an Acked-by: Felipe Balbi <balbi@ti.com> if you wish. > Cc: Santosh Shilimkar <santosh.shilimkar@ti.com> > > Tested on omap5430 sdp with 3.7-rc1 kernel. > > Signed-off-by: Sourav Poddar <sourav.poddar@ti.com> > --- > arch/arm/boot/dts/omap5-evm.dts | 95 +++++++++++++++++++++++++++++++++++++++ > 1 files changed, 95 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/omap5-evm.dts b/arch/arm/boot/dts/omap5-evm.dts > index c663eba..b812d6d 100644 > --- a/arch/arm/boot/dts/omap5-evm.dts > +++ b/arch/arm/boot/dts/omap5-evm.dts > @@ -140,3 +140,98 @@ > &mcbsp3 { > status = "disabled"; > }; > + > +&i2c5 { > + clock-frequency = <400000>; > + > + smsc@38 { > + compatible = "smscece1099"; > + reg = <0x38>; > + clock = <0x13>; > + keypad { > + compatible = "smsc,keypad"; > + interrupt-parent = <&gpio5>; > + interrupts = <23>; /* gpio line 151 */ > + keypad,num-rows = <8>; > + keypad,num-columns = <16>; > + linux,keymap = < 0x20041 /* KEY_F7 */ > + 0x30001 /* KEY_ESC */ > + 0x4003e /* KEY_F4 */ > + 0x50022 /* KEY_G */ > + 0x70023 /* KEY_H */ > + 0x9009a /* KEY_CYCLEWINDOWS */ > + 0xc000e /* KEY_BACKSPACE */ > + 0xd0057 /* KEY_F11 */ > + 0xe009f /* KEY_FORWARD */ > + 0xf006e /* KEY_INSERT */ > + 0x1020036 /* KEY_RIGHTSHIFT */ > + 0x1030011 /* KEY_W */ > + 0x1040010 /* KEY_Q */ > + 0x1050012 /* KEY_E */ > + 0x1070013 /* KEY_R */ > + 0x1080016 /* KEY_U */ > + 0x10c0017 /* KEY_I */ > + 0x10d0067 /* KEY_UP */ > + 0x10e0018 /* KEY_O */ > + 0x10f0019 /* KEY_LEFT */ > + 0x2020003 /* KEY_2 */ > + 0x2040004 /* KEY_1 */ > + 0x2050005 /* KEY_3 */ > + 0x2070008 /* KEY_4 */ > + 0x2080009 /* KEY_7 */ > + 0x20b0064 /* KEY_8 */ > + 0x20c006c /* KEY_RIGHTALT */ > + 0x20d000a /* KEY_DOWN */ > + 0x20e0001 /* KEY_0 */ > + 0x20f006a /* KEY_RIGHT */ > + 0x3010061 /* KEY_RIGHTCTRL */ > + 0x302001f /* KEY_S */ > + 0x303001e /* KEY_A */ > + 0x3040020 /* KEY_D */ > + 0x3050021 /* KEY_F */ > + 0x3070024 /* KEY_J */ > + 0x3080025 /* KEY_K */ > + 0x30c001c /* KEY_ENTER */ > + 0x30d0026 /* KEY_L */ > + 0x30e0027 /* KEY_SEMICOLON */ > + 0x400002a /* KEY_LEFTSHIFT */ > + 0x402002d /* KEY_X */ > + 0x403002c /* KEY_Z */ > + 0x404002e /* KEY_C */ > + 0x405002f /* KEY_V */ > + 0x4070032 /* KEY_M */ > + 0x4080033 /* KEY_COMMA */ > + 0x40c0039 /* KEY_SPACE */ > + 0x40d0033 /* KEY_DOT */ > + 0x40e0035 /* KEY_SLASH */ > + 0x40f006b /* KEY_END */ > + 0x501001d /* KEY_LEFTCTRL */ > + 0x5020040 /* KEY_F6 */ > + 0x503000f /* KEY_TAB */ > + 0x504003d /* KEY_F3 */ > + 0x5050014 /* KEY_T */ > + 0x5070015 /* KEY_Y */ > + 0x508001a /* KEY_LEFTBRACE */ > + 0x50d0044 /* KEY_F10 */ > + 0x50e001b /* KEY_RIGHTBRACE */ > + 0x50f0066 /* KEY_HOME */ > + 0x602003f /* KEY_F5 */ > + 0x604003c /* KEY_F2 */ > + 0x6050006 /* KEY_5 */ > + 0x60601d0 /* KEY_FN */ > + 0x6070007 /* KEY_6 */ > + 0x60a008b /* KEY_MENU */ > + 0x60c002b /* KEY_BACKSLASH */ > + 0x60d0043 /* KEY_F9 */ > + 0x7020042 /* KEY_F8 */ > + 0x703003a /* KEY_CAPSLOCK */ > + 0x704003b /* KEY_F1 */ > + 0x7050030 /* KEY_B */ > + 0x7070031 /* KEY_N */ > + 0x70b0038 /* KEY_LEFTALT */ > + 0x70d0058 /* KEY_F12 */ > + 0x70f006f >; /* KEY_DELETE */ > + linux,input-no-autorepeat; > + }; > + }; > +}; > -- > 1.7.1
Hi Sourav, On 10/29/2012 11:40 AM, Sourav Poddar wrote: > Add keypad data node in omap5-evm. > > Based on I2C support patch for omap5, which has been > already posted as a different series. > > Tested on omap5430 evm with 3.7-rc1 kernel. > > Cc: Felipe Balbi <balbi@ti.com> > Cc: Santosh Shilimkar <santosh.shilimkar@ti.com> > > Tested on omap5430 sdp with 3.7-rc1 kernel. > > Signed-off-by: Sourav Poddar <sourav.poddar@ti.com> > --- > arch/arm/boot/dts/omap5-evm.dts | 95 +++++++++++++++++++++++++++++++++++++++ > 1 files changed, 95 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/omap5-evm.dts b/arch/arm/boot/dts/omap5-evm.dts > index c663eba..b812d6d 100644 > --- a/arch/arm/boot/dts/omap5-evm.dts > +++ b/arch/arm/boot/dts/omap5-evm.dts > @@ -140,3 +140,98 @@ > &mcbsp3 { > status = "disabled"; > }; > + > +&i2c5 { > + clock-frequency = <400000>; > + > + smsc@38 { > + compatible = "smscece1099"; > + reg = <0x38>; > + clock = <0x13>; What does that "clock" mean? I cannot find that in the binding documentation. BTW, did you add that documentation in the driver patch? Regards, Benoit -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Benoit, On Monday 29 October 2012 10:14 PM, Benoit Cousson wrote: > Hi Sourav, > > On 10/29/2012 11:40 AM, Sourav Poddar wrote: >> Add keypad data node in omap5-evm. >> >> Based on I2C support patch for omap5, which has been >> already posted as a different series. >> >> Tested on omap5430 evm with 3.7-rc1 kernel. >> >> Cc: Felipe Balbi <balbi@ti.com> >> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com> >> >> Tested on omap5430 sdp with 3.7-rc1 kernel. >> >> Signed-off-by: Sourav Poddar <sourav.poddar@ti.com> >> --- >> arch/arm/boot/dts/omap5-evm.dts | 95 +++++++++++++++++++++++++++++++++++++++ >> 1 files changed, 95 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/boot/dts/omap5-evm.dts b/arch/arm/boot/dts/omap5-evm.dts >> index c663eba..b812d6d 100644 >> --- a/arch/arm/boot/dts/omap5-evm.dts >> +++ b/arch/arm/boot/dts/omap5-evm.dts >> @@ -140,3 +140,98 @@ >> &mcbsp3 { >> status = "disabled"; >> }; >> + >> +&i2c5 { >> + clock-frequency = <400000>; >> + >> + smsc@38 { >> + compatible = "smscece1099"; >> + reg = <0x38>; >> + clock = <0x13>; > What does that "clock" mean? This chip supports a clock control register which is used to enable the interface used by the chip to communicate. Here, the interface which you can are SMBUS interface or BC-LINK interface. > I cannot find that in the binding documentation. BTW, did you add that > documentation in the driver patch? Nope, I missed out on the dt binding documentation for the driver. :( Will send a seperate patch for the bindings. > Regards, > Benoit > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Sourav, On 10/30/2012 6:26 AM, Sourav wrote: > Hi Benoit, > On Monday 29 October 2012 10:14 PM, Benoit Cousson wrote: >> Hi Sourav, >> >> On 10/29/2012 11:40 AM, Sourav Poddar wrote: >>> Add keypad data node in omap5-evm. >>> >>> Based on I2C support patch for omap5, which has been >>> already posted as a different series. >>> >>> Tested on omap5430 evm with 3.7-rc1 kernel. >>> >>> Cc: Felipe Balbi <balbi@ti.com> >>> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com> >>> >>> Tested on omap5430 sdp with 3.7-rc1 kernel. >>> >>> Signed-off-by: Sourav Poddar <sourav.poddar@ti.com> >>> --- >>> arch/arm/boot/dts/omap5-evm.dts | 95 >>> +++++++++++++++++++++++++++++++++++++++ >>> 1 files changed, 95 insertions(+), 0 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/omap5-evm.dts >>> b/arch/arm/boot/dts/omap5-evm.dts >>> index c663eba..b812d6d 100644 >>> --- a/arch/arm/boot/dts/omap5-evm.dts >>> +++ b/arch/arm/boot/dts/omap5-evm.dts >>> @@ -140,3 +140,98 @@ >>> &mcbsp3 { >>> status = "disabled"; >>> }; >>> + >>> +&i2c5 { >>> + clock-frequency = <400000>; >>> + >>> + smsc@38 { >>> + compatible = "smscece1099"; >>> + reg = <0x38>; >>> + clock = <0x13>; >> What does that "clock" mean? > This chip supports a clock control register which is used to enable the > interface used by the chip to communicate. Here, the interface which you > can are > SMBUS interface or BC-LINK interface. OK, so you should use a less generic name than "clock" and potentially prefix it with "smsc," since it is not a generic attribute at all. BTW, cannot we use the CCF in order to control that clock? I guess it is just a clock mux? Well, anyway we need CCF for OMAP to be merged first :-) But it might worth highlighting this is a temporary solution. >> I cannot find that in the binding documentation. BTW, did you add that >> documentation in the driver patch? > Nope, I missed out on the dt binding documentation for the driver. :( > > Will send a seperate patch for the bindings. Thanks, Benoit -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Benoit, On Tuesday 30 October 2012 02:43 PM, Cousson, Benoit wrote: > Hi Sourav, > > On 10/30/2012 6:26 AM, Sourav wrote: >> Hi Benoit, >> On Monday 29 October 2012 10:14 PM, Benoit Cousson wrote: >>> Hi Sourav, >>> >>> On 10/29/2012 11:40 AM, Sourav Poddar wrote: >>>> Add keypad data node in omap5-evm. >>>> >>>> Based on I2C support patch for omap5, which has been >>>> already posted as a different series. >>>> >>>> Tested on omap5430 evm with 3.7-rc1 kernel. >>>> >>>> Cc: Felipe Balbi <balbi@ti.com> >>>> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com> >>>> >>>> Tested on omap5430 sdp with 3.7-rc1 kernel. >>>> >>>> Signed-off-by: Sourav Poddar <sourav.poddar@ti.com> >>>> --- >>>> arch/arm/boot/dts/omap5-evm.dts | 95 >>>> +++++++++++++++++++++++++++++++++++++++ >>>> 1 files changed, 95 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/arch/arm/boot/dts/omap5-evm.dts >>>> b/arch/arm/boot/dts/omap5-evm.dts >>>> index c663eba..b812d6d 100644 >>>> --- a/arch/arm/boot/dts/omap5-evm.dts >>>> +++ b/arch/arm/boot/dts/omap5-evm.dts >>>> @@ -140,3 +140,98 @@ >>>> &mcbsp3 { >>>> status = "disabled"; >>>> }; >>>> + >>>> +&i2c5 { >>>> + clock-frequency = <400000>; >>>> + >>>> + smsc@38 { >>>> + compatible = "smscece1099"; >>>> + reg = <0x38>; >>>> + clock = <0x13>; >>> What does that "clock" mean? >> This chip supports a clock control register which is used to enable the >> interface used by the chip to communicate. Here, the interface which you >> can are >> SMBUS interface or BC-LINK interface. > > OK, so you should use a less generic name than "clock" and potentially > prefix it with "smsc," since it is not a generic attribute at all. > Sure, will think of less generic name. May be "smsc, ctrl-reg" will do. > BTW, cannot we use the CCF in order to control that clock? I don't have much idea about the CCF, so cant really comment on this. > I guess it is just a clock mux? Yes. > Well, anyway we need CCF for OMAP to be merged first :-) > > But it might worth highlighting this is a temporary solution. > >>> I cannot find that in the binding documentation. BTW, did you add that >>> documentation in the driver patch? >> Nope, I missed out on the dt binding documentation for the driver. :( >> >> Will send a seperate patch for the bindings. > > Thanks, > Benoit > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/omap5-evm.dts b/arch/arm/boot/dts/omap5-evm.dts index c663eba..b812d6d 100644 --- a/arch/arm/boot/dts/omap5-evm.dts +++ b/arch/arm/boot/dts/omap5-evm.dts @@ -140,3 +140,98 @@ &mcbsp3 { status = "disabled"; }; + +&i2c5 { + clock-frequency = <400000>; + + smsc@38 { + compatible = "smscece1099"; + reg = <0x38>; + clock = <0x13>; + keypad { + compatible = "smsc,keypad"; + interrupt-parent = <&gpio5>; + interrupts = <23>; /* gpio line 151 */ + keypad,num-rows = <8>; + keypad,num-columns = <16>; + linux,keymap = < 0x20041 /* KEY_F7 */ + 0x30001 /* KEY_ESC */ + 0x4003e /* KEY_F4 */ + 0x50022 /* KEY_G */ + 0x70023 /* KEY_H */ + 0x9009a /* KEY_CYCLEWINDOWS */ + 0xc000e /* KEY_BACKSPACE */ + 0xd0057 /* KEY_F11 */ + 0xe009f /* KEY_FORWARD */ + 0xf006e /* KEY_INSERT */ + 0x1020036 /* KEY_RIGHTSHIFT */ + 0x1030011 /* KEY_W */ + 0x1040010 /* KEY_Q */ + 0x1050012 /* KEY_E */ + 0x1070013 /* KEY_R */ + 0x1080016 /* KEY_U */ + 0x10c0017 /* KEY_I */ + 0x10d0067 /* KEY_UP */ + 0x10e0018 /* KEY_O */ + 0x10f0019 /* KEY_LEFT */ + 0x2020003 /* KEY_2 */ + 0x2040004 /* KEY_1 */ + 0x2050005 /* KEY_3 */ + 0x2070008 /* KEY_4 */ + 0x2080009 /* KEY_7 */ + 0x20b0064 /* KEY_8 */ + 0x20c006c /* KEY_RIGHTALT */ + 0x20d000a /* KEY_DOWN */ + 0x20e0001 /* KEY_0 */ + 0x20f006a /* KEY_RIGHT */ + 0x3010061 /* KEY_RIGHTCTRL */ + 0x302001f /* KEY_S */ + 0x303001e /* KEY_A */ + 0x3040020 /* KEY_D */ + 0x3050021 /* KEY_F */ + 0x3070024 /* KEY_J */ + 0x3080025 /* KEY_K */ + 0x30c001c /* KEY_ENTER */ + 0x30d0026 /* KEY_L */ + 0x30e0027 /* KEY_SEMICOLON */ + 0x400002a /* KEY_LEFTSHIFT */ + 0x402002d /* KEY_X */ + 0x403002c /* KEY_Z */ + 0x404002e /* KEY_C */ + 0x405002f /* KEY_V */ + 0x4070032 /* KEY_M */ + 0x4080033 /* KEY_COMMA */ + 0x40c0039 /* KEY_SPACE */ + 0x40d0033 /* KEY_DOT */ + 0x40e0035 /* KEY_SLASH */ + 0x40f006b /* KEY_END */ + 0x501001d /* KEY_LEFTCTRL */ + 0x5020040 /* KEY_F6 */ + 0x503000f /* KEY_TAB */ + 0x504003d /* KEY_F3 */ + 0x5050014 /* KEY_T */ + 0x5070015 /* KEY_Y */ + 0x508001a /* KEY_LEFTBRACE */ + 0x50d0044 /* KEY_F10 */ + 0x50e001b /* KEY_RIGHTBRACE */ + 0x50f0066 /* KEY_HOME */ + 0x602003f /* KEY_F5 */ + 0x604003c /* KEY_F2 */ + 0x6050006 /* KEY_5 */ + 0x60601d0 /* KEY_FN */ + 0x6070007 /* KEY_6 */ + 0x60a008b /* KEY_MENU */ + 0x60c002b /* KEY_BACKSLASH */ + 0x60d0043 /* KEY_F9 */ + 0x7020042 /* KEY_F8 */ + 0x703003a /* KEY_CAPSLOCK */ + 0x704003b /* KEY_F1 */ + 0x7050030 /* KEY_B */ + 0x7070031 /* KEY_N */ + 0x70b0038 /* KEY_LEFTALT */ + 0x70d0058 /* KEY_F12 */ + 0x70f006f >; /* KEY_DELETE */ + linux,input-no-autorepeat; + }; + }; +};
Add keypad data node in omap5-evm. Based on I2C support patch for omap5, which has been already posted as a different series. Tested on omap5430 evm with 3.7-rc1 kernel. Cc: Felipe Balbi <balbi@ti.com> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com> Tested on omap5430 sdp with 3.7-rc1 kernel. Signed-off-by: Sourav Poddar <sourav.poddar@ti.com> --- arch/arm/boot/dts/omap5-evm.dts | 95 +++++++++++++++++++++++++++++++++++++++ 1 files changed, 95 insertions(+), 0 deletions(-)