| Message ID | 1351974625-10282-7-git-send-email-Julia.Lawall@lip6.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
* Julia Lawall <Julia.Lawall@lip6.fr> [121103 13:32]: > From: Julia Lawall <Julia.Lawall@lip6.fr> > > Just use WARN_ON rather than an if containing only WARN_ON(1). Thanks applying this one into omap-for-v3.8/fixes-for-merge-window. Regards, Tony > A simplified version of the semantic patch that makes this transformation > is as follows: (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression e; > @@ > - if (e) WARN_ON(1); > + WARN_ON(e); > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > --- > arch/arm/mach-omap2/dpll3xxx.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm/mach-omap2/dpll3xxx.c b/arch/arm/mach-omap2/dpll3xxx.c > index eacf51f..ed855b0 100644 > --- a/arch/arm/mach-omap2/dpll3xxx.c > +++ b/arch/arm/mach-omap2/dpll3xxx.c > @@ -478,8 +478,7 @@ int omap3_noncore_dpll_set_rate(struct clk *clk, unsigned long rate) > if (!soc_is_am33xx() && !cpu_is_omap44xx() && !cpu_is_omap3630()) { > freqsel = _omap3_dpll_compute_freqsel(clk, > dd->last_rounded_n); > - if (!freqsel) > - WARN_ON(1); > + WARN_ON(!freqsel); > } > > pr_debug("clock: %s: set rate: locking rate to %lu.\n", > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-omap2/dpll3xxx.c b/arch/arm/mach-omap2/dpll3xxx.c index eacf51f..ed855b0 100644 --- a/arch/arm/mach-omap2/dpll3xxx.c +++ b/arch/arm/mach-omap2/dpll3xxx.c @@ -478,8 +478,7 @@ int omap3_noncore_dpll_set_rate(struct clk *clk, unsigned long rate) if (!soc_is_am33xx() && !cpu_is_omap44xx() && !cpu_is_omap3630()) { freqsel = _omap3_dpll_compute_freqsel(clk, dd->last_rounded_n); - if (!freqsel) - WARN_ON(1); + WARN_ON(!freqsel); } pr_debug("clock: %s: set rate: locking rate to %lu.\n",