From patchwork Tue Nov 20 01:05:48 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Omar Ramirez Luna X-Patchwork-Id: 1770051 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id C9D95DF264 for ; Tue, 20 Nov 2012 01:07:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753944Ab2KTBGK (ORCPT ); Mon, 19 Nov 2012 20:06:10 -0500 Received: from mail-oa0-f46.google.com ([209.85.219.46]:64879 "EHLO mail-oa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753564Ab2KTBGI (ORCPT ); Mon, 19 Nov 2012 20:06:08 -0500 Received: by mail-oa0-f46.google.com with SMTP id h16so5451881oag.19 for ; Mon, 19 Nov 2012 17:06:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=9Rt/QgefyuycjZmMweiSNV7mH8L/yEzVNFPEtfFG8pM=; b=j0bM8sxfnr0BngmnA5LLVnHCNZ4kOM0n9oG+YIrX8t24w8j3qAuSVztpop/qBycaPs cTCOla7o+yCyHokM3y8gG8jw2I4LHHdW4RwxjJHZwlCq4dyC0p0d/xC4ijl+2evugJ4i HoER64QuafDUbTIqf/ZzKEsxcpeM0pCOYXypTuwkCyZiLw362jCbllum/rzMoI36yMtt XgX3PHLA75tzft1khB7VqimgjKoYtzNITy4U6lqBkW1sljSOx9+EXhMmdrfdJ4mb8tPM V/+9LQy3B/eUkJG9e6dWJNUtdgKuvz1rtPgixMd2KCyOZKu4y3dqeAsQGSL9IXEznwfg Y4Mg== Received: by 10.60.14.200 with SMTP id r8mr12297321oec.45.1353373567813; Mon, 19 Nov 2012 17:06:07 -0800 (PST) Received: from localhost.localdomain (dragon.ti.com. [192.94.94.33]) by mx.google.com with ESMTPS id vt9sm11578237obb.3.2012.11.19.17.06.06 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 19 Nov 2012 17:06:06 -0800 (PST) From: Omar Ramirez Luna To: Tony Lindgren , Joerg Roedel Cc: Russell King , Ohad Ben-Cohen , Omar Ramirez Luna , Ido Yariv , Mauro Carvalho Chehab , Paul Walmsley , Felipe Contreras , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org Subject: [PATCH v5 1/5] iommu/omap: remove redundant clock handling on ISR Date: Mon, 19 Nov 2012 19:05:48 -0600 Message-Id: <1353373552-16039-2-git-send-email-omar.luna@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1353373552-16039-1-git-send-email-omar.luna@linaro.org> References: <1353373552-16039-1-git-send-email-omar.luna@linaro.org> X-Gm-Message-State: ALoCoQmo/94+OePiAwkSYV1uYXTLRtleGnOL7qBpBq+CQ/Qn+VF/dqUzihgUXZ3+qKwDEgdkqYAT Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org For the interrupt to be generated, the mmu clock should be already enabled while translating a virtual address, so, this call to clock handling is just increasing/decreasing the counter. This works now, because its users need the same clock and they indirectly power the mmu, in this interrupt context the handling of clocks inside the ISR doesn't seem to be needed nor helping. Next patch should also correct the dependency on clients to handle iommu clocks. Signed-off-by: Omar Ramirez Luna --- drivers/iommu/omap-iommu.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c index badc17c..6b1288c 100644 --- a/drivers/iommu/omap-iommu.c +++ b/drivers/iommu/omap-iommu.c @@ -807,9 +807,7 @@ static irqreturn_t iommu_fault_handler(int irq, void *data) if (!obj->refcount) return IRQ_NONE; - clk_enable(obj->clk); errs = iommu_report_fault(obj, &da); - clk_disable(obj->clk); if (errs == 0) return IRQ_HANDLED;