From patchwork Mon Dec 31 13:07:01 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vaibhav Bedia X-Patchwork-Id: 1921371 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 2522F3FC85 for ; Mon, 31 Dec 2012 13:08:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751261Ab2LaNIV (ORCPT ); Mon, 31 Dec 2012 08:08:21 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:51544 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751171Ab2LaNIV (ORCPT ); Mon, 31 Dec 2012 08:08:21 -0500 Received: from dlelxv30.itg.ti.com ([172.17.2.17]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id qBVD8G6w019910; Mon, 31 Dec 2012 07:08:16 -0600 Received: from DQHE72.ent.ti.com (dqhe72.ent.ti.com [172.16.34.79]) by dlelxv30.itg.ti.com (8.13.8/8.13.8) with ESMTP id qBVD8F8u032209; Mon, 31 Dec 2012 07:08:16 -0600 Received: from dbdp32.itg.ti.com (172.24.170.251) by DQHE72.ent.ti.com (172.16.34.79) with Microsoft SMTP Server id 14.1.323.3; Mon, 31 Dec 2012 21:08:14 +0800 Received: from localhost.localdomain (dbdp20.itg.ti.com [172.24.170.38]) by dbdp32.itg.ti.com (8.13.8/8.13.8) with ESMTP id qBVD7dBa030716; Mon, 31 Dec 2012 18:38:14 +0530 From: Vaibhav Bedia To: , , , CC: Vaibhav Bedia , Santosh Shilimkar , Benoit Cousson , Paul Walmsley , Vaibhav Hiremath Subject: [RFC v2 08/18] ARM: OMAP2+: AM33XX: hwmod: Fixup cpgmac0 hwmod entry Date: Mon, 31 Dec 2012 18:37:01 +0530 Message-ID: <1356959231-17335-9-git-send-email-vaibhav.bedia@ti.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <1356959231-17335-1-git-send-email-vaibhav.bedia@ti.com> References: <1356959231-17335-1-git-send-email-vaibhav.bedia@ti.com> MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org The current HWMOD code expects the memory region with the IP's SYSCONFIG register to be marked with ADDR_TYPE_RT flag. CPGMAC0 hwmod entry specifies two memory regions and marks both with the flag ADDR_TYPE_RT although only the 2nd region has the SYSCONFIG register. This leads to the HWMOD code accessing the wrong memory address for idle and standby operations. Fix this by removing the ADDR_TYPE_RT flag from the 1st memory region in CPGMAC0 hwmod entry. Signed-off-by: Vaibhav Bedia Cc: Santosh Shilimkar Cc: Benoit Cousson Cc: Paul Walmsley Cc: Kevin Hilman Cc: Vaibhav Hiremath --- v1->v2: Address review comments from Santosh and Vaibhav Hiremath. Previous discussion on the change is @ http://lists.infradead.org/pipermail/linux-arm-kernel/2012-November/129512.html arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c index 5c34d4b..863ce08 100644 --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c @@ -2496,7 +2496,6 @@ static struct omap_hwmod_addr_space am33xx_cpgmac0_addr_space[] = { { .pa_start = 0x4a100000, .pa_end = 0x4a100000 + SZ_2K - 1, - .flags = ADDR_TYPE_RT, }, /* cpsw wr */ {