From patchwork Fri Jan 4 13:02:05 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastien Guiriec X-Patchwork-Id: 1932851 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 3CF60DFABD for ; Fri, 4 Jan 2013 13:02:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754671Ab3ADNCS (ORCPT ); Fri, 4 Jan 2013 08:02:18 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:40807 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751513Ab3ADNCQ (ORCPT ); Fri, 4 Jan 2013 08:02:16 -0500 Received: from dlelxv30.itg.ti.com ([172.17.2.17]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id r04D2DQF016714; Fri, 4 Jan 2013 07:02:13 -0600 Received: from DLEE74.ent.ti.com (dlee74.ent.ti.com [157.170.170.8]) by dlelxv30.itg.ti.com (8.13.8/8.13.8) with ESMTP id r04D2DPt029031; Fri, 4 Jan 2013 07:02:13 -0600 Received: from dlelxv22.itg.ti.com (172.17.1.197) by DLEE74.ent.ti.com (157.170.170.8) with Microsoft SMTP Server id 14.1.323.3; Fri, 4 Jan 2013 07:02:13 -0600 Received: from unb0919150.emea.dhcp.ti.com (unb0919150.emea.dhcp.ti.com [137.167.110.144]) by dlelxv22.itg.ti.com (8.13.8/8.13.8) with ESMTP id r04D27PG015497; Fri, 4 Jan 2013 07:02:12 -0600 From: Sebastien Guiriec To: Sebastien Guiriec , =?UTF-8?q?Beno=C3=AEt=20Cousson?= , Paul Walmsley , Tony Lindgren , CC: , Peter Ujfalusi , Liam Girdwood , Tero Kristo , Jon Hunter Subject: [PATCH 2/3] ARM: OMAP4: hwmod data: do not enable or reset the AESS during kernel init Date: Fri, 4 Jan 2013 14:02:05 +0100 Message-ID: <1357304526-21557-3-git-send-email-s-guiriec@ti.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1357304526-21557-1-git-send-email-s-guiriec@ti.com> References: <1357304526-21557-1-git-send-email-s-guiriec@ti.com> MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org The AESS on OMAP4 has additional register on top of SYS_CONFIG for auto gatting configuration. In order to avoid running clock after boot up we should avoid to enable and reset the module during boot up. Audio driver will be in charge of configuring the addition register. At its core, this patch is a workaround for an OMAP hardware problem. It should be possible to configure the OMAP with good default reset configuration of AESS IP for auto gatting mode. Signed-off-by: Sebastien Guiriec --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c index b340a4e..26d6cde 100644 --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c @@ -346,6 +346,14 @@ static struct omap_hwmod omap44xx_aess_hwmod = { .name = "aess", .class = &omap44xx_aess_hwmod_class, .clkdm_name = "abe_clkdm", + /* + * AESS has an internal register on top of SYS_CONFIG for + * AUTO GATTING mode. Unfortunately the reset value of this + * register is not set correctly. So until AESS driver is not + * probe we should not try to control the module during boot up. + * Audio driver will handle the additional register configuration. + */ + .flags = HWMOD_NO_SETUP_RESET, .mpu_irqs = omap44xx_aess_irqs, .sdma_reqs = omap44xx_aess_sdma_reqs, .main_clk = "aess_fck",