From patchwork Sun Feb 3 00:15:10 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ruslan Bilovol X-Patchwork-Id: 2084961 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 5A40D3FCA4 for ; Sun, 3 Feb 2013 00:15:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752009Ab3BCAPX (ORCPT ); Sat, 2 Feb 2013 19:15:23 -0500 Received: from mail-lb0-f179.google.com ([209.85.217.179]:40513 "EHLO mail-lb0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751664Ab3BCAPW (ORCPT ); Sat, 2 Feb 2013 19:15:22 -0500 Received: by mail-lb0-f179.google.com with SMTP id j14so5548803lbo.24 for ; Sat, 02 Feb 2013 16:15:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:subject:date:message-id:x-mailer; bh=cNvDxc1w0FfK8zfl+LeLimWKroxsQv2S+qNVj+3zgCg=; b=ozRP6tmgPRltZlCS/K0pDG+Xp68CKyRtRVCuaKbNzoLPTG+XWbUCLrpzluLGrvEgG5 t6Z2+/azzIP3jRZyNVwhJ53QIh1c2ppweTkGXhp5xkPbpEPHgAjR71ww1Vo8iHFQBo7U MVEh4tTIY+elj+o1Ny8XKifwTML7QuFaPEAsvPU02RXH2jIb207DT576BXbQEaKHjb11 n4ZrC34ZZKkivvdnVwJv24rlGlG2Ocqv7Z0eiP0vzwpQzL09kzZrBVcyd4T8+qadBdbt IxC8tOEQu7Sk5voluLCfRnM8MhOKO680TpLbPPkmS3P5CMY75L9iqGJdKxuC4I3zxFbl S44Q== X-Received: by 10.112.98.71 with SMTP id eg7mr6415764lbb.133.1359850521248; Sat, 02 Feb 2013 16:15:21 -0800 (PST) Received: from localhost (diamondly-something.volia.net. [93.74.62.0]) by mx.google.com with ESMTPS id t7sm3940947lbf.12.2013.02.02.16.15.16 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 02 Feb 2013 16:15:20 -0800 (PST) From: Ruslan Bilovol To: tony@atomide.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] ARM: OMAP2+: mux: correct wrong error messages Date: Sun, 3 Feb 2013 02:15:10 +0200 Message-Id: <1359850510-32298-1-git-send-email-ruslan.bilovol@ti.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org This is needed because the omap_mux_get_by_name() function calls the _omap_mux_get_by_name subfunction for each mux partition until needed mux is not found. As a result, we get messages like "Could not find signal XXX" for each partition where this mux name does not exist. This patch fixes wrong error message in the _omap_mux_get_by_name() function moving it to the omap_mux_get_by_name() one and as result reduces noise in the kernel log. My kernel log without this patch: [...] [ 0.221801] omap_mux_init: Add partition: #2: wkup, flags: 3 [ 0.222045] _omap_mux_get_by_name: Could not find signal fref_clk0_out.sys_drm_msecure [ 0.222137] _omap_mux_get_by_name: Could not find signal sys_nirq [ 0.222167] _omap_mux_get_by_name: Could not find signal sys_nirq [ 0.225006] _omap_mux_get_by_name: Could not find signal uart1_rx.uart1_rx [ 0.225006] _omap_mux_get_by_name: Could not find signal uart1_rx.uart1_rx [ 0.270111] _omap_mux_get_by_name: Could not find signal fref_clk4_out.fref_clk4_out [ 0.273406] twl: not initialized [...] My kernel log with this patch: [...] [ 0.221771] omap_mux_init: Add partition: #2: wkup, flags: 3 [ 0.222106] omap_mux_get_by_name: Could not find signal sys_nirq [ 0.224945] omap_mux_get_by_name: Could not find signal uart1_rx.uart1_rx [ 0.274536] twl: not initialized [...] Signed-off-by: Ruslan Bilovol --- arch/arm/mach-omap2/mux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2/mux.c index 6a217c9..9578ec0 100644 --- a/arch/arm/mach-omap2/mux.c +++ b/arch/arm/mach-omap2/mux.c @@ -211,8 +211,6 @@ static int __init _omap_mux_get_by_name(struct omap_mux_partition *partition, return -EINVAL; } - pr_err("%s: Could not find signal %s\n", __func__, muxname); - return -ENODEV; } @@ -234,6 +232,8 @@ int __init omap_mux_get_by_name(const char *muxname, return mux_mode; } + pr_err("%s: Could not find signal %s\n", __func__, muxname); + return -ENODEV; }