| Message ID | 1362055461-27154-1-git-send-email-schnitzeltony@googlemail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
* Andreas Müller <schnitzeltony@googlemail.com> [130228 04:50]: Can you please add a description here? Preferrably something like "With commit XYZ overo poweroff stopped working. Fix this by blah blah blah" so this can be queued as a fix. Regards, Tony > Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com> > --- > arch/arm/mach-omap2/board-overo.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/board-overo.c b/arch/arm/mach-omap2/board-overo.c > index 86bab51..b975c72 100644 > --- a/arch/arm/mach-omap2/board-overo.c > +++ b/arch/arm/mach-omap2/board-overo.c > @@ -418,9 +418,14 @@ static struct regulator_init_data overo_vmmc1 = { > .consumer_supplies = overo_vmmc1_supply, > }; > > +static struct twl4030_power_data overo_power_data = { > + .use_poweroff = true, > +}; > + > static struct twl4030_platform_data overo_twldata = { > .gpio = &overo_gpio_data, > .vmmc1 = &overo_vmmc1, > + .power = &overo_power_data, > }; > > static int __init overo_i2c_init(void) > -- > 1.7.6.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Mar 4, 2013 at 8:00 PM, Tony Lindgren <tony@atomide.com> wrote: > * Andreas Müller <schnitzeltony@googlemail.com> [130228 04:50]: > > Can you please add a description here? Preferrably something > like "With commit XYZ overo poweroff stopped working. Fix this > by blah blah blah" so this can be queued as a fix. > > Regards, > > Tony > >> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com> >> --- >> arch/arm/mach-omap2/board-overo.c | 5 +++++ >> 1 files changed, 5 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/board-overo.c b/arch/arm/mach-omap2/board-overo.c >> index 86bab51..b975c72 100644 >> --- a/arch/arm/mach-omap2/board-overo.c >> +++ b/arch/arm/mach-omap2/board-overo.c >> @@ -418,9 +418,14 @@ static struct regulator_init_data overo_vmmc1 = { >> .consumer_supplies = overo_vmmc1_supply, >> }; >> >> +static struct twl4030_power_data overo_power_data = { >> + .use_poweroff = true, >> +}; >> + >> static struct twl4030_platform_data overo_twldata = { >> .gpio = &overo_gpio_data, >> .vmmc1 = &overo_vmmc1, >> + .power = &overo_power_data, >> }; >> >> static int __init overo_i2c_init(void) >> -- AFAIK this has never been implemented mainline. Up to now I used a patch from Steve Sakoman implementing the commands for TWL to shut down - but this was never sent here and is no more required with TWL framework. I will send V2 with more descriptive commit message till end of week. Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Mar 4, 2013 at 8:00 PM, Tony Lindgren <tony@atomide.com> wrote: > * Andreas Müller <schnitzeltony@googlemail.com> [130228 04:50]: > > Can you please add a description here? Preferrably something > like "With commit XYZ overo poweroff stopped working. Fix this > by blah blah blah" so this can be queued as a fix. > > Regards, > > Tony > >> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com> >> --- >> arch/arm/mach-omap2/board-overo.c | 5 +++++ >> 1 files changed, 5 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/board-overo.c b/arch/arm/mach-omap2/board-overo.c >> index 86bab51..b975c72 100644 >> --- a/arch/arm/mach-omap2/board-overo.c >> +++ b/arch/arm/mach-omap2/board-overo.c >> @@ -418,9 +418,14 @@ static struct regulator_init_data overo_vmmc1 = { >> .consumer_supplies = overo_vmmc1_supply, >> }; >> >> +static struct twl4030_power_data overo_power_data = { >> + .use_poweroff = true, >> +}; >> + >> static struct twl4030_platform_data overo_twldata = { >> .gpio = &overo_gpio_data, >> .vmmc1 = &overo_vmmc1, >> + .power = &overo_power_data, >> }; >> >> static int __init overo_i2c_init(void) >> -- Sorry for the noise but I am newbie here and have one question: Against which branch should patches send here be based on. Up to now I used Linus' mainline branch - is that OK? Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* Andreas Müller <schnitzeltony@googlemail.com> [130305 00:19]: > > Sorry for the noise but I am newbie here and have one question: > Against which branch should patches send here be based on. Up to now I > used Linus' mainline branch - is that OK? Yes that's perfect. It's usually best to use the most recent stable tag or development tag in Linus' tree. So that would be v3.9-rc1 currently for patches heading to v3.10 merge window. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Andreas, On 03/05/2013 09:15 AM, Andreas Müller wrote: > On Mon, Mar 4, 2013 at 8:00 PM, Tony Lindgren <tony@atomide.com> wrote: >> * Andreas Müller <schnitzeltony@googlemail.com> [130228 04:50]: >> >> Can you please add a description here? Preferrably something >> like "With commit XYZ overo poweroff stopped working. Fix this >> by blah blah blah" so this can be queued as a fix. >> >> Regards, >> >> Tony >> >>> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com> >>> --- >>> arch/arm/mach-omap2/board-overo.c | 5 +++++ >>> 1 files changed, 5 insertions(+), 0 deletions(-) >>> >>> diff --git a/arch/arm/mach-omap2/board-overo.c b/arch/arm/mach-omap2/board-overo.c >>> index 86bab51..b975c72 100644 >>> --- a/arch/arm/mach-omap2/board-overo.c >>> +++ b/arch/arm/mach-omap2/board-overo.c >>> @@ -418,9 +418,14 @@ static struct regulator_init_data overo_vmmc1 = { >>> .consumer_supplies = overo_vmmc1_supply, >>> }; >>> >>> +static struct twl4030_power_data overo_power_data = { >>> + .use_poweroff = true, >>> +}; >>> + >>> static struct twl4030_platform_data overo_twldata = { >>> .gpio = &overo_gpio_data, >>> .vmmc1 = &overo_vmmc1, >>> + .power = &overo_power_data, >>> }; >>> >>> static int __init overo_i2c_init(void) >>> -- > Sorry for the noise but I am newbie here and have one question: > Against which branch should patches send here be based on. Up to now I > used Linus' mainline branch - is that OK? > Any plans to repost your patch? Regards, Florian -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-omap2/board-overo.c b/arch/arm/mach-omap2/board-overo.c index 86bab51..b975c72 100644 --- a/arch/arm/mach-omap2/board-overo.c +++ b/arch/arm/mach-omap2/board-overo.c @@ -418,9 +418,14 @@ static struct regulator_init_data overo_vmmc1 = { .consumer_supplies = overo_vmmc1_supply, }; +static struct twl4030_power_data overo_power_data = { + .use_poweroff = true, +}; + static struct twl4030_platform_data overo_twldata = { .gpio = &overo_gpio_data, .vmmc1 = &overo_vmmc1, + .power = &overo_power_data, }; static int __init overo_i2c_init(void)
Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com> --- arch/arm/mach-omap2/board-overo.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)