From patchwork Sun Mar 10 00:49:28 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Grazvydas Ignotas X-Patchwork-Id: 2242741 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 224AA3FCF6 for ; Sun, 10 Mar 2013 00:49:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751728Ab3CJAtf (ORCPT ); Sat, 9 Mar 2013 19:49:35 -0500 Received: from mail-ee0-f52.google.com ([74.125.83.52]:48325 "EHLO mail-ee0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751580Ab3CJAte (ORCPT ); Sat, 9 Mar 2013 19:49:34 -0500 Received: by mail-ee0-f52.google.com with SMTP id b15so1605757eek.39 for ; Sat, 09 Mar 2013 16:49:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer; bh=yjGidqpFLkAGaEF+O7UxusM6gCAkyukP+/FUq3bWZrE=; b=jnHRaXIF8FZbg75QIvl2O60x0nHVIMu6p+/suuys/0o7XoOAp+/9tq+uJsM+oKcQ0F oJL1TOJZClEOGiZEvYwFqE+LRjSCu4saXhNy68MZEAbRq0yhDzjbkAdtbco+LX2tn6X/ OuA47iXvU0qJ4grEvrP5aaCg5qHsxkNh/v9l7V1SQUydN8b1UawIub8oV745DVv007Fk UMH25tJlcxH6+GSwf9/KpiHKyQ77JeBpzDY9WDxuIWFqtgr7qSB87lvSQn+f9bq02Hb8 zF8ZqyeJwbUAW5hNFd5JrUwh13+y0vOta6X4EwnCR5VRrEiviq7s9W4Qx1CGNNlrHbB9 t5ag== X-Received: by 10.14.206.132 with SMTP id l4mr20648083eeo.38.1362876573020; Sat, 09 Mar 2013 16:49:33 -0800 (PST) Received: from localhost.localdomain (ip-88-119-226-136.static.b4net.lt. [88.119.226.136]) by mx.google.com with ESMTPS id m46sm15658445eeo.16.2013.03.09.16.49.31 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 09 Mar 2013 16:49:32 -0800 (PST) From: Grazvydas Ignotas To: linux-usb@vger.kernel.org Cc: linux-omap@vger.kernel.org, Felipe Balbi , Grazvydas Ignotas Subject: [PATCH] usb: musb: log VBUS error Date: Sun, 10 Mar 2013 02:49:28 +0200 Message-Id: <1362876568-7082-1-git-send-email-notasas@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org VBUS_ERROR is a serious error that the driver often doesn't recover from in my tests, so we should at least inform the user about it. Signed-off-by: Grazvydas Ignotas --- drivers/usb/musb/musb_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c index f95404e..df6a54e 100644 --- a/drivers/usb/musb/musb_core.c +++ b/drivers/usb/musb/musb_core.c @@ -602,7 +602,8 @@ static irqreturn_t musb_stage0_irq(struct musb *musb, u8 int_usb, break; } - dev_dbg(musb->controller, "VBUS_ERROR in %s (%02x, %s), retry #%d, port1 %08x\n", + dev_printk(ignore ? KERN_DEBUG : KERN_ERR, musb->controller, + "VBUS_ERROR in %s (%02x, %s), retry #%d, port1 %08x\n", otg_state_string(musb->xceiv->state), devctl, ({ char *s;