From patchwork Thu Apr 18 08:37:05 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Christoph Fritz X-Patchwork-Id: 2457851 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 132EB40148 for ; Thu, 18 Apr 2013 08:37:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753996Ab3DRIhN (ORCPT ); Thu, 18 Apr 2013 04:37:13 -0400 Received: from mail-bk0-f51.google.com ([209.85.214.51]:48891 "EHLO mail-bk0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966354Ab3DRIhK (ORCPT ); Thu, 18 Apr 2013 04:37:10 -0400 Received: by mail-bk0-f51.google.com with SMTP id y8so1149128bkt.10 for ; Thu, 18 Apr 2013 01:37:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=x-received:subject:from:to:cc:in-reply-to:references:content-type :date:message-id:mime-version:x-mailer:content-transfer-encoding; bh=Y5MXpfhFUcQYsRYWZ9fJO0SRzgk8EnDab5OMN9pd1bQ=; b=eENeSEZmoLXrAzJ9MtiUAh4A3u7jrw49PGKcixJaCt7bLGW0N1dcO+iR8pMglcxb9Q SHSQNI7/1W7cctq4KrwoYwVMo8bM9gNe9O9NJJ2J3OoHaf5Dkp4rhunS43BduB9QJQWb STe80GzV12b1RlqxrCwa2atLkicWr/vjabUHVvRQ0OvUblBn9O015oFIESGER0N0Y4DW jkoVxH+uCInkhSBpI7KfpvmK1PBsi9R4fybdrVMvsuBLSZ5BHZwz8toMxeFVUIH/0whL mwVKslys76OMLXEwyw3/NUmMtpXEpR8fCGR2i1OYXrFUs+FcIjR0VeXi5Gp5iCs/w8Uk ttXg== X-Received: by 10.204.229.140 with SMTP id ji12mr3508198bkb.113.1366274228955; Thu, 18 Apr 2013 01:37:08 -0700 (PDT) Received: from [192.168.1.12] (p508F615B.dip.t-dialin.net. [80.143.97.91]) by mx.google.com with ESMTPS id x18sm2842856bkw.4.2013.04.18.01.37.06 (version=SSLv3 cipher=RC4-SHA bits=128/128); Thu, 18 Apr 2013 01:37:07 -0700 (PDT) Subject: [PATCH] OMAPDSS: DPI: add dependency to DSI From: Christoph Fritz To: Tomi Valkeinen Cc: Dave Airlie , linux-omap , "dri-devel@lists.freedesktop.org" In-Reply-To: <516BDD35.4000807@ti.com> References: <516BDD35.4000807@ti.com> Date: Thu, 18 Apr 2013 10:37:05 +0200 Message-ID: <1366274225.4085.44.camel@mars> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi Tomi On Mon, 2013-04-15 at 13:57 +0300, Tomi Valkeinen wrote: > Tomi Valkeinen (38): > OMAPDSS: add fields to panels' platform data > OMAPDSS: DSI: remove DSI & DISPC clk divisors from dssdev > OMAPDSS: HDMI: remove HDMI clk divisors from dssdev > OMAPDSS: DPI: remove omap_dss_device uses > OMAPDSS: DSI: remove omap_dss_device uses > OMAPDSS: Taal: remove multi-panel support > OMAPDSS: APPLY: remove dssdev from dss_mgr_wait_for_vsync > OMAPDSS: add missing export for omap_dss_get_output() > OMAPDSS: HDMI: init output earlier > OMAPDSS: add output->name > OMAPDSS: add output->dispc_channel > OMAPDSS: DSI: delay dispc initialization > OMAPDSS: DSI: fix DSI channel source initialization > OMAPDSS: Taal: remove rotate & mirror support > OMAPDSS: DPI: fix dpi_get_dsidev() for omap5 > OMAPDSS: DISPC: store core clk rate > OMAPDSS: DSI: fix wrong unsigned long long use > OMAPDSS: DSI: simplify dsi configuration > OMAPDSS: DSI: get line buffer size at probe > OMAPDSS: DSI: add enum omap_dss_dsi_trans_mode > OMAPDSS: DSI remove unneeded clk source setup code > OMAPDSS: DISPC: add new clock calculation code > OMAPDSS: DSS: add new clock calculation code > OMAPDSS: DSI: add new clock calculation code > OMAPDSS: SDI: use new clock calculation code > OMAPDSS: DPI: use new clock calculation code With linux-next this patch breaks compiling here because DPI now depends on DSI - but my omap3 board here doesn't use DSI at all: drivers/video/omap2/dss/dpi.c: In function ‘dpi_calc_pll_cb’: drivers/video/omap2/dss/dpi.c:181: error: implicit declaration of function ‘dsi_hsdiv_calc’ drivers/video/omap2/dss/dpi.c: In function ‘dpi_dsi_clk_calc’: drivers/video/omap2/dss/dpi.c:201: error: implicit declaration of function ‘dsi_get_pll_clkin’ drivers/video/omap2/dss/dpi.c:212: error: implicit declaration of function ‘dsi_pll_calc’ Enabling OMAP2_DSS_DSI fixes this. This is my proposed patch. You may be want to merge it? From: Christoph Fritz Date: Thu, 18 Apr 2013 10:26:54 +0200 Subject: [PATCH] OMAPDSS: DPI: add dependency to DSI A dependency from DPI to DSI is introduced by commit 100c82623 "OMAPDSS: DPI: use new clock calculation code". This patch adds the dependency also on Kconfig-Level. Signed-off-by: Christoph Fritz --- drivers/video/omap2/dss/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/omap2/dss/Kconfig b/drivers/video/omap2/dss/Kconfig index cb0f145..b4211c5 100644 --- a/drivers/video/omap2/dss/Kconfig +++ b/drivers/video/omap2/dss/Kconfig @@ -36,6 +36,7 @@ config OMAP2_DSS_COLLECT_IRQ_STATS config OMAP2_DSS_DPI bool "DPI support" default y + select OMAP2_DSS_DSI help DPI Interface. This is the Parallel Display Interface.