From patchwork Fri Apr 19 16:29:41 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Fritz X-Patchwork-Id: 2466021 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 9670A3FE81 for ; Fri, 19 Apr 2013 16:29:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968358Ab3DSQ3s (ORCPT ); Fri, 19 Apr 2013 12:29:48 -0400 Received: from mail-bk0-f52.google.com ([209.85.214.52]:32846 "EHLO mail-bk0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030877Ab3DSQ3q (ORCPT ); Fri, 19 Apr 2013 12:29:46 -0400 Received: by mail-bk0-f52.google.com with SMTP id it16so1803967bkc.11 for ; Fri, 19 Apr 2013 09:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=x-received:subject:from:to:cc:in-reply-to:references:content-type :date:message-id:mime-version:x-mailer:content-transfer-encoding; bh=te4BNVjovBWMjdSdOOk3Ww1r1L9KxB11w3yaLuqwC+8=; b=kalHhPgbsZNBV3AK3fVjRywVLZsgrvGoAmmFfEs2dgHtFdV7EnchJW0OVVMD+pGcXw rB1H9T1SOR2j3E8Uh9jwluOEGbbCBBiyRMoyeMh/mVoJg3GWzbUh2gU0Yy9Q0o42TzBp eUgWfXtLY6lZdV0yf3dvwnCBGdicxaHBinP+4IyVUtrEquYbAiMmLzVyZDA5kHOMAYGj 6b3yVa1TD4EkWOlzH+1LFysESmvCU9qYlwQYhCcvL6KNXSzvEJXRrPNXGKhGzdtwE5gi R/pZBIZA5luhryps4gbfTlkQFlOzJHNQ/jeVJhdFEZrdNgIi/oDuPzsztYLVoNT9qqhv YgiA== X-Received: by 10.204.185.129 with SMTP id co1mr2820433bkb.114.1366388985306; Fri, 19 Apr 2013 09:29:45 -0700 (PDT) Received: from [192.168.1.12] (p549E9EDB.dip0.t-ipconnect.de. [84.158.158.219]) by mx.google.com with ESMTPS id f14sm1392798bky.16.2013.04.19.09.29.43 (version=SSLv3 cipher=RC4-SHA bits=128/128); Fri, 19 Apr 2013 09:29:44 -0700 (PDT) Subject: [PATCH] ARM: OMAP2+: nand: reorganize gpmc timing values From: Christoph Fritz To: Jon Hunter , Tony Lindgren Cc: Javier Martinez Canillas , Daniel Mack , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org In-Reply-To: <5171647B.9070108@ti.com> References: <1366311829.4085.90.camel@mars> <51704C05.4030200@ti.com> <1366316595.4085.113.camel@mars> <5170738F.8050305@ti.com> <1366325282.4232.6.camel@lovely> <51708097.6070102@ti.com> <51708131.2040208@ti.com> <1366362081.3928.18.camel@mars> <1366372957.3928.104.camel@mars> <51714E0D.7020304@ti.com> <1366383208.3928.144.camel@mars> <5171647B.9070108@ti.com> Date: Fri, 19 Apr 2013 18:29:41 +0200 Message-ID: <1366388981.3928.158.camel@mars> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org This patch removes omap2_nand_gpmc_retime() which was used to quirk some timing values before gpmc_cs_set_timings(). Due to recent changes, gpmc_cs_set_timings() has evolved so that there is no more need for a retime function. To keep the gpmc configuration consistent for legacy board files, this patch also adds oe_on and we_on to nand_default_timings[] as they would be by the retime function. Signed-off-by: Christoph Fritz --- arch/arm/mach-omap2/board-flash.c | 3 +++ arch/arm/mach-omap2/gpmc-nand.c | 40 +------------------------------------ 2 files changed, 4 insertions(+), 39 deletions(-) diff --git a/arch/arm/mach-omap2/board-flash.c b/arch/arm/mach-omap2/board-flash.c index c33adea..fc20a61 100644 --- a/arch/arm/mach-omap2/board-flash.c +++ b/arch/arm/mach-omap2/board-flash.c @@ -112,6 +112,9 @@ struct gpmc_timings nand_default_timings[1] = { .cs_rd_off = 36, .cs_wr_off = 36, + .we_on = 6, + .oe_on = 6, + .adv_on = 6, .adv_rd_off = 24, .adv_wr_off = 36, diff --git a/arch/arm/mach-omap2/gpmc-nand.c b/arch/arm/mach-omap2/gpmc-nand.c index d9c2719..c8044b0 100644 --- a/arch/arm/mach-omap2/gpmc-nand.c +++ b/arch/arm/mach-omap2/gpmc-nand.c @@ -43,44 +43,6 @@ static struct platform_device gpmc_nand_device = { .resource = gpmc_nand_resource, }; -static int omap2_nand_gpmc_retime( - struct omap_nand_platform_data *gpmc_nand_data, - struct gpmc_timings *gpmc_t) -{ - struct gpmc_timings t; - int err; - - memset(&t, 0, sizeof(t)); - t.sync_clk = gpmc_t->sync_clk; - t.cs_on = gpmc_t->cs_on; - t.adv_on = gpmc_t->adv_on; - - /* Read */ - t.adv_rd_off = gpmc_t->adv_rd_off; - t.oe_on = t.adv_on; - t.access = gpmc_t->access; - t.oe_off = gpmc_t->oe_off; - t.cs_rd_off = gpmc_t->cs_rd_off; - t.rd_cycle = gpmc_t->rd_cycle; - - /* Write */ - t.adv_wr_off = gpmc_t->adv_wr_off; - t.we_on = t.oe_on; - if (cpu_is_omap34xx()) { - t.wr_data_mux_bus = gpmc_t->wr_data_mux_bus; - t.wr_access = gpmc_t->wr_access; - } - t.we_off = gpmc_t->we_off; - t.cs_wr_off = gpmc_t->cs_wr_off; - t.wr_cycle = gpmc_t->wr_cycle; - - err = gpmc_cs_set_timings(gpmc_nand_data->cs, &t); - if (err) - return err; - - return 0; -} - static bool gpmc_hwecc_bch_capable(enum omap_ecc ecc_opt) { /* support only OMAP3 class */ @@ -131,7 +93,7 @@ int gpmc_nand_init(struct omap_nand_platform_data *gpmc_nand_data, gpmc_get_client_irq(GPMC_IRQ_COUNT_EVENT); if (gpmc_t) { - err = omap2_nand_gpmc_retime(gpmc_nand_data, gpmc_t); + err = gpmc_cs_set_timings(gpmc_nand_data->cs, gpmc_t); if (err < 0) { dev_err(dev, "Unable to set gpmc timings: %d\n", err); return err;