| Message ID | 1369144071-10673-1-git-send-email-florian.vaussard@epfl.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
* Florian Vaussard <florian.vaussard@epfl.ch> [130521 07:01]: > The reset GPIO should be set for the SMSC911x, otherwise the controller > will not work and probing will fail. In the case of the tobi-duo > expansion board, the second controller shares the same GPIO, thus no > more changes are required (not tested). > > Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch> Thanks applying into omap-for-v3.11/board. Regards, Tony > --- > arch/arm/mach-omap2/board-overo.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-omap2/board-overo.c b/arch/arm/mach-omap2/board-overo.c > index 4ca6b68..5748b5d 100644 > --- a/arch/arm/mach-omap2/board-overo.c > +++ b/arch/arm/mach-omap2/board-overo.c > @@ -68,6 +68,7 @@ > > #define OVERO_SMSC911X_CS 5 > #define OVERO_SMSC911X_GPIO 176 > +#define OVERO_SMSC911X_NRESET 64 > #define OVERO_SMSC911X2_CS 4 > #define OVERO_SMSC911X2_GPIO 65 > > @@ -122,7 +123,7 @@ static struct omap_smsc911x_platform_data smsc911x_cfg = { > .id = 0, > .cs = OVERO_SMSC911X_CS, > .gpio_irq = OVERO_SMSC911X_GPIO, > - .gpio_reset = -EINVAL, > + .gpio_reset = OVERO_SMSC911X_NRESET, > .flags = SMSC911X_USE_32BIT, > }; > > -- > 1.7.5.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-omap2/board-overo.c b/arch/arm/mach-omap2/board-overo.c index 4ca6b68..5748b5d 100644 --- a/arch/arm/mach-omap2/board-overo.c +++ b/arch/arm/mach-omap2/board-overo.c @@ -68,6 +68,7 @@ #define OVERO_SMSC911X_CS 5 #define OVERO_SMSC911X_GPIO 176 +#define OVERO_SMSC911X_NRESET 64 #define OVERO_SMSC911X2_CS 4 #define OVERO_SMSC911X2_GPIO 65 @@ -122,7 +123,7 @@ static struct omap_smsc911x_platform_data smsc911x_cfg = { .id = 0, .cs = OVERO_SMSC911X_CS, .gpio_irq = OVERO_SMSC911X_GPIO, - .gpio_reset = -EINVAL, + .gpio_reset = OVERO_SMSC911X_NRESET, .flags = SMSC911X_USE_32BIT, };
The reset GPIO should be set for the SMSC911x, otherwise the controller will not work and probing will fail. In the case of the tobi-duo expansion board, the second controller shares the same GPIO, thus no more changes are required (not tested). Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch> --- arch/arm/mach-omap2/board-overo.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)