diff mbox

usb: host: xhci-plat: release mem region while removing module

Message ID 1371803348-9807-1-git-send-email-george.cherian@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

George Cherian June 21, 2013, 8:29 a.m. UTC
Do a release_mem_region of the hcd resource. Without this the
subsequent insertion of module fails in request_mem_region.

Signed-off-by: George Cherian <george.cherian@ti.com>
---
 drivers/usb/host/xhci-plat.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Felipe Balbi June 24, 2013, 2:22 p.m. UTC | #1
On Fri, Jun 21, 2013 at 01:59:08PM +0530, George Cherian wrote:
> Do a release_mem_region of the hcd resource. Without this the
> subsequent insertion of module fails in request_mem_region.
> 
> Signed-off-by: George Cherian <george.cherian@ti.com>

very nice catch.

Acked-by: Felipe Balbi <balbi@ti.com>

You need to resend with:

	Cc: <stable@vger.kernel.org> # v3.4+

Not sure if Sarah wants to take care of the stable tagging, though.
Sarah Sharp June 25, 2013, 6:23 p.m. UTC | #2
On Mon, Jun 24, 2013 at 05:22:24PM +0300, Felipe Balbi wrote:
> On Fri, Jun 21, 2013 at 01:59:08PM +0530, George Cherian wrote:
> > Do a release_mem_region of the hcd resource. Without this the
> > subsequent insertion of module fails in request_mem_region.
> > 
> > Signed-off-by: George Cherian <george.cherian@ti.com>
> 
> very nice catch.
> 
> Acked-by: Felipe Balbi <balbi@ti.com>
> 
> You need to resend with:
> 
> 	Cc: <stable@vger.kernel.org> # v3.4+
> 
> Not sure if Sarah wants to take care of the stable tagging, though.

I'll take care of the stable tagging.

Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
index df90fe5..93ad67e 100644
--- a/drivers/usb/host/xhci-plat.c
+++ b/drivers/usb/host/xhci-plat.c
@@ -179,6 +179,7 @@  static int xhci_plat_remove(struct platform_device *dev)
 
 	usb_remove_hcd(hcd);
 	iounmap(hcd->regs);
+	release_mem_region(hcd->rsrc_start, hcd->rsrc_len);
 	usb_put_hcd(hcd);
 	kfree(xhci);