| Message ID | 1375109728-5931-1-git-send-email-coelho@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Luciano, Thank you for the patch. On Monday 29 July 2013 17:55:28 Luciano Coelho wrote: > Add device tree bindings documentation for the TI WiLink modules. > Currently only the WLAN part of the WiLink6, WiLink7 and WiLink8 > modules is supported. > > Signed-off-by: Luciano Coelho <coelho@ti.com> > --- > > Changes in v2: > > Use generic clock definitions to get the clock data instead of passing > the frequencies directly. Also added definition for "internal" > ti,wilink-clock. > > Please review. The proposal looks good to me, I just have one small comment. > .../devicetree/bindings/net/wireless/ti-wilink.txt | 68 +++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/net/wireless/ti-wilink.txt > > diff --git a/Documentation/devicetree/bindings/net/wireless/ti-wilink.txt > b/Documentation/devicetree/bindings/net/wireless/ti-wilink.txt new file > mode 100644 > index 0000000..5fd27dc > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/wireless/ti-wilink.txt > @@ -0,0 +1,68 @@ > +TI WiLink Wireless Modules Device Tree Bindings > +=============================================== > + > +The WiLink modules provide wireless connectivity, such as WLAN, > +Bluetooth, FM and NFC. > + > +There are several different modules available, which can be grouped by > +their generation: WiLink6, WiLink7 and WiLink8. WiLink4 is not > +currently supported with device tree. > + > +Currently, only the WLAN portion of the modules is supported with > +device tree. > + > +Required properties: > +-------------------- > + > +- compatible: should be "ti,wilink6", "ti,wilink7" or "ti,wilink8" > +- interrupt-parent: the interrupt controller > +- interrupts: out-of-band WLAN interrupt > + See the interrupt controller's bindings documentation for > + detailed definition. > + > +Optional properties: > +-------------------- > + > +- clocks: list of clocks needed by the chip as follows: > + > + refclock: the internal WLAN reference clock frequency (required for > + WiLink6 and WiLink7; not used for WiLink8). > + > + tcxoclock: the internal WLAN TCXO clock frequency (required for > + WiLink7 not used for WiLink6 and WiLink8). > + > + The clocks must be defined and named accordingly. For example: > + > + clocks = <&refclock> > + clock-names = "refclock"; > + > + refclock: refclock { > + compatible = "ti,wilink-clock"; > + #clock-cells = <0>; > + clock-frequency = <38400000>; > + }; > + > + Some modules that contain the WiLink chip provide clocks in the > + module itself. In this case, we define a "ti,wilink-clock" as shown > + above. But any other clock could in theory be used, so the proper > + clock definition should be used. > + > + > +Example: > +-------- > + > +Example definition that can be used in OMAP4 Panda: > + > +wlan { > + compatible = "ti,wilink6"; > + interrupt-parent = <&gpio2>; > + interrupts = <21 0x4>; /* gpio line 53, high level triggered */ Could you please use the IRQ_TYPE_LEVEL_HIGH macro (defined in <dt- bindings/interrupt-controller/irq.h>) instead of the hardcode 0x4 constant ? > + clocks = <&refclock>; > + clock-names = "refclock"; > + > + refclock: refclock { > + compatible = "ti,wilink-clock"; > + #clock-cells = <0>; > + clock-frequency = <38400000>; > + }; > +};
(using the new devicetree mailing list address) On Tue, 2013-07-30 at 20:24 +0200, Laurent Pinchart wrote: > Hi Luciano, > > Thank you for the patch. > > On Monday 29 July 2013 17:55:28 Luciano Coelho wrote: > > Add device tree bindings documentation for the TI WiLink modules. > > Currently only the WLAN part of the WiLink6, WiLink7 and WiLink8 > > modules is supported. > > > > Signed-off-by: Luciano Coelho <coelho@ti.com> > > --- > > > > Changes in v2: > > > > Use generic clock definitions to get the clock data instead of passing > > the frequencies directly. Also added definition for "internal" > > ti,wilink-clock. > > > > Please review. > > The proposal looks good to me, I just have one small comment. Cool! Thanks for the review. [...] > > +Example: > > +-------- > > + > > +Example definition that can be used in OMAP4 Panda: > > + > > +wlan { > > + compatible = "ti,wilink6"; > > + interrupt-parent = <&gpio2>; > > + interrupts = <21 0x4>; /* gpio line 53, high level triggered */ > > Could you please use the IRQ_TYPE_LEVEL_HIGH macro (defined in <dt- > bindings/interrupt-controller/irq.h>) instead of the hardcode 0x4 constant ? Ah, right, I saw this new header file recently but forgot to update my example. I'll update the OMAP4 Panda and OMAP4 SDP dts files I just sent out as well. -- Cheers, Luca. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/net/wireless/ti-wilink.txt b/Documentation/devicetree/bindings/net/wireless/ti-wilink.txt new file mode 100644 index 0000000..5fd27dc --- /dev/null +++ b/Documentation/devicetree/bindings/net/wireless/ti-wilink.txt @@ -0,0 +1,68 @@ +TI WiLink Wireless Modules Device Tree Bindings +=============================================== + +The WiLink modules provide wireless connectivity, such as WLAN, +Bluetooth, FM and NFC. + +There are several different modules available, which can be grouped by +their generation: WiLink6, WiLink7 and WiLink8. WiLink4 is not +currently supported with device tree. + +Currently, only the WLAN portion of the modules is supported with +device tree. + +Required properties: +-------------------- + +- compatible: should be "ti,wilink6", "ti,wilink7" or "ti,wilink8" +- interrupt-parent: the interrupt controller +- interrupts: out-of-band WLAN interrupt + See the interrupt controller's bindings documentation for + detailed definition. + +Optional properties: +-------------------- + +- clocks: list of clocks needed by the chip as follows: + + refclock: the internal WLAN reference clock frequency (required for + WiLink6 and WiLink7; not used for WiLink8). + + tcxoclock: the internal WLAN TCXO clock frequency (required for + WiLink7 not used for WiLink6 and WiLink8). + + The clocks must be defined and named accordingly. For example: + + clocks = <&refclock> + clock-names = "refclock"; + + refclock: refclock { + compatible = "ti,wilink-clock"; + #clock-cells = <0>; + clock-frequency = <38400000>; + }; + + Some modules that contain the WiLink chip provide clocks in the + module itself. In this case, we define a "ti,wilink-clock" as shown + above. But any other clock could in theory be used, so the proper + clock definition should be used. + + +Example: +-------- + +Example definition that can be used in OMAP4 Panda: + +wlan { + compatible = "ti,wilink6"; + interrupt-parent = <&gpio2>; + interrupts = <21 0x4>; /* gpio line 53, high level triggered */ + clocks = <&refclock>; + clock-names = "refclock"; + + refclock: refclock { + compatible = "ti,wilink-clock"; + #clock-cells = <0>; + clock-frequency = <38400000>; + }; +};
Add device tree bindings documentation for the TI WiLink modules. Currently only the WLAN part of the WiLink6, WiLink7 and WiLink8 modules is supported. Signed-off-by: Luciano Coelho <coelho@ti.com> --- Changes in v2: Use generic clock definitions to get the clock data instead of passing the frequencies directly. Also added definition for "internal" ti,wilink-clock. Please review. Luca. .../devicetree/bindings/net/wireless/ti-wilink.txt | 68 ++++++++++++++++++++++ 1 file changed, 68 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/wireless/ti-wilink.txt