From patchwork Fri Feb 14 05:28:02 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nishanth Menon X-Patchwork-Id: 3649981 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id F189ABF40C for ; Fri, 14 Feb 2014 05:28:35 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 32547201C7 for ; Fri, 14 Feb 2014 05:28:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8BCB620212 for ; Fri, 14 Feb 2014 05:28:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751275AbaBNF2O (ORCPT ); Fri, 14 Feb 2014 00:28:14 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:37392 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750895AbaBNF2N (ORCPT ); Fri, 14 Feb 2014 00:28:13 -0500 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id s1E5S3IR013752; Thu, 13 Feb 2014 23:28:03 -0600 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id s1E5S3nO029095; Thu, 13 Feb 2014 23:28:03 -0600 Received: from dflp33.itg.ti.com (10.64.6.16) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.3.174.1; Thu, 13 Feb 2014 23:28:03 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id s1E5S3f5032421; Thu, 13 Feb 2014 23:28:03 -0600 From: Nishanth Menon To: Balaji T K , Chris Ball CC: , , , Nishanth Menon Subject: [PATCH] mmc: omap_hsmmc: fix sparse/smatch warning for paranthesis Date: Thu, 13 Feb 2014 23:28:02 -0600 Message-ID: <1392355682-30802-1-git-send-email-nm@ti.com> X-Mailer: git-send-email 1.7.9.5 MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP commit 6c31b21 (mmc: omap_hsmmc: remove access to SYSCONFIG register) introduced an smatch(http://smatch.sf.net) warning for the following: drivers/mmc/host/omap_hsmmc.c:608 omap_hsmmc_context_restore() warn: add some parenthesis here? drivers/mmc/host/omap_hsmmc.c:608 omap_hsmmc_context_restore() warn: maybe use && instead of & sparse reports: drivers/mmc/host/omap_hsmmc.c: warning: dubious: !x & y Fix the same. Signed-off-by: Nishanth Menon --- drivers/mmc/host/omap_hsmmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index dbd32ad..575f9cc 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -605,7 +605,7 @@ static int omap_hsmmc_context_restore(struct omap_hsmmc_host *host) u32 hctl, capa; unsigned long timeout; - if (!OMAP_HSMMC_READ(host->base, SYSSTATUS) & RESETDONE) + if (!(OMAP_HSMMC_READ(host->base, SYSSTATUS) & RESETDONE)) return 1; if (host->con == OMAP_HSMMC_READ(host->base, CON) &&