| Message ID | 1394526833-24805-4-git-send-email-archit@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 03/11/14 09:33, Archit Taneja wrote: > The video_device struct is currently embedded in the driver data struct vpe_dev. > A vpe_dev instance is allocated by the driver, and the memory for the vfd is a > part of this struct. > > The v4l2 core, however, manages the removal of the vfd region, through the > video_device's .release() op, which currently is the helper > video_device_release. This causes memory corruption, and leads to issues when > we try to re-insert the vpe module. > > Use the video_device_release_empty helper function instead > > Signed-off-by: Archit Taneja <archit@ti.com> Reviewed-by: Hans Verkuil <hans.verkuil@cisco.com> > --- > drivers/media/platform/ti-vpe/vpe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c > index f1eae67..0363df6 100644 > --- a/drivers/media/platform/ti-vpe/vpe.c > +++ b/drivers/media/platform/ti-vpe/vpe.c > @@ -2000,7 +2000,7 @@ static struct video_device vpe_videodev = { > .fops = &vpe_fops, > .ioctl_ops = &vpe_ioctl_ops, > .minor = -1, > - .release = video_device_release, > + .release = video_device_release_empty, > .vfl_dir = VFL_DIR_M2M, > }; > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c index f1eae67..0363df6 100644 --- a/drivers/media/platform/ti-vpe/vpe.c +++ b/drivers/media/platform/ti-vpe/vpe.c @@ -2000,7 +2000,7 @@ static struct video_device vpe_videodev = { .fops = &vpe_fops, .ioctl_ops = &vpe_ioctl_ops, .minor = -1, - .release = video_device_release, + .release = video_device_release_empty, .vfl_dir = VFL_DIR_M2M, };
The video_device struct is currently embedded in the driver data struct vpe_dev. A vpe_dev instance is allocated by the driver, and the memory for the vfd is a part of this struct. The v4l2 core, however, manages the removal of the vfd region, through the video_device's .release() op, which currently is the helper video_device_release. This causes memory corruption, and leads to issues when we try to re-insert the vpe module. Use the video_device_release_empty helper function instead Signed-off-by: Archit Taneja <archit@ti.com> --- drivers/media/platform/ti-vpe/vpe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)