diff mbox

ARM: dts: Correct offset in OMAP4_WKUP_IOPAD macro

Message ID 1397924056-6462-1-git-send-email-manabian@gmail.com (mailing list archive)
State Superseded
Headers show

Commit Message

Joachim Eastwood April 19, 2014, 4:14 p.m. UTC
This was introduced in 43a348ea53eb5fd79 but hasn't caused
any harm since it don't have any users yet.

Signed-off-by: Joachim Eastwood <manabian@gmail.com>
---
Hello,

This one had me puzzled for a while. Wondering why USB
suddenly disappeared and suspecting by convert script.

 -JE

 include/dt-bindings/pinctrl/omap.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Joachim Eastwood April 19, 2014, 4:25 p.m. UTC | #1
On 19 April 2014 18:14, Joachim Eastwood <manabian@gmail.com> wrote:
> This was introduced in 43a348ea53eb5fd79 but hasn't caused
> any harm since it don't have any users yet.

Or maybe I am confused about this macro.

Tony which offset from the OMAP4 TRM should be used?

Under section 18.6.8 there are is a column with address offset. Is
this the number you want in the macro?

regards
Joachim Eastwood

> Signed-off-by: Joachim Eastwood <manabian@gmail.com>
> ---
> Hello,
>
> This one had me puzzled for a while. Wondering why USB
> suddenly disappeared and suspecting by convert script.
>
>  -JE
>
>  include/dt-bindings/pinctrl/omap.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/dt-bindings/pinctrl/omap.h b/include/dt-bindings/pinctrl/omap.h
> index b04528cd033c..251d1bd17e35 100644
> --- a/include/dt-bindings/pinctrl/omap.h
> +++ b/include/dt-bindings/pinctrl/omap.h
> @@ -63,7 +63,7 @@
>  #define OMAP3_WKUP_IOPAD(pa, val)      OMAP_IOPAD_OFFSET((pa), 0x2a00) (val)
>  #define AM33XX_IOPAD(pa, val)          OMAP_IOPAD_OFFSET((pa), 0x0800) (val)
>  #define OMAP4_CORE_IOPAD(pa, val)      OMAP_IOPAD_OFFSET((pa), 0x0040) (val)
> -#define OMAP4_WKUP_IOPAD(pa, val)      OMAP_IOPAD_OFFSET((pa), 0xe040) (val)
> +#define OMAP4_WKUP_IOPAD(pa, val)      OMAP_IOPAD_OFFSET((pa), 0x0040) (val)
>  #define AM4372_IOPAD(pa, val)          OMAP_IOPAD_OFFSET((pa), 0x0800) (val)
>  #define OMAP5_CORE_IOPAD(pa, val)      OMAP_IOPAD_OFFSET((pa), 0x2840) (val)
>  #define OMAP5_WKUP_IOPAD(pa, val)      OMAP_IOPAD_OFFSET((pa), 0xc840) (val)
> --
> 1.8.0
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/include/dt-bindings/pinctrl/omap.h b/include/dt-bindings/pinctrl/omap.h
index b04528cd033c..251d1bd17e35 100644
--- a/include/dt-bindings/pinctrl/omap.h
+++ b/include/dt-bindings/pinctrl/omap.h
@@ -63,7 +63,7 @@ 
 #define OMAP3_WKUP_IOPAD(pa, val)	OMAP_IOPAD_OFFSET((pa), 0x2a00) (val)
 #define AM33XX_IOPAD(pa, val)		OMAP_IOPAD_OFFSET((pa), 0x0800) (val)
 #define OMAP4_CORE_IOPAD(pa, val)	OMAP_IOPAD_OFFSET((pa), 0x0040) (val)
-#define OMAP4_WKUP_IOPAD(pa, val)	OMAP_IOPAD_OFFSET((pa), 0xe040) (val)
+#define OMAP4_WKUP_IOPAD(pa, val)	OMAP_IOPAD_OFFSET((pa), 0x0040) (val)
 #define AM4372_IOPAD(pa, val)		OMAP_IOPAD_OFFSET((pa), 0x0800) (val)
 #define OMAP5_CORE_IOPAD(pa, val)	OMAP_IOPAD_OFFSET((pa), 0x2840) (val)
 #define OMAP5_WKUP_IOPAD(pa, val)	OMAP_IOPAD_OFFSET((pa), 0xc840) (val)