diff mbox

hsi: nokia-modem: fix uninitialized device pointer

Message ID 1420392853-5242-1-git-send-email-aaro.koskinen@iki.fi (mailing list archive)
State New, archived
Headers show

Commit Message

Aaro Koskinen Jan. 4, 2015, 5:34 p.m. UTC 
modem->device was never initialized. This resulted in logs such as:

[  241.386322] (NULL device *): CMT rst line change detected

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
---
 drivers/hsi/clients/nokia-modem.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Sebastian Reichel Jan. 4, 2015, 7:23 p.m. UTC | #1 
Hi Aaro,

On Sun, Jan 04, 2015 at 07:34:13PM +0200, Aaro Koskinen wrote:
> modem->device was never initialized. This resulted in logs such as:
> [  241.386322] (NULL device *): CMT rst line change detected

Thanks, applied to for-next:

https://git.kernel.org/cgit/linux/kernel/git/sre/linux-hsi.git/commit/?h=for-next&id=67e9a2ce6e070b1e5db2dfe9c61890fc30ae954d

-- Sebastian
diff mbox

Patch

diff --git a/drivers/hsi/clients/nokia-modem.c b/drivers/hsi/clients/nokia-modem.c
index f0c2145..eb4dc63 100644
--- a/drivers/hsi/clients/nokia-modem.c
+++ b/drivers/hsi/clients/nokia-modem.c
@@ -162,6 +162,7 @@  static int nokia_modem_probe(struct device *dev)
 		return -ENOMEM;
 	}
 	dev_set_drvdata(dev, modem);
+	modem->device = dev;
 
 	irq = irq_of_parse_and_map(np, 0);
 	if (!irq) {