From patchwork Wed Jan 7 17:30:54 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suman Anna X-Patchwork-Id: 5586131 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id BC9D09F1C5 for ; Wed, 7 Jan 2015 17:32:04 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E94312027D for ; Wed, 7 Jan 2015 17:32:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 028BE202A1 for ; Wed, 7 Jan 2015 17:32:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754957AbbAGRbb (ORCPT ); Wed, 7 Jan 2015 12:31:31 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:55359 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754360AbbAGRb3 (ORCPT ); Wed, 7 Jan 2015 12:31:29 -0500 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id t07HUuJt015087; Wed, 7 Jan 2015 11:30:56 -0600 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id t07HUu57032551; Wed, 7 Jan 2015 11:30:56 -0600 Received: from dlep32.itg.ti.com (157.170.170.100) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.3.174.1; Wed, 7 Jan 2015 11:30:55 -0600 Received: from legion.dal.design.ti.com (legion.dal.design.ti.com [128.247.22.53]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id t07HUtqU022292; Wed, 7 Jan 2015 11:30:55 -0600 Received: from localhost (irmo.am.dhcp.ti.com [128.247.71.175]) by legion.dal.design.ti.com (8.11.7p1+Sun/8.11.7) with ESMTP id t07HUtt10081; Wed, 7 Jan 2015 11:30:55 -0600 (CST) From: Suman Anna To: Grant Likely , Rob Herring CC: Greg Kroah-Hartman , Pawel Moll , Pantelis Antoniou , Felipe Balbi , , , , , Suman Anna Subject: [RFC PATCH 3/3] of/unittest: fix trailing semi-colons on conditional selftest Date: Wed, 7 Jan 2015 11:30:54 -0600 Message-ID: <1420651854-17768-4-git-send-email-s-anna@ti.com> X-Mailer: git-send-email 2.2.1 In-Reply-To: <1420651854-17768-1-git-send-email-s-anna@ti.com> References: <1420651854-17768-1-git-send-email-s-anna@ti.com> MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The of_platform_populate() and of_platform_depopulate() tests are not really being tested because of some additional trailing semi-colons after the conditional checks on couple of selftest macro usage. Remove them to properly run all the platform tests. Fixes: 851da976dc1d (of/unittest: Remove test devices after adding them) Signed-off-by: Suman Anna --- drivers/of/unittest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index 844838e11ef1..c67e50264e82 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -765,11 +765,11 @@ static void __init of_selftest_platform_populate(void) selftest(irq < 0 && irq != -EPROBE_DEFER, "device parsing error failed - %d\n", irq); if (selftest(np = of_find_node_by_path("/testcase-data/platform-tests"), - "No testcase data in device tree\n")); + "No testcase data in device tree\n")) return; if (selftest(!(rc = device_register(&test_bus)), - "testbus registration failed; rc=%i\n", rc)); + "testbus registration failed; rc=%i\n", rc)) return; for_each_child_of_node(np, child) {