diff mbox

ARM: OMAP: DRA7: hwmod: Make gpmc software supervised as the smart idle is broken

Message ID 1421139085-27183-1-git-send-email-j-keerthy@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

J, KEERTHY Jan. 13, 2015, 8:51 a.m. UTC
This patch fixes: 'omap_hwmod: gpmc: _wait_target_disable failed'
error during suspend.

This is because smart idle is broken.
Tested in dra7-evm D1 board.

Signed-off-by: Keerthy <j-keerthy@ti.com>
---
 arch/arm/mach-omap2/omap_hwmod_7xx_data.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Keerthy Jan. 20, 2015, 6:23 a.m. UTC | #1
Hi Tony,

On Tuesday 13 January 2015 02:21 PM, Keerthy wrote:
> This patch fixes: 'omap_hwmod: gpmc: _wait_target_disable failed'
> error during suspend.
>
> This is because smart idle is broken.
> Tested in dra7-evm D1 board.

Ping on this.

> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>   arch/arm/mach-omap2/omap_hwmod_7xx_data.c |    3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> index 9cdd8b8..29e55fe 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> @@ -826,7 +826,8 @@ static struct omap_hwmod dra7xx_gpmc_hwmod = {
>   	.name		= "gpmc",
>   	.class		= &dra7xx_gpmc_hwmod_class,
>   	.clkdm_name	= "l3main1_clkdm",
> -	.flags		= HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET,
> +	.flags		= (HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET |
> +			   HWMOD_SWSUP_SIDLE),
>   	.main_clk	= "l3_iclk_div",
>   	.prcm = {
>   		.omap4 = {

Regards,
Keerthy
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Paul Walmsley Jan. 20, 2015, 7:23 a.m. UTC | #2
On Tue, 20 Jan 2015, Keerthy wrote:

> On Tuesday 13 January 2015 02:21 PM, Keerthy wrote:
> > This patch fixes: 'omap_hwmod: gpmc: _wait_target_disable failed'
> > error during suspend.
> > 
> > This is because smart idle is broken.
> > Tested in dra7-evm D1 board.
> 
> Ping on this.
> 
> > Signed-off-by: Keerthy <j-keerthy@ti.com>
> > ---
> >   arch/arm/mach-omap2/omap_hwmod_7xx_data.c |    3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> > b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> > index 9cdd8b8..29e55fe 100644
> > --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> > +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> > @@ -826,7 +826,8 @@ static struct omap_hwmod dra7xx_gpmc_hwmod = {
> >   	.name		= "gpmc",
> >   	.class		= &dra7xx_gpmc_hwmod_class,
> >   	.clkdm_name	= "l3main1_clkdm",
> > -	.flags		= HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET,
> > +	.flags		= (HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET |
> > +			   HWMOD_SWSUP_SIDLE),
> >   	.main_clk	= "l3_iclk_div",
> >   	.prcm = {
> >   		.omap4 = {

Thanks, queued for v3.20.

Note that I cannot test this since I don't have a DRA7xx board.


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
index 9cdd8b8..29e55fe 100644
--- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
@@ -826,7 +826,8 @@  static struct omap_hwmod dra7xx_gpmc_hwmod = {
 	.name		= "gpmc",
 	.class		= &dra7xx_gpmc_hwmod_class,
 	.clkdm_name	= "l3main1_clkdm",
-	.flags		= HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET,
+	.flags		= (HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET |
+			   HWMOD_SWSUP_SIDLE),
 	.main_clk	= "l3_iclk_div",
 	.prcm = {
 		.omap4 = {