From patchwork Fri Mar 6 19:26:56 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Grygorii.Strashko@linaro.org" X-Patchwork-Id: 5957431 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A87C09F36A for ; Fri, 6 Mar 2015 19:27:12 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E32A32039D for ; Fri, 6 Mar 2015 19:27:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BFADC203A1 for ; Fri, 6 Mar 2015 19:27:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756019AbbCFT1J (ORCPT ); Fri, 6 Mar 2015 14:27:09 -0500 Received: from mail-lb0-f175.google.com ([209.85.217.175]:38131 "EHLO mail-lb0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755698AbbCFT1I (ORCPT ); Fri, 6 Mar 2015 14:27:08 -0500 Received: by lbiz12 with SMTP id z12so36866835lbi.5 for ; Fri, 06 Mar 2015 11:27:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=BUV/3Y95MkRtQ+lKYBRrxdbLzOMnlZxNQ8O3m9FnhzM=; b=aA5nAV5jQ0iSqzqLm3zcPqsp/tQch8qHQW/TNX91k9IcJYZPJ44S4ioH/9dAFvhrpq wUMKAReFt0GJlvVTzl5J2NSwe/choWc7GOhWjoiB/PKTnZQlco6S0yuSUjSI7lYzo8FR pocMMcq31uHv0/7jQF0N3fQyA1NXMuQUYjshAIJmm70sX9EOYmegqk0bm0iHw2TaHZRr RM3zmoE9R0A+H6qK0Bzo7Ku8fpeCOioE4ygx2cMxKl0UJ9BKWerLD9V56DUpQNy3HYty J0ZIgqlQfZyNnK62VECJki2vDM1KT1EZWdm1+f/SVgLCo1b/Kz572C6jSvekcOfLxoTs yGAA== X-Gm-Message-State: ALoCoQmvO8tqpYQcOrQLOTEcuuI+etb5mDKjDcfl8tkndHSDNIFe2zcuO4XI99h6C80sXth6vas7 X-Received: by 10.152.204.42 with SMTP id kv10mr8083942lac.52.1425670026519; Fri, 06 Mar 2015 11:27:06 -0800 (PST) Received: from localhost ([195.238.92.128]) by mx.google.com with ESMTPSA id i6sm1967973lai.1.2015.03.06.11.27.05 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 06 Mar 2015 11:27:06 -0800 (PST) From: To: Linus Walleij , ssantosh@kernel.org, Javier Martinez Canillas , tony@atomide.com Cc: Alexandre Courbot , linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org, Grygorii Strashko Subject: [PATCH 1/2] gpio: omap: irq_shutdown: remove unnecessary call of gpiochip_unlock_as_irq Date: Fri, 6 Mar 2015 21:26:56 +0200 Message-Id: <1425670017-19598-1-git-send-email-grygorii.strashko@linaro.org> X-Mailer: git-send-email 1.9.1 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DRUGS_ERECTILE, DRUGS_ERECTILE_OBFU,FUZZY_CPILL,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Grygorii Strashko GPIOLib core implemnts irqchip->irq_request/release_resources callbacks internally and these callbacks already contain clalls of gpiochip_lock/unlock_as_irq(). Hence, remove unnecessary call of gpiochip_unlock_as_irq() from omap_gpio_irq_shutdown(). Signed-off-by: Grygorii Strashko --- drivers/gpio/gpio-omap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c index f476ae2..2b2fc4b 100644 --- a/drivers/gpio/gpio-omap.c +++ b/drivers/gpio/gpio-omap.c @@ -826,7 +826,6 @@ static void omap_gpio_irq_shutdown(struct irq_data *d) unsigned offset = GPIO_INDEX(bank, gpio); spin_lock_irqsave(&bank->lock, flags); - gpiochip_unlock_as_irq(&bank->chip, offset); bank->irq_usage &= ~(BIT(offset)); omap_disable_gpio_module(bank, offset); omap_reset_gpio(bank, gpio);