From patchwork Wed May 13 13:50:01 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Nelson X-Patchwork-Id: 6397221 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id F210EBEEE1 for ; Wed, 13 May 2015 13:50:27 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 294D1201EF for ; Wed, 13 May 2015 13:50:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3F2A92041F for ; Wed, 13 May 2015 13:50:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933809AbbEMNuZ (ORCPT ); Wed, 13 May 2015 09:50:25 -0400 Received: from mail-ie0-f176.google.com ([209.85.223.176]:35524 "EHLO mail-ie0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965146AbbEMNuW (ORCPT ); Wed, 13 May 2015 09:50:22 -0400 Received: by iebpz10 with SMTP id pz10so32423649ieb.2; Wed, 13 May 2015 06:50:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=iUa7T8UDbnRxRtuCoV7QmjYh1Nw16mZ3MzxRd4uGSrk=; b=Oe1dm9jgdEfHZBE+M0FNwmG6xZisWmtkgQ5hBaaGfSo4o+tMnjXbQUCcB7ENeYnkOn YjvWfOqpOslLw0wmjPh2DVBDNVe7HDokrSWngfF0/mzxM+Rnmhw6PD2RlRC5zcVMnlE6 2S6mw1BpTZs6QKTynkTbnEt66fIuWDU8hpKrNq9tENrWft73+eOGlBR/+nhTMmik68k7 pgu/3ZAAinQnpMT7bKtCGfcTAUjfqDqOPvEE5DIQ5xF13HcdnewWhoEXhspkRMWY88VV GCAbRLAYFHE4ld0PZjnmcg5WGBamkVC2ewrOlZU2Nxdg0cVAoCQFLsl2EIb+0l10ZfZY Xgxw== X-Received: by 10.107.132.42 with SMTP id g42mr26806154iod.25.1431525021468; Wed, 13 May 2015 06:50:21 -0700 (PDT) Received: from hades.digikey.us ([64.77.213.245]) by mx.google.com with ESMTPSA id o9sm14268305ioe.35.2015.05.13.06.50.19 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 13 May 2015 06:50:20 -0700 (PDT) From: Robert Nelson To: tony@atomide.com, devicetree@vger.kernel.org Cc: matthijsvanduin@gmail.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Robert Nelson , Felipe Balbi , Johan Hovold Subject: [PATCH] ARM: dts: am335x-bone* enable pmic-shutdown-controller Date: Wed, 13 May 2015 08:50:01 -0500 Message-Id: <1431525001-5747-1-git-send-email-robertcnelson@gmail.com> X-Mailer: git-send-email 2.1.4 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fixes: http://bugs.elinux.org/issues/143 Commit 672e2b147 which introduced proper shutdown chose to let the PMIC go into sleep-state (aka "RTC-only mode") rather than off-state. This was fine for rev A5 on which that patch was tested, but since then two changes have been made to the power supply scheme: (rev A6) enable of the 3v3b regulator moved from LDO2 to LDO4 (3v3a) side-effect: 3v3b rail remains on in sleep-mode (also in off-mode when battery-powered) (rev A6A) am335x vdds supply moved from LDO3 to LDO1 side-effect: vdds remains supplied in sleep-mode As a result heavy leakage occurs from vdds (directly) and 3v3b (via i/o pins) to the 3v3a. The amount of current depends on external connections, but for example leaving a serial console cable connected in this state resulted in serious violation of am335x absolute maximum ratings, with potential for hardware damage. Reported-by: Matthijs van Duin Tested-by: Matthijs van Duin Signed-off-by: Robert Nelson Cc: Tony Lindgren Cc: Felipe Balbi Cc: Johan Hovold Acked-by: Johan Hovold --- arch/arm/boot/dts/am335x-bone-common.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi index c3255e0..7198b81 100644 --- a/arch/arm/boot/dts/am335x-bone-common.dtsi +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi @@ -223,6 +223,8 @@ /include/ "tps65217.dtsi" &tps { + ti,pmic-shutdown-controller; + regulators { dcdc1_reg: regulator@0 { regulator-name = "vdds_dpr";