From patchwork Tue Jul 14 12:10:47 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 6786831 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 7C271C05AC for ; Tue, 14 Jul 2015 12:11:04 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A6CA1206E3 for ; Tue, 14 Jul 2015 12:11:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B50F2206D6 for ; Tue, 14 Jul 2015 12:11:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751776AbbGNMLA (ORCPT ); Tue, 14 Jul 2015 08:11:00 -0400 Received: from sauhun.de ([89.238.76.85]:51770 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751360AbbGNMLA (ORCPT ); Tue, 14 Jul 2015 08:11:00 -0400 Received: from p4fe256b3.dip0.t-ipconnect.de ([79.226.86.179]:44333 helo=localhost) by pokefinder.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1ZEz34-0005qg-C7; Tue, 14 Jul 2015 14:10:58 +0200 From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: linux-omap@vger.kernel.org, Felipe Balbi , Wolfram Sang Subject: [PATCH] i2c: omap: fix cleanup regression Date: Tue, 14 Jul 2015 14:10:47 +0200 Message-Id: <1436875847-18700-1-git-send-email-wsa@the-dreams.de> X-Mailer: git-send-email 2.1.4 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Patch "i2c: omap: abolish variable name confusion" triggered a coccinelle warning which we fix here: drivers/i2c/busses/i2c-omap.c:1333:5-24: pm_runtime_get_sync returns < 0 as error. Unecessary IS_ERR_VALUE at line 1334 Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-omap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index 133dd0db6f5b76..edc4261191ba4d 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -1331,7 +1331,7 @@ omap_i2c_probe(struct platform_device *pdev) pm_runtime_use_autosuspend(omap->dev); r = pm_runtime_get_sync(omap->dev); - if (IS_ERR_VALUE(r)) + if (r < 0) goto err_free_mem; /*