From patchwork Thu Dec 10 13:11:45 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 7818851 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 7C9EBBEEE1 for ; Thu, 10 Dec 2015 13:17:29 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6F67A205B5 for ; Thu, 10 Dec 2015 13:17:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4995A20585 for ; Thu, 10 Dec 2015 13:17:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751750AbbLJNRX (ORCPT ); Thu, 10 Dec 2015 08:17:23 -0500 Received: from arcturus.kleine-koenig.org ([78.47.169.190]:60541 "EHLO arcturus.kleine-koenig.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751574AbbLJNRV (ORCPT ); Thu, 10 Dec 2015 08:17:21 -0500 Received: by arcturus.kleine-koenig.org (Postfix, from userid 1000) id 6FD3481EAD; Thu, 10 Dec 2015 14:12:09 +0100 (CET) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Tomi Valkeinen , Jean-Christophe Plagniol-Villard Cc: linux-omap@vger.kernel.org, kernel@pengutronix.de, linux-fbdev@vger.kernel.org, =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= Subject: [PATCH 3/5] fbdev: omap2: panel-dpi: drop assignment to local variable Date: Thu, 10 Dec 2015 14:11:45 +0100 Message-Id: <1449753107-11410-3-git-send-email-uwe@kleine-koenig.org> X-Mailer: git-send-email 2.6.2 In-Reply-To: <1449753107-11410-1-git-send-email-uwe@kleine-koenig.org> References: <1449753107-11410-1-git-send-email-uwe@kleine-koenig.org> MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Uwe Kleine-König The variable gpio is only used to store the return value of devm_gpiod_get_optional just to assign it to a member of the driver data. Get rid of this local variable and assign to driver data directly. Signed-off-by: Uwe Kleine-König --- drivers/video/fbdev/omap2/displays-new/panel-dpi.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/video/fbdev/omap2/displays-new/panel-dpi.c b/drivers/video/fbdev/omap2/displays-new/panel-dpi.c index e780fd4f8b46..1216341a0d19 100644 --- a/drivers/video/fbdev/omap2/displays-new/panel-dpi.c +++ b/drivers/video/fbdev/omap2/displays-new/panel-dpi.c @@ -205,13 +205,11 @@ static int panel_dpi_probe_of(struct platform_device *pdev) int r; struct display_timing timing; struct videomode vm; - struct gpio_desc *gpio; - gpio = devm_gpiod_get_optional(&pdev->dev, "enable", GPIOD_OUT_LOW); - if (IS_ERR(gpio)) - return PTR_ERR(gpio); - - ddata->enable_gpio = gpio; + ddata->enable_gpio = devm_gpiod_get_optional(&pdev->dev, + "enable", GPIOD_OUT_LOW); + if (IS_ERR(ddata->enable_gpio)) + return PTR_ERR(ddata->enable_gpio); ddata->backlight_gpio = -ENOENT;