| Message ID | 1453395800-2767-1-git-send-email-aford173@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
* Adam Ford <aford173@gmail.com> [160121 09:04]: > The tcxo-clock-frequency binding is listed as optional, > but without it the wl12xx used on the torpedo + wireless > may hang. Scanning also appears broken without this patch. OK sounds like we may have this missing for other boards as well. Do you know when tcxo-clock-frequency is not needed? Can it be seen from the schematics or something? Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
I don't know for sure what determines whether or not it's needed. I don't have the WL12xx data sheets from TI in front of me, and you need a special access to get them. The Logic PD Torpedo schematic shows a 26MHz signal feeding TCXO_P pin, so it seems reasonable to set it if its present. The stock BSP that Logic ships has both the reference clock and the TCXO defined, so I thought it was worth a try. I did comment about it on TI's E2E forum. I am hoping someone there might respond. I am going to send an e-mail to the wlcore authors to see if they can explain what makes certain parameters optional and also further define what does 'optional' really mean. Without the patch, I was able to get the WiFi working, but scanning was broken. I'll let you know what I hear back. adam On Thu, Jan 21, 2016 at 11:21 AM, Tony Lindgren <tony@atomide.com> wrote: > * Adam Ford <aford173@gmail.com> [160121 09:04]: >> The tcxo-clock-frequency binding is listed as optional, >> but without it the wl12xx used on the torpedo + wireless >> may hang. Scanning also appears broken without this patch. > > OK sounds like we may have this missing for other boards as > well. Do you know when tcxo-clock-frequency is not needed? > Can it be seen from the schematics or something? > > Regards, > > Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
According to a message I received from TI, this parameter is required for the WL12xx family but optional for the WL18xx family. See http://e2e.ti.com/support/wireless_connectivity/wilink_wifi_bluetooth/f/307/p/398140/1748545#1748545 for the post from TI. adam On Thu, Jan 21, 2016 at 11:21 AM, Tony Lindgren <tony@atomide.com> wrote: > * Adam Ford <aford173@gmail.com> [160121 09:04]: >> The tcxo-clock-frequency binding is listed as optional, >> but without it the wl12xx used on the torpedo + wireless >> may hang. Scanning also appears broken without this patch. > > OK sounds like we may have this missing for other boards as > well. Do you know when tcxo-clock-frequency is not needed? > Can it be seen from the schematics or something? > > Regards, > > Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Correction, it's required for 128x and optional for the wl127x and wl18xx. I re-read the link from TI. On Fri, Jan 22, 2016 at 8:04 AM, Adam Ford <aford173@gmail.com> wrote: > According to a message I received from TI, this parameter is required > for the WL12xx family but optional for the WL18xx family. > > See http://e2e.ti.com/support/wireless_connectivity/wilink_wifi_bluetooth/f/307/p/398140/1748545#1748545 > for the post from TI. > > adam > > On Thu, Jan 21, 2016 at 11:21 AM, Tony Lindgren <tony@atomide.com> wrote: >> * Adam Ford <aford173@gmail.com> [160121 09:04]: >>> The tcxo-clock-frequency binding is listed as optional, >>> but without it the wl12xx used on the torpedo + wireless >>> may hang. Scanning also appears broken without this patch. >> >> OK sounds like we may have this missing for other boards as >> well. Do you know when tcxo-clock-frequency is not needed? >> Can it be seen from the schematics or something? >> >> Regards, >> >> Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* Adam Ford <aford173@gmail.com> [160122 06:22]: > Correction, it's required for 128x and optional for the wl127x and > wl18xx. I re-read the link from TI. OK. I'll apply $subject patch into omap-for-v4.5/fixes. Adding the tcxo-clock-frequency = <26000000> does not help on omap5-uevm FYI. I can scan networks but can't connect. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jan 21, 2016 at 11:03 AM, Adam Ford <aford173@gmail.com> wrote: > The tcxo-clock-frequency binding is listed as optional, > but without it the wl12xx used on the torpedo + wireless > may hang. Scanning also appears broken without this patch. > > Signed-off-by: Adam Ford <aford173@gmail.com> > --- > arch/arm/boot/dts/logicpd-torpedo-som.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/logicpd-torpedo-som.dtsi b/arch/arm/boot/dts/logicpd-torpedo-som.dtsi > index 36387b1..80f6c78 100644 > --- a/arch/arm/boot/dts/logicpd-torpedo-som.dtsi > +++ b/arch/arm/boot/dts/logicpd-torpedo-som.dtsi > @@ -122,6 +122,7 @@ > interrupt-parent = <&gpio5>; > interrupts = <24 IRQ_TYPE_LEVEL_HIGH>; /* gpio 152 */ > ref-clock-frequency = <26000000>; > + tcxo-clock-frequency = <26000000>; > }; > }; > > -- > 1.9.1 > Tony, This patch seems to not have ever made it into the kernel. Can it still be applied, or should I submit a new patch? adam -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* Adam Ford <aford173@gmail.com> [170117 12:48]: > On Thu, Jan 21, 2016 at 11:03 AM, Adam Ford <aford173@gmail.com> wrote: > > The tcxo-clock-frequency binding is listed as optional, > > but without it the wl12xx used on the torpedo + wireless > > may hang. Scanning also appears broken without this patch. > > > > Signed-off-by: Adam Ford <aford173@gmail.com> > > --- > > arch/arm/boot/dts/logicpd-torpedo-som.dtsi | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm/boot/dts/logicpd-torpedo-som.dtsi b/arch/arm/boot/dts/logicpd-torpedo-som.dtsi > > index 36387b1..80f6c78 100644 > > --- a/arch/arm/boot/dts/logicpd-torpedo-som.dtsi > > +++ b/arch/arm/boot/dts/logicpd-torpedo-som.dtsi > > @@ -122,6 +122,7 @@ > > interrupt-parent = <&gpio5>; > > interrupts = <24 IRQ_TYPE_LEVEL_HIGH>; /* gpio 152 */ > > ref-clock-frequency = <26000000>; > > + tcxo-clock-frequency = <26000000>; > > }; > > }; > > > > -- > > 1.9.1 > > > > Tony, > > This patch seems to not have ever made it into the kernel. Can it > still be applied, or should I submit a new patch? OK, I don't seem to have it. Can you please resend? Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/logicpd-torpedo-som.dtsi b/arch/arm/boot/dts/logicpd-torpedo-som.dtsi index 36387b1..80f6c78 100644 --- a/arch/arm/boot/dts/logicpd-torpedo-som.dtsi +++ b/arch/arm/boot/dts/logicpd-torpedo-som.dtsi @@ -122,6 +122,7 @@ interrupt-parent = <&gpio5>; interrupts = <24 IRQ_TYPE_LEVEL_HIGH>; /* gpio 152 */ ref-clock-frequency = <26000000>; + tcxo-clock-frequency = <26000000>; }; };
The tcxo-clock-frequency binding is listed as optional, but without it the wl12xx used on the torpedo + wireless may hang. Scanning also appears broken without this patch. Signed-off-by: Adam Ford <aford173@gmail.com> --- arch/arm/boot/dts/logicpd-torpedo-som.dtsi | 1 + 1 file changed, 1 insertion(+)