| Message ID | 1457344422-30236-1-git-send-email-laurent.pinchart@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 07/03/16 11:53, Laurent Pinchart wrote: > The function is empty, remote it. s/remote/remove/ > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > arch/arm/mach-omap2/board-generic.c | 2 -- > arch/arm/mach-omap2/common.h | 1 - > arch/arm/mach-omap2/display.c | 5 ----- > 3 files changed, 8 deletions(-) > > diff --git a/arch/arm/mach-omap2/board-generic.c b/arch/arm/mach-omap2/board-generic.c > index 809827265fb3..feae15f199e1 100644 > --- a/arch/arm/mach-omap2/board-generic.c > +++ b/arch/arm/mach-omap2/board-generic.c > @@ -29,8 +29,6 @@ static const struct of_device_id omap_dt_match_table[] __initconst = { > > static void __init omap_generic_init(void) > { > - omapdss_early_init_of(); > - > pdata_quirks_init(omap_dt_match_table); > > omapdss_init_of(); > diff --git a/arch/arm/mach-omap2/common.h b/arch/arm/mach-omap2/common.h > index f7666b9f3b21..0d2a421a2fa7 100644 > --- a/arch/arm/mach-omap2/common.h > +++ b/arch/arm/mach-omap2/common.h > @@ -328,7 +328,6 @@ extern int omap_dss_reset(struct omap_hwmod *); > int omap_clk_init(void); > > int __init omapdss_init_of(void); > -void __init omapdss_early_init_of(void); > > #endif /* __ASSEMBLER__ */ > #endif /* __ARCH_ARM_MACH_OMAP2PLUS_COMMON_H */ > diff --git a/arch/arm/mach-omap2/display.c b/arch/arm/mach-omap2/display.c > index 6ab13d18c636..2e1b271944b7 100644 > --- a/arch/arm/mach-omap2/display.c > +++ b/arch/arm/mach-omap2/display.c > @@ -565,11 +565,6 @@ int omap_dss_reset(struct omap_hwmod *oh) > return r; > } > > -void __init omapdss_early_init_of(void) > -{ > - > -} > - Looks good. A left over function from earlier cleanups. Tomi
Hi Tomi, On Monday 07 March 2016 11:57:57 Tomi Valkeinen wrote: > On 07/03/16 11:53, Laurent Pinchart wrote: > > The function is empty, remote it. > > s/remote/remove/ My bad, fixed. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > > > > arch/arm/mach-omap2/board-generic.c | 2 -- > > arch/arm/mach-omap2/common.h | 1 - > > arch/arm/mach-omap2/display.c | 5 ----- > > 3 files changed, 8 deletions(-) > > > > diff --git a/arch/arm/mach-omap2/board-generic.c > > b/arch/arm/mach-omap2/board-generic.c index 809827265fb3..feae15f199e1 > > 100644 > > --- a/arch/arm/mach-omap2/board-generic.c > > +++ b/arch/arm/mach-omap2/board-generic.c > > @@ -29,8 +29,6 @@ static const struct of_device_id omap_dt_match_table[] > > __initconst = { > > static void __init omap_generic_init(void) > > { > > > > - omapdss_early_init_of(); > > - > > pdata_quirks_init(omap_dt_match_table); > > > > omapdss_init_of(); > > diff --git a/arch/arm/mach-omap2/common.h b/arch/arm/mach-omap2/common.h > > index f7666b9f3b21..0d2a421a2fa7 100644 > > --- a/arch/arm/mach-omap2/common.h > > +++ b/arch/arm/mach-omap2/common.h > > @@ -328,7 +328,6 @@ extern int omap_dss_reset(struct omap_hwmod *); > > int omap_clk_init(void); > > > > int __init omapdss_init_of(void); > > -void __init omapdss_early_init_of(void); > > > > #endif /* __ASSEMBLER__ */ > > #endif /* __ARCH_ARM_MACH_OMAP2PLUS_COMMON_H */ > > diff --git a/arch/arm/mach-omap2/display.c b/arch/arm/mach-omap2/display.c > > index 6ab13d18c636..2e1b271944b7 100644 > > --- a/arch/arm/mach-omap2/display.c > > +++ b/arch/arm/mach-omap2/display.c > > @@ -565,11 +565,6 @@ int omap_dss_reset(struct omap_hwmod *oh) > > return r; > > } > > > > -void __init omapdss_early_init_of(void) > > -{ > > - > > -} > > - > > Looks good. A left over function from earlier cleanups. Care to ack the patch then ? :-)
On 07/03/16 12:06, Laurent Pinchart wrote: >>> -void __init omapdss_early_init_of(void) >>> -{ >>> - >>> -} >>> - >> >> Looks good. A left over function from earlier cleanups. > > Care to ack the patch then ? :-) Yes, that was an implicit ack =). Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Tomi
diff --git a/arch/arm/mach-omap2/board-generic.c b/arch/arm/mach-omap2/board-generic.c index 809827265fb3..feae15f199e1 100644 --- a/arch/arm/mach-omap2/board-generic.c +++ b/arch/arm/mach-omap2/board-generic.c @@ -29,8 +29,6 @@ static const struct of_device_id omap_dt_match_table[] __initconst = { static void __init omap_generic_init(void) { - omapdss_early_init_of(); - pdata_quirks_init(omap_dt_match_table); omapdss_init_of(); diff --git a/arch/arm/mach-omap2/common.h b/arch/arm/mach-omap2/common.h index f7666b9f3b21..0d2a421a2fa7 100644 --- a/arch/arm/mach-omap2/common.h +++ b/arch/arm/mach-omap2/common.h @@ -328,7 +328,6 @@ extern int omap_dss_reset(struct omap_hwmod *); int omap_clk_init(void); int __init omapdss_init_of(void); -void __init omapdss_early_init_of(void); #endif /* __ASSEMBLER__ */ #endif /* __ARCH_ARM_MACH_OMAP2PLUS_COMMON_H */ diff --git a/arch/arm/mach-omap2/display.c b/arch/arm/mach-omap2/display.c index 6ab13d18c636..2e1b271944b7 100644 --- a/arch/arm/mach-omap2/display.c +++ b/arch/arm/mach-omap2/display.c @@ -565,11 +565,6 @@ int omap_dss_reset(struct omap_hwmod *oh) return r; } -void __init omapdss_early_init_of(void) -{ - -} - static const char * const omapdss_compat_names[] __initconst = { "ti,omap2-dss", "ti,omap3-dss",
The function is empty, remote it. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- arch/arm/mach-omap2/board-generic.c | 2 -- arch/arm/mach-omap2/common.h | 1 - arch/arm/mach-omap2/display.c | 5 ----- 3 files changed, 8 deletions(-)