From patchwork Mon Feb 6 22:53:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Khoronzhuk X-Patchwork-Id: 9558881 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B6DD860236 for ; Mon, 6 Feb 2017 22:53:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AD39226224 for ; Mon, 6 Feb 2017 22:53:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9FAA0269A3; Mon, 6 Feb 2017 22:53:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2C63C26224 for ; Mon, 6 Feb 2017 22:53:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752855AbdBFWx5 (ORCPT ); Mon, 6 Feb 2017 17:53:57 -0500 Received: from mail-lf0-f41.google.com ([209.85.215.41]:33566 "EHLO mail-lf0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752803AbdBFWx5 (ORCPT ); Mon, 6 Feb 2017 17:53:57 -0500 Received: by mail-lf0-f41.google.com with SMTP id x1so53173583lff.0 for ; Mon, 06 Feb 2017 14:53:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=eJ683xyP6KlbA+CE/JbZxdf0nZeZBiRrAMoFAgt6rbA=; b=Wgp1z2GxkAJdllg9BvwQLR3M8JdMex5fjnFPbBXVGBEPS+BdQ6vvWr5pigupRKZxdS 6JPuk58FgeshxqtrF+OiGsuRIJE3pLgwnSQmCUTXwUInfR5nCek+PoZDf4Gl6vgq8hgy ruowNAkXBGGt8r86Ox0JJ4pBl2U2et8j4Rsz8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=eJ683xyP6KlbA+CE/JbZxdf0nZeZBiRrAMoFAgt6rbA=; b=nq1uB6aecJr2cN+IKeGK7oL7nN2IsbkMkUaoPit0KlkVpbcarm6p225bP7v4fZ3vIb NXR/IpamocYpoPogTNIDTuHK1C0Qu1IMYmzwsLT6+pd1OmWEv+O9TNpWRyVe42KQ+ZBF zWaWJKFKYbCV/bx5kU0dEDOB8L3AtZ37Zj+nVuSFQaqXSMhMnAt76NACagIf+dGYcsT5 VfxkoVRkGoYdDXbVPqFjHcA4x8YG6DshGIWJmmo0G2bGBpokRV/gvR8GfeWYmzqlYQKc wzI6YhJ1xRfNIe63Ca7UPooomxF98DikwN1ifSa1yCsDEy5kUQhY/xEFxCYd3sPIzaoV 80Yg== X-Gm-Message-State: AIkVDXJ5Q4tDIXXbEYH0QbZFxCAVONVL1kZ6ksYY7mc8Wmfdwt8zMVr/5EqztIr7TcMirEpc X-Received: by 10.25.219.82 with SMTP id s79mr4071704lfg.116.1486421630456; Mon, 06 Feb 2017 14:53:50 -0800 (PST) Received: from localhost.localdomain (183-224-132-95.pool.ukrtel.net. [95.132.224.183]) by smtp.gmail.com with ESMTPSA id f18sm684235ljb.20.2017.02.06.14.53.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 06 Feb 2017 14:53:49 -0800 (PST) From: Ivan Khoronzhuk To: mugunthanvnm@ti.com Cc: grygorii.strashko@ti.com, netdev@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, Ivan Khoronzhuk Subject: [PATCH] net: ethernet: ti: cpsw: remove netif_trans_update Date: Tue, 7 Feb 2017 00:53:45 +0200 Message-Id: <1486421625-24413-1-git-send-email-ivan.khoronzhuk@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP No need to update jiffies in txq->trans_start twice, it's supposed to be done in netdev_start_xmit() and anyway is re-written. Also, no reason to update trans time in case of an error. Signed-off-by: Ivan Khoronzhuk --- Based on net-next/master drivers/net/ethernet/ti/cpsw.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index 35a95dc..4d1c0c3 100644 --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c @@ -1601,8 +1601,6 @@ static netdev_tx_t cpsw_ndo_start_xmit(struct sk_buff *skb, struct cpdma_chan *txch; int ret, q_idx; - netif_trans_update(ndev); - if (skb_padto(skb, CPSW_MIN_PACKET_SIZE)) { cpsw_err(priv, tx_err, "packet pad failed\n"); ndev->stats.tx_dropped++;