| Message ID | 1488644620-11488-8-git-send-email-bgolaszewski@baylibre.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Bartosz Golaszewski <bgolaszewski@baylibre.com> writes: > This driver never frees the interrupt descriptors it allocates. Fix > it by using the resource managed version of irq_alloc_descs(). > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
On Sat, Mar 4, 2017 at 5:23 PM, Bartosz Golaszewski <bgolaszewski@baylibre.com> wrote: > This driver never frees the interrupt descriptors it allocates. Fix > it by using the resource managed version of irq_alloc_descs(). > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> Patch applied with Robert's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c index 76ac906..832f3e4 100644 --- a/drivers/gpio/gpio-pxa.c +++ b/drivers/gpio/gpio-pxa.c @@ -601,7 +601,7 @@ static int pxa_gpio_probe_dt(struct platform_device *pdev, nr_gpios = gpio_id->gpio_nums; pxa_last_gpio = nr_gpios - 1; - irq_base = irq_alloc_descs(-1, 0, nr_gpios, 0); + irq_base = devm_irq_alloc_descs(&pdev->dev, -1, 0, nr_gpios, 0); if (irq_base < 0) { dev_err(&pdev->dev, "Failed to allocate IRQ numbers\n"); return irq_base;
This driver never frees the interrupt descriptors it allocates. Fix it by using the resource managed version of irq_alloc_descs(). Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> --- drivers/gpio/gpio-pxa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)