From patchwork Sun Jun 4 09:18:37 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "J, KEERTHY" X-Patchwork-Id: 9764723 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D8112601D7 for ; Sun, 4 Jun 2017 09:20:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CB50327F9F for ; Sun, 4 Jun 2017 09:20:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BFF8328434; Sun, 4 Jun 2017 09:20:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3FF8428426 for ; Sun, 4 Jun 2017 09:20:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751267AbdFDJUC (ORCPT ); Sun, 4 Jun 2017 05:20:02 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:18489 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751216AbdFDJT4 (ORCPT ); Sun, 4 Jun 2017 05:19:56 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by lelnx194.ext.ti.com (8.15.1/8.15.1) with ESMTP id v549JSZH000340; Sun, 4 Jun 2017 04:19:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1496567968; bh=QTzStharLh9/UEho83yib5ofED2Bn+XW9RysNaHpujw=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=Q96RHVL5RARK6IJL66AmwIBFVYoSm7Ida0FEV1iOR+8OBRC/SzkD0W7Vgru82LpNH l98/CU7TcL5lYnNG2m27M8DyAcirO0AoZxRdbyHdUp3X26in5uUpnGsxtsYaZ/+aWl YlAMG0Hc91tESpZx25tYOH4oyCaSB9A1dONyl+8I= Received: from DFLE72.ent.ti.com (dfle72.ent.ti.com [128.247.5.109]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id v549JRk2005326; Sun, 4 Jun 2017 04:19:27 -0500 Received: from dlep32.itg.ti.com (157.170.170.100) by DFLE72.ent.ti.com (128.247.5.109) with Microsoft SMTP Server id 14.3.294.0; Sun, 4 Jun 2017 04:19:27 -0500 Received: from ula0393675.dhcp.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id v549J1F3009261; Sun, 4 Jun 2017 04:19:22 -0500 From: Keerthy To: , , CC: , , Subject: [PATCH 2/9] mfd: tps65218: Remove redundant i2c_device_id Date: Sun, 4 Jun 2017 14:48:37 +0530 Message-ID: <1496567924-4278-3-git-send-email-j-keerthy@ti.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1496567924-4278-1-git-send-email-j-keerthy@ti.com> References: <1496567924-4278-1-git-send-email-j-keerthy@ti.com> MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP With the introduction of probe_new function the i2c_device_id is no longer needed. Hence the remove the same and use probe_new instead of probe. Signed-off-by: Keerthy --- Boot tested on am347x-gp-evm and checked for regulator registrations. drivers/mfd/tps65218.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/tps65218.c b/drivers/mfd/tps65218.c index 13834a0..53df80b 100644 --- a/drivers/mfd/tps65218.c +++ b/drivers/mfd/tps65218.c @@ -211,8 +211,7 @@ int tps65218_clear_bits(struct tps65218 *tps, unsigned int reg, }; MODULE_DEVICE_TABLE(of, of_tps65218_match_table); -static int tps65218_probe(struct i2c_client *client, - const struct i2c_device_id *ids) +static int tps65218_probe(struct i2c_client *client) { struct tps65218 *tps; const struct of_device_id *match; @@ -281,20 +280,22 @@ static int tps65218_remove(struct i2c_client *client) return 0; } +#if 0 static const struct i2c_device_id tps65218_id_table[] = { { "tps65218", TPS65218 }, { }, }; MODULE_DEVICE_TABLE(i2c, tps65218_id_table); +#endif static struct i2c_driver tps65218_driver = { .driver = { .name = "tps65218", .of_match_table = of_tps65218_match_table, }, - .probe = tps65218_probe, + .probe_new = tps65218_probe, .remove = tps65218_remove, - .id_table = tps65218_id_table, + //.id_table = tps65218_id_table, }; module_i2c_driver(tps65218_driver);