From patchwork Thu Aug 31 23:29:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 9933045 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A8FD860309 for ; Thu, 31 Aug 2017 23:33:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9E78123B23 for ; Thu, 31 Aug 2017 23:33:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 91DB726E3A; Thu, 31 Aug 2017 23:33:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2D1CA23B23 for ; Thu, 31 Aug 2017 23:33:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751793AbdHaXam (ORCPT ); Thu, 31 Aug 2017 19:30:42 -0400 Received: from mail-pg0-f45.google.com ([74.125.83.45]:38772 "EHLO mail-pg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751963AbdHaXaF (ORCPT ); Thu, 31 Aug 2017 19:30:05 -0400 Received: by mail-pg0-f45.google.com with SMTP id b8so3066026pgn.5 for ; Thu, 31 Aug 2017 16:30:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=L4F/uDSoAWti2I9cqEmUEnDwfBPBDVcyJvSIn3AQ3eQ=; b=INVlbPZeOtruR7xPk2pGeR8Xi1xAodZ8P7e9GyBCE1zlIs4/ZTXRdddziHSPNxOTqt RFTFWGypdvkgWsJn2E67xlQpUKDLfXLeSnycJqYSgQkXYNKapg+2MotUhZMftCptmXcU jbnfaKK8uggLEtqRYLAZibbqjE2P/8r5L+tRI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=L4F/uDSoAWti2I9cqEmUEnDwfBPBDVcyJvSIn3AQ3eQ=; b=b6981wFDmBkC9Z1K07OnmHbPa9Gik8I7tPuVXXF+Dd+uk/5RLO7dLVnwmiVf+MM1/g e/E6MGrF/fP6gvTHgrlDtEa1v9Y//1yA5Qb2tPO8ZwDvo4RWopKnkGn3V72oHjEyMD0U 744tiOBaPnjQjIVczeZ+CgZdqPA2GcvceBLPqs8yiwrWa5dVCY0208rrwfibmtjGnSCv VhoYPa0wNHGos6+8WbTtYAexymGMscgZx6O2vmcD7/MIjg1x9TualuOKCQSvP3etjtk1 N5WEtQpsretSZGSDqMzstPY98OgDyW0frvcvEQElvC4g62pC3capiZlcYCe5s1IB1VR1 3nVg== X-Gm-Message-State: AHPjjUgeftQUSmLYXqDGImBOEvM/g36iudJIV5yDVGx88E+keLR6SvtE Z82DFstYasJa/h8I X-Google-Smtp-Source: ADKCNb5M2BXdEReMAdGZ9xIlcH7tRVfx8MiZ6QJ2+8nPPYx20zi27mxZ/+CFRe2JTa4gtUWWTrEJ9g== X-Received: by 10.98.57.135 with SMTP id u7mr132581pfj.220.1504222205133; Thu, 31 Aug 2017 16:30:05 -0700 (PDT) Received: from www.outflux.net (173-164-112-133-Oregon.hfc.comcastbusiness.net. [173.164.112.133]) by smtp.gmail.com with ESMTPSA id j80sm834409pfj.165.2017.08.31.16.29.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 31 Aug 2017 16:30:02 -0700 (PDT) From: Kees Cook To: Thomas Gleixner Cc: Kees Cook , Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 16/31] usb/phy-isp1301-omap: Remove .data assignment Date: Thu, 31 Aug 2017 16:29:28 -0700 Message-Id: <1504222183-61202-17-git-send-email-keescook@chromium.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1504222183-61202-1-git-send-email-keescook@chromium.org> References: <1504222183-61202-1-git-send-email-keescook@chromium.org> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The .data assignment appears to be redundant to the WORK_STOP bit for stopping the timer. Also, it appears this timer is entirely unused as it is only ever started under #define VERBOSE, which is explicitly undefined. Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org Cc: linux-omap@vger.kernel.org Signed-off-by: Kees Cook --- drivers/usb/phy/phy-isp1301-omap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/phy/phy-isp1301-omap.c b/drivers/usb/phy/phy-isp1301-omap.c index f7516f5bee21..321679fe240d 100644 --- a/drivers/usb/phy/phy-isp1301-omap.c +++ b/drivers/usb/phy/phy-isp1301-omap.c @@ -1222,7 +1222,6 @@ static int isp1301_remove(struct i2c_client *i2c) if (machine_is_omap_h2()) gpio_free(2); - isp->timer.data = 0; set_bit(WORK_STOP, &isp->todo); del_timer_sync(&isp->timer); flush_work(&isp->work);