| Message ID | 1505950075-50223-17-git-send-email-keescook@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, Kees Cook <keescook@chromium.org> writes: > The .data assignment appears to be redundant to the WORK_STOP bit for > stopping the timer. Also, it appears this timer is entirely unused > as it is only ever started under #define VERBOSE, which is explicitly > undefined. > > Cc: Felipe Balbi <balbi@kernel.org> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: linux-usb@vger.kernel.org > Cc: linux-omap@vger.kernel.org > Signed-off-by: Kees Cook <keescook@chromium.org> Are you merging these as part of a larger series altogether, or should I pick the patches that concern me? If you're taking them all together: Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
diff --git a/drivers/usb/phy/phy-isp1301-omap.c b/drivers/usb/phy/phy-isp1301-omap.c index 5630840b77b1..8a07ce63b92d 100644 --- a/drivers/usb/phy/phy-isp1301-omap.c +++ b/drivers/usb/phy/phy-isp1301-omap.c @@ -1222,7 +1222,6 @@ static int isp1301_remove(struct i2c_client *i2c) if (machine_is_omap_h2()) gpio_free(2); - isp->timer.data = 0; set_bit(WORK_STOP, &isp->todo); del_timer_sync(&isp->timer); flush_work(&isp->work);
The .data assignment appears to be redundant to the WORK_STOP bit for stopping the timer. Also, it appears this timer is entirely unused as it is only ever started under #define VERBOSE, which is explicitly undefined. Cc: Felipe Balbi <balbi@kernel.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Cc: linux-omap@vger.kernel.org Signed-off-by: Kees Cook <keescook@chromium.org> --- drivers/usb/phy/phy-isp1301-omap.c | 1 - 1 file changed, 1 deletion(-)