From patchwork Wed Sep 20 23:27:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 9962945 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id AC8636056A for ; Wed, 20 Sep 2017 23:31:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9EB692926F for ; Wed, 20 Sep 2017 23:31:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9020329277; Wed, 20 Sep 2017 23:31:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D93882926F for ; Wed, 20 Sep 2017 23:31:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752174AbdITX3M (ORCPT ); Wed, 20 Sep 2017 19:29:12 -0400 Received: from mail-pg0-f42.google.com ([74.125.83.42]:51934 "EHLO mail-pg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752050AbdITX2S (ORCPT ); Wed, 20 Sep 2017 19:28:18 -0400 Received: by mail-pg0-f42.google.com with SMTP id k193so2525331pgc.8 for ; Wed, 20 Sep 2017 16:28:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=QSxCSgJ+zdTteCpSeRH7p9C0tUNPCp15YsMWl6XMsc0=; b=CjierUVsBEQwg5PXqnSwOyCAiGJ7J+5jTCYocz4Qpo7QwIQxGrCf9UfWXAvVY/5Ril 21MaD0Fhz7HZnx7XXsxq+3++XXSXLrm7et1B+/FAl+C5Fip5i5Yn67Lvq8voSrymjJ+a HMgGK5RLyqCI5veblzGwB6Qo14sBHnLX0nd0g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=QSxCSgJ+zdTteCpSeRH7p9C0tUNPCp15YsMWl6XMsc0=; b=GEIWGsHllE1aZW0CEKoR0JWt3Vld7YKrOkbfwHbOKa3ICHEgf3YMFYMiZySzOeSd/F iRC3CUv+Jam3qmW8ALSUckQKjPiIsYITZIk6vqTu5ILGxchU5ZqnnBaDYuh15M/wmZEk Pn5efDyXPKCwZmOnf0vbWMXb2mI7u83hd7gRHcRdtomkf0WzAfgf40Cz8p7wAyIP9Oj4 ZJ1oF6fPvExeymF8mZdqGacLCXFrZ9o+GWoIALdmJ8d+K6hCicQo4ue7h632uRFK9qMc xOLcf25gxFvSFERMHV3QTgk+o9mwloirw/NwlsfZfJnCPORNc7+xnAHXQyHb6mpRPi44 K3yg== X-Gm-Message-State: AHPjjUjiEruUYc+P9TBOAW81IjrZwMS35fzcpRgjYX1rpEWNc+CUQPwD jA7/QJKyb8XpE0dBZ1vulMcSIQ== X-Google-Smtp-Source: AOwi7QASklLXPk9ofxR69Etn5AWdQ5ZZgVKqe8sCRlvF4rG2jP3gkqA0alEb/H0KGHLnutzhy1dewg== X-Received: by 10.101.78.201 with SMTP id w9mr3864441pgq.24.1505950097668; Wed, 20 Sep 2017 16:28:17 -0700 (PDT) Received: from www.outflux.net (173-164-112-133-Oregon.hfc.comcastbusiness.net. [173.164.112.133]) by smtp.gmail.com with ESMTPSA id s17sm75382pgq.25.2017.09.20.16.28.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Sep 2017 16:28:14 -0700 (PDT) From: Kees Cook To: Thomas Gleixner Cc: Kees Cook , Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 16/31] usb/phy-isp1301-omap: Remove .data assignment Date: Wed, 20 Sep 2017 16:27:40 -0700 Message-Id: <1505950075-50223-17-git-send-email-keescook@chromium.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1505950075-50223-1-git-send-email-keescook@chromium.org> References: <1505950075-50223-1-git-send-email-keescook@chromium.org> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The .data assignment appears to be redundant to the WORK_STOP bit for stopping the timer. Also, it appears this timer is entirely unused as it is only ever started under #define VERBOSE, which is explicitly undefined. Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org Cc: linux-omap@vger.kernel.org Signed-off-by: Kees Cook Acked-by: Felipe Balbi --- drivers/usb/phy/phy-isp1301-omap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/phy/phy-isp1301-omap.c b/drivers/usb/phy/phy-isp1301-omap.c index 5630840b77b1..8a07ce63b92d 100644 --- a/drivers/usb/phy/phy-isp1301-omap.c +++ b/drivers/usb/phy/phy-isp1301-omap.c @@ -1222,7 +1222,6 @@ static int isp1301_remove(struct i2c_client *i2c) if (machine_is_omap_h2()) gpio_free(2); - isp->timer.data = 0; set_bit(WORK_STOP, &isp->todo); del_timer_sync(&isp->timer); flush_work(&isp->work);