From patchwork Sat Mar 27 02:29:07 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Hebbar, Shivananda" X-Patchwork-Id: 88676 X-Patchwork-Delegate: omar.ramirez@ti.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o2R2ThJf015222 for ; Sat, 27 Mar 2010 02:29:44 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752761Ab0C0C3U (ORCPT ); Fri, 26 Mar 2010 22:29:20 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:39557 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753079Ab0C0C3Q convert rfc822-to-8bit (ORCPT ); Fri, 26 Mar 2010 22:29:16 -0400 Received: from dbdp20.itg.ti.com ([172.24.170.38]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id o2R2TAUZ006291 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 26 Mar 2010 21:29:12 -0500 Received: from dbde71.ent.ti.com (localhost [127.0.0.1]) by dbdp20.itg.ti.com (8.13.8/8.13.8) with ESMTP id o2R2T9qZ026712; Sat, 27 Mar 2010 07:59:09 +0530 (IST) Received: from dbde02.ent.ti.com ([172.24.170.145]) by dbde71.ent.ti.com ([172.24.170.149]) with mapi; Sat, 27 Mar 2010 07:59:09 +0530 From: "Hebbar, Shivananda" To: "linux-omap@vger.kernel.org" CC: "Ramirez Luna, Omar" , Felipe Contreras , "Menon, Nishanth" Date: Sat, 27 Mar 2010 07:59:07 +0530 Subject: [RFC][PATCH v1 18/19] DSPBRIDGE: Cleanup custom error code (CHNL_E_CANCELLED -> -ECANCELED) Thread-Topic: [RFC][PATCH v1 18/19] DSPBRIDGE: Cleanup custom error code (CHNL_E_CANCELLED -> -ECANCELED) Thread-Index: AcrNVUbTY+/a+UGbSyKccZ41EZFmQg== Message-ID: <19F8576C6E063C45BE387C64729E7394044DEBEE18@dbde02.ent.ti.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Sat, 27 Mar 2010 02:29:45 +0000 (UTC) diff --git a/arch/arm/plat-omap/include/dspbridge/errbase.h b/arch/arm/plat-omap/include/dspbridge/errbase.h index 51e9407..3524a33 100644 --- a/arch/arm/plat-omap/include/dspbridge/errbase.h +++ b/arch/arm/plat-omap/include/dspbridge/errbase.h @@ -300,9 +300,6 @@ * queued. */ #define CHNL_E_NOIOC (CHNL_EBASE + 0x06) -/* I/O has been cancelled on this channel. */ -#define CHNL_E_CANCELLED (CHNL_EBASE + 0x07) - /* End of stream was already requested on this output channel. */ #define CHNL_E_EOS (CHNL_EBASE + 0x09) diff --git a/arch/arm/plat-omap/include/dspbridge/wmd.h b/arch/arm/plat-omap/include/dspbridge/wmd.h index e368bbc..856a737 100644 --- a/arch/arm/plat-omap/include/dspbridge/wmd.h +++ b/arch/arm/plat-omap/include/dspbridge/wmd.h @@ -453,7 +453,7 @@ typedef dsp_status(*fxn_chnl_close) (struct chnl_object *chnl_obj); * -EFAULT: Invalid chnl_obj. * -EFAULT: pHostBuf is invalid. * CHNL_E_NOEOS: User cannot mark EOS on an input channel. - * CHNL_E_CANCELLED: I/O has been cancelled on this channel. No further + * -ECANCELED: I/O has been cancelled on this channel. No further * I/O is allowed. * CHNL_E_EOS: End of stream was already marked on a previous * IORequest on this channel. No further I/O is expected. diff --git a/drivers/dsp/bridge/wmd/chnl_sm.c b/drivers/dsp/bridge/wmd/chnl_sm.c index d3e59d3..38b9194 100644 --- a/drivers/dsp/bridge/wmd/chnl_sm.c +++ b/drivers/dsp/bridge/wmd/chnl_sm.c @@ -123,7 +123,7 @@ dsp_status bridge_chnl_add_io_req(struct chnl_object *chnl_obj, void *pHostBuf, dw_state = pchnl->dw_state; if (dw_state != CHNL_STATEREADY) { if (dw_state & CHNL_STATECANCEL) - status = CHNL_E_CANCELLED; + status = -ECANCELED; else if ((dw_state & CHNL_STATEEOS) && CHNL_IS_OUTPUT(pchnl->chnl_mode)) status = CHNL_E_EOS;