From patchwork Thu Apr 15 21:18:00 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Hebbar, Shivananda" X-Patchwork-Id: 92850 X-Patchwork-Delegate: omar.ramirez@ti.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o3FLHGo6012152 for ; Thu, 15 Apr 2010 21:18:09 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757225Ab0DOVSI (ORCPT ); Thu, 15 Apr 2010 17:18:08 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:55927 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757223Ab0DOVSF convert rfc822-to-8bit (ORCPT ); Thu, 15 Apr 2010 17:18:05 -0400 Received: from dbdp20.itg.ti.com ([172.24.170.38]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id o3FLI2bh019428 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 15 Apr 2010 16:18:04 -0500 Received: from dbde70.ent.ti.com (localhost [127.0.0.1]) by dbdp20.itg.ti.com (8.13.8/8.13.8) with ESMTP id o3FLI25u011150 for ; Fri, 16 Apr 2010 02:48:02 +0530 (IST) Received: from dbde02.ent.ti.com ([172.24.170.145]) by dbde70.ent.ti.com ([172.24.170.148]) with mapi; Fri, 16 Apr 2010 02:48:02 +0530 From: "Hebbar, Shivananda" To: "linux-omap@vger.kernel.org" CC: "Ramirez Luna, Omar" Date: Fri, 16 Apr 2010 02:48:00 +0530 Subject: [RFC] [PATCH 10/13] DSPBRIDGE: Cleanup custom error code (COD_E_OPENFAILED -> -EBADF) Thread-Topic: [RFC] [PATCH 10/13] DSPBRIDGE: Cleanup custom error code (COD_E_OPENFAILED -> -EBADF) Thread-Index: AcrYYU4cT+CR78UsSnujWHCBtZIUEQEfW2Qw Message-ID: <19F8576C6E063C45BE387C64729E7394044E136FE2@dbde02.ent.ti.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Thu, 15 Apr 2010 21:18:09 +0000 (UTC) diff --git a/arch/arm/plat-omap/include/dspbridge/cod.h b/arch/arm/plat-omap/include/dspbridge/cod.h index 381291c..f9d0aef 100644 --- a/arch/arm/plat-omap/include/dspbridge/cod.h +++ b/arch/arm/plat-omap/include/dspbridge/cod.h @@ -286,7 +286,7 @@ extern bool cod_init(void); * envp: array of environment strings for DSP exec. * Returns: * DSP_SOK: Success. - * COD_E_OPENFAILED: Failed to open target code. + * -EBADF: Failed to open target code. * COD_E_LOADFAILED: Failed to load code onto target. * Requires: * COD module initialized. @@ -315,7 +315,7 @@ extern dsp_status cod_load_base(struct cod_manager *cod_mgr_obj, * and cod_get_section. * Returns: * S_OK: Success. - * COD_E_OPENFAILED: Failed to open target code. + * -EBADF: Failed to open target code. * Requires: * COD module initialized. * hmgr is valid. @@ -337,7 +337,7 @@ extern dsp_status cod_open(struct cod_manager *hmgr, * flags: Specifies whether to load symbols. * Returns: * DSP_SOK: Success. - * COD_E_OPENFAILED: Failed to open target code. + * -EBADF: Failed to open target code. * Requires: * COD module initialized. * hmgr is valid. diff --git a/arch/arm/plat-omap/include/dspbridge/errbase.h b/arch/arm/plat-omap/include/dspbridge/errbase.h index dec4b34..679bb59 100644 --- a/arch/arm/plat-omap/include/dspbridge/errbase.h +++ b/arch/arm/plat-omap/include/dspbridge/errbase.h @@ -240,9 +240,6 @@ /* Unable to initialize the ZL COFF parsing module. */ #define COD_E_ZLCREATEFAILED (COD_EBASE + 0x03) -/* Unable to open DSP executable COFF file. */ -#define COD_E_OPENFAILED (COD_EBASE + 0x04) - /* Unable to parse DSP executable COFF file. */ #define COD_E_LOADFAILED (COD_EBASE + 0x05) diff --git a/drivers/dsp/bridge/rmgr/proc.c b/drivers/dsp/bridge/rmgr/proc.c index bdd11a1..1199053 100644 --- a/drivers/dsp/bridge/rmgr/proc.c +++ b/drivers/dsp/bridge/rmgr/proc.c @@ -966,7 +966,7 @@ dsp_status proc_load(void *hprocessor, IN CONST s32 argc_index, dev_brd_write_fxn, p_proc_object->hdev_obj, NULL); if (DSP_FAILED(status)) { - if (status == COD_E_OPENFAILED) { + if (status == -EBADF) { dev_dbg(bridge, "%s: Failure to Load the EXE\n", __func__); }