diff mbox

OMAP FB code to set DISPC_TIMING_{H,V} doesn't match TRM

Message ID 20100616214340.GA27198@gibbs.hungrycats.org (mailing list archive)
State New, archived
Headers show

Commit Message

Zygo Blaxell June 16, 2010, 9:43 p.m. UTC 
None
diff mbox

Patch

diff --git a/drivers/video/omap/dispc.c b/drivers/video/omap/dispc.c
index c7c6455..e58574b 100644
--- a/drivers/video/omap/dispc.c
+++ b/drivers/video/omap/dispc.c
@@ -795,17 +795,17 @@  static void set_lcd_timings(void)
 	unsigned long fck;
 
 	l = dispc_read_reg(DISPC_TIMING_H);
-	l &= ~(FLD_MASK(0, 6) | FLD_MASK(8, 8) | FLD_MASK(20, 8));
-	l |= ( max(1, (min(64,  panel->hsw))) - 1 ) << 0;
-	l |= ( max(1, (min(256, panel->hfp))) - 1 ) << 8;
-	l |= ( max(1, (min(256, panel->hbp))) - 1 ) << 20;
+	l &= ~(FLD_MASK(0, 8) | FLD_MASK(8, 12) | FLD_MASK(20, 12));
+	l |= ( max(1, (min(256, panel->hsw))) - 1 ) << 0;
+	l |= ( max(1, (min(4096, panel->hfp))) - 1 ) << 8;
+	l |= ( max(1, (min(4096, panel->hbp))) - 1 ) << 20;
 	dispc_write_reg(DISPC_TIMING_H, l);
 
 	l = dispc_read_reg(DISPC_TIMING_V);
-	l &= ~(FLD_MASK(0, 6) | FLD_MASK(8, 8) | FLD_MASK(20, 8));
-	l |= ( max(1, (min(64,  panel->vsw))) - 1 ) << 0;
-	l |= ( max(0, (min(255, panel->vfp))) - 0 ) << 8;
-	l |= ( max(0, (min(255, panel->vbp))) - 0 ) << 20;
+	l &= ~(FLD_MASK(0, 8) | FLD_MASK(8, 12) | FLD_MASK(20, 12));
+	l |= ( max(1, (min(256, panel->vsw))) - 1 ) << 0;
+	l |= ( max(1, (min(4096, panel->vfp))) - 1 ) << 8;
+	l |= ( max(1, (min(4096, panel->vbp))) - 1 ) << 20;
 	dispc_write_reg(DISPC_TIMING_V, l);
 
 	l = dispc_read_reg(DISPC_POL_FREQ);