From patchwork Thu May 12 19:58:41 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Todd Poynor X-Patchwork-Id: 780812 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.3) with ESMTP id p4CJwoNi027961 for ; Thu, 12 May 2011 19:58:50 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757885Ab1ELT6s (ORCPT ); Thu, 12 May 2011 15:58:48 -0400 Received: from smtp-out.google.com ([74.125.121.67]:40189 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756975Ab1ELT6s (ORCPT ); Thu, 12 May 2011 15:58:48 -0400 Received: from kpbe16.cbf.corp.google.com (kpbe16.cbf.corp.google.com [172.25.105.80]) by smtp-out.google.com with ESMTP id p4CJwhHq008829; Thu, 12 May 2011 12:58:43 -0700 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=google.com; s=beta; t=1305230324; bh=bb5v1c63EtvxcDZtRrkJUnlAoh0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=qGALnV2JShZP7eiYG9dUmMK9MKFcQSVqFZg4ZnJxUPRxb+I5gglhEJuHNdhvCi/YI cgut3ECZEThkIawsMQ9kg== DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=date:from:to:cc:subject:message-id:references: mime-version:content-type:content-disposition:in-reply-to:user-agent:x-system-of-record; b=RxOTw6e1WxILHNapA2Ekz3+sDwNz6WCysBMOq2/5t47ceRqJ0WuHd65szGAmZSuet HmSSorIU7kJhWpAajAZFw== Received: from conslugarocko.mtv.corp.google.com (conslugarocko.mtv.corp.google.com [172.18.102.26]) by kpbe16.cbf.corp.google.com with ESMTP id p4CJwf71000628; Thu, 12 May 2011 12:58:41 -0700 Received: by conslugarocko.mtv.corp.google.com (Postfix, from userid 115684) id 471D2234309; Thu, 12 May 2011 12:58:41 -0700 (PDT) Date: Thu, 12 May 2011 12:58:41 -0700 From: Todd Poynor To: "Premi, Sanjeev" Cc: "Menon, Nishanth" , "linux-omap@vger.kernel.org" Subject: Re: [PATCH] omap:pm: Fix boot-time errors with debugfs disabled Message-ID: <20110512195841.GA13651@google.com> References: <1305221790-4944-1-git-send-email-premi@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-System-Of-Record: true Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Thu, 12 May 2011 19:58:50 +0000 (UTC) On Fri, May 13, 2011 at 12:46:17AM +0530, Premi, Sanjeev wrote: > > -----Original Message----- > > From: Menon, Nishanth ... > > Last I tried, with Vishwa's dvfs branch on panda without voltage > > registrations, things could crash :( if I get some time I will try to > > port Vishwa's series onto kevin's branch as well and test and provide > > any patches necessary. > > [sp] I can try this on Panda. Will be able to get one tomorrow. In case it helps, below is what I use for Panda. --- ARM: OMAP2 voltage: Don't die if board does not register voltage params This allows the DVFS patches to boot on boards not yet modified to register voltage params. Signed-off-by: Todd Poynor --- arch/arm/mach-omap2/voltage.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/voltage.c b/arch/arm/mach-omap2/voltage.c index dbc1cfe..8f23d95 100644 --- a/arch/arm/mach-omap2/voltage.c +++ b/arch/arm/mach-omap2/voltage.c @@ -617,6 +617,12 @@ static void __init omap4_vc_init(struct omap_vdd_info *vdd) struct clk *sys_ck; u32 sys_clk_speed; + if (!vdd->board_data) { + pr_warning("%s: No voltage board params registered for vdd_%s\n", + __func__, vdd->voltdm.name); + return; + } + sys_ck = clk_get(NULL, "sys_clkin_ck"); if (IS_ERR(sys_ck)) { pr_warning("%s: Could not get the sys clk to calculate"