From patchwork Thu May 26 19:25:53 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Todd Poynor X-Patchwork-Id: 821912 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p4QJQEKC018736 for ; Thu, 26 May 2011 19:26:14 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755482Ab1EZT0M (ORCPT ); Thu, 26 May 2011 15:26:12 -0400 Received: from smtp-out.google.com ([216.239.44.51]:25157 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753168Ab1EZT0M (ORCPT ); Thu, 26 May 2011 15:26:12 -0400 Received: from hpaq1.eem.corp.google.com (hpaq1.eem.corp.google.com [172.25.149.1]) by smtp-out.google.com with ESMTP id p4QJQ3jJ001634; Thu, 26 May 2011 12:26:03 -0700 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=google.com; s=beta; t=1306437964; bh=Hcof8QwaCVhycMIzbWvJ2JqUBvI=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type; b=WPut0hMF3NLs6N26PLEMh8gGyswL2b7S4mxkg+fKkDT+kQca2wOkbA9AyvCP+bcom m4WmyYjkEYJ7KNqoBis5Q== DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=date:from:to:subject:message-id:mime-version:content-type: content-disposition:user-agent:x-system-of-record; b=sKo57hiY/ht3K8dZCaVhCG/ReVlobU5FFTLY0u6UQKjV0yauCdCTq7zxGJIQD1asQ JIlg3k7eHjEcj0tzoxH4Q== Received: from conslugarocko.mtv.corp.google.com (conslugarocko.mtv.corp.google.com [172.18.102.26]) by hpaq1.eem.corp.google.com with ESMTP id p4QJPrbH027095; Thu, 26 May 2011 12:25:54 -0700 Received: by conslugarocko.mtv.corp.google.com (Postfix, from userid 115684) id 9562D234248; Thu, 26 May 2011 12:25:53 -0700 (PDT) Date: Thu, 26 May 2011 12:25:53 -0700 From: Todd Poynor To: Tony Lindgren , linux-omap@vger.kernel.org, Hema HK Subject: [PATCH] ARM: OMAP2: Add missing iounmap in omap4430_phy_init Message-ID: <20110526192553.GA21534@google.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) X-System-Of-Record: true Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Thu, 26 May 2011 19:26:14 +0000 (UTC) !dev case needs iounmap before return. Signed-off-by: Todd Poynor --- arch/arm/mach-omap2/omap_phy_internal.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/omap_phy_internal.c b/arch/arm/mach-omap2/omap_phy_internal.c index ae97336..bd563cf 100644 --- a/arch/arm/mach-omap2/omap_phy_internal.c +++ b/arch/arm/mach-omap2/omap_phy_internal.c @@ -56,8 +56,10 @@ int omap4430_phy_init(struct device *dev) /* Power down the phy */ __raw_writel(PHY_PD, ctrl_base + CONTROL_DEV_CONF); - if (!dev) + if (!dev) { + iounmap(ctrl_base); return 0; + } phyclk = clk_get(dev, "ocp2scp_usb_phy_ick"); if (IS_ERR(phyclk)) {