| Message ID | 20110607205752.GA11299@google.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Kevin Hilman |
| Headers | show |
On 6/8/2011 2:27 AM, Todd Poynor wrote: > Enable all CPUs in the shared policy in the CPU init callback. > Otherwise, the governor CPUFREQ_GOV_START event is invoked with > a policy that only includes the first CPU, leaving other CPUs > uninitialized by the governor. > > Signed-off-by: Todd Poynor<toddpoynor@google.com> Looks good to me. Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com> > --- > arch/arm/mach-omap2/omap2plus-cpufreq.c | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/mach-omap2/omap2plus-cpufreq.c b/arch/arm/mach-omap2/omap2plus-cpufreq.c > index 77efcb0..0fe4edb 100644 > --- a/arch/arm/mach-omap2/omap2plus-cpufreq.c > +++ b/arch/arm/mach-omap2/omap2plus-cpufreq.c > @@ -166,7 +166,6 @@ static inline void freq_table_free(void) > static int __cpuinit omap_cpu_init(struct cpufreq_policy *policy) > { > int result = 0; > - static cpumask_var_t cpumask; > > mpu_clk = clk_get(NULL, mpu_clk_name); > if (IS_ERR(mpu_clk)) > @@ -207,8 +206,7 @@ static int __cpuinit omap_cpu_init(struct cpufreq_policy *policy) > */ > if (is_smp()) { > policy->shared_type = CPUFREQ_SHARED_TYPE_ANY; > - cpumask_or(cpumask, cpumask_of(policy->cpu), cpumask); > - cpumask_copy(policy->cpus, cpumask); > + cpumask_setall(policy->cpus); > } > > /* FIXME: what's the actual transition time? */ -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-omap2/omap2plus-cpufreq.c b/arch/arm/mach-omap2/omap2plus-cpufreq.c index 77efcb0..0fe4edb 100644 --- a/arch/arm/mach-omap2/omap2plus-cpufreq.c +++ b/arch/arm/mach-omap2/omap2plus-cpufreq.c @@ -166,7 +166,6 @@ static inline void freq_table_free(void) static int __cpuinit omap_cpu_init(struct cpufreq_policy *policy) { int result = 0; - static cpumask_var_t cpumask; mpu_clk = clk_get(NULL, mpu_clk_name); if (IS_ERR(mpu_clk)) @@ -207,8 +206,7 @@ static int __cpuinit omap_cpu_init(struct cpufreq_policy *policy) */ if (is_smp()) { policy->shared_type = CPUFREQ_SHARED_TYPE_ANY; - cpumask_or(cpumask, cpumask_of(policy->cpu), cpumask); - cpumask_copy(policy->cpus, cpumask); + cpumask_setall(policy->cpus); } /* FIXME: what's the actual transition time? */
Enable all CPUs in the shared policy in the CPU init callback. Otherwise, the governor CPUFREQ_GOV_START event is invoked with a policy that only includes the first CPU, leaving other CPUs uninitialized by the governor. Signed-off-by: Todd Poynor <toddpoynor@google.com> --- arch/arm/mach-omap2/omap2plus-cpufreq.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)