From patchwork Thu Jul 21 17:43:07 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 996232 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p6LHhGcn030872 for ; Thu, 21 Jul 2011 17:43:16 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753233Ab1GURnP (ORCPT ); Thu, 21 Jul 2011 13:43:15 -0400 Received: from na3sys009aog103.obsmtp.com ([74.125.149.71]:57510 "EHLO na3sys009aog103.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751678Ab1GURnO (ORCPT ); Thu, 21 Jul 2011 13:43:14 -0400 Received: from mail-ew0-f43.google.com ([209.85.215.43]) (using TLSv1) by na3sys009aob103.postini.com ([74.125.148.12]) with SMTP ID DSNKTihlL4GPlI93uZtTYlXVPzb+dt57GQdn@postini.com; Thu, 21 Jul 2011 10:43:14 PDT Received: by ewy20 with SMTP id 20so1812190ewy.2 for ; Thu, 21 Jul 2011 10:43:10 -0700 (PDT) Received: by 10.14.17.210 with SMTP id j58mr257561eej.170.1311270190246; Thu, 21 Jul 2011 10:43:10 -0700 (PDT) Received: from localhost (cs181221225.pp.htv.fi [82.181.221.225]) by mx.google.com with ESMTPS id v8sm1253749eej.50.2011.07.21.10.43.08 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 21 Jul 2011 10:43:09 -0700 (PDT) Date: Thu, 21 Jul 2011 20:43:07 +0300 From: Felipe Balbi To: Kevin Hilman Cc: linux-omap@vger.kernel.org, Russell King , Felipe Balbi , Paul Walmsley , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] OMAP: omap_device: replace pr_* prints with dev_* Message-ID: <20110721174306.GD32058@legolas.emea.dhcp.ti.com> Reply-To: balbi@ti.com References: <1311269976-4035-1-git-send-email-khilman@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1311269976-4035-1-git-send-email-khilman@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Thu, 21 Jul 2011 17:43:19 +0000 (UTC) On Thu, Jul 21, 2011 at 10:39:36AM -0700, Kevin Hilman wrote: > For consistency in kernel printk output for devices, use dev_dbg(), > dev_warn(), dev_err() instead of pr_debug(), pr_warning() and > pr_err(), some of which currently use direct access of name from > platform_device and others of which use dev_name(). Using the dev_* > versions uses the standard device naming from the driver core. > > Some pr_* prints were not converted with this patch since they are > used before the platform_device and struct device are created so > neither the dev_* prints or dev_name() is valid. > > Reported-by: Russell King > Cc: Felipe Balbi > Signed-off-by: Kevin Hilman > --- FWIW: Reviewed-by: Felipe Balbi BTW, I tried applying this to today's linus/master, but it fails (rejects below), are you depending on some other changes ? --- arch/arm/plat-omap/omap_device.c +++ arch/arm/plat-omap/omap_device.c @@ -242,28 +239,27 @@ if (!clk_alias || !clk_name) return; - pr_debug("omap_device: %s: Creating %s -> %s\n", - dev_name(&od->pdev.dev), clk_alias, clk_name); + dev_dbg(&od->pdev.dev, "Creating %s -> %s\n", clk_alias, clk_name); r = clk_get_sys(dev_name(&od->pdev.dev), clk_alias); if (!IS_ERR(r)) { - pr_warning("omap_device: %s: alias %s already exists\n", - dev_name(&od->pdev.dev), clk_alias); + dev_warn(&od->pdev.dev, + "alias %s already exists\n", clk_alias); clk_put(r); return; } r = omap_clk_get_by_name(clk_name); if (IS_ERR(r)) { - pr_err("omap_device: %s: omap_clk_get_by_name for %s failed\n", - dev_name(&od->pdev.dev), clk_name); + dev_err(&od->pdev.dev, + "omap_clk_get_by_name for %s failed\n", clk_name); return; } l = clkdev_alloc(r, clk_alias, dev_name(&od->pdev.dev)); if (!l) { - pr_err("omap_device: %s: clkdev_alloc for %s failed\n", - dev_name(&od->pdev.dev), clk_alias); + dev_err(&od->pdev.dev, + "clkdev_alloc for %s failed\n", clk_alias); return; }