From patchwork Mon Aug 6 22:14:24 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aaro Koskinen X-Patchwork-Id: 1281531 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id E7C6A3FC23 for ; Mon, 6 Aug 2012 22:14:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756015Ab2HFWOj (ORCPT ); Mon, 6 Aug 2012 18:14:39 -0400 Received: from filtteri5.pp.htv.fi ([213.243.153.188]:46536 "EHLO filtteri5.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755950Ab2HFWOj (ORCPT ); Mon, 6 Aug 2012 18:14:39 -0400 Received: from localhost (localhost [127.0.0.1]) by filtteri5.pp.htv.fi (Postfix) with ESMTP id 2AA6E5A684D; Tue, 7 Aug 2012 01:14:38 +0300 (EEST) X-Virus-Scanned: Debian amavisd-new at pp.htv.fi Received: from smtp6.welho.com ([213.243.153.40]) by localhost (filtteri5.pp.htv.fi [213.243.153.188]) (amavisd-new, port 10024) with ESMTP id Rsqtle2+s2uw; Tue, 7 Aug 2012 01:14:37 +0300 (EEST) Received: from harshnoise (212-149-209-232.bb.dnainternet.fi [212.149.209.232]) by smtp6.welho.com (Postfix) with SMTP id C60845BC003; Tue, 7 Aug 2012 01:14:36 +0300 (EEST) Received: by harshnoise (sSMTP sendmail emulation); Tue, 07 Aug 2012 01:14:24 +0300 Date: Tue, 7 Aug 2012 01:14:24 +0300 From: Aaro Koskinen To: Archit Taneja Cc: Tomi Valkeinen , linux-omap@vger.kernel.org Subject: Re: v3.6-rc1 DSS issues/regression Message-ID: <20120806221424.GD1298@harshnoise.musicnaut.iki.fi> References: <20120806164732.GB1298@harshnoise.musicnaut.iki.fi> <1344273868.12136.50.camel@deskari> <5020009C.1080308@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5020009C.1080308@ti.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi, On Mon, Aug 06, 2012 at 11:06:28PM +0530, Archit Taneja wrote: > >On Mon, 2012-08-06 at 19:47 +0300, Aaro Koskinen wrote: > >>I can't get the display on N900 (SDI, acx565akm) to work with v3.6-rc1 > >>kernel, it's just full of flicker/noise. > >> > >>According to git-bisect, the problem is introduced by the commit: > >> > >> commit f476ae9dab3234532d41d36beb4ba7be838fa786 > >> Author: Archit Taneja > >> Date: Fri Jun 29 14:37:03 2012 +0530 > >> > >> OMAPDSS: APPLY: Remove DISPC writes to manager's lcd parameters in interface [...] > The diff I have shared introduces the register writes back. This > should make it work like before. But we need to figure out which > parameter write needs to be done immediately. If this works, could > you remove each dispc register write turn by turn, and point out > which is the culprit one? Thanks, the following one makes the display to work again: A. --- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/video/omap2/dss/sdi.c b/drivers/video/omap2/dss/sdi.c index 5d31699..3c9f598 100644 --- a/drivers/video/omap2/dss/sdi.c +++ b/drivers/video/omap2/dss/sdi.c @@ -46,6 +46,9 @@ static void sdi_config_lcd_manager(struct omap_dss_device *dssdev) sdi.mgr_config.video_port_width = 24; sdi.mgr_config.lcden_sig_polarity = 1; + dispc_mgr_set_clock_div(dssdev->manager->id, + &sdi.mgr_config.clock_info); + dss_mgr_set_lcd_config(dssdev->manager, &sdi.mgr_config); }