From patchwork Mon Dec 24 01:24:58 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Walmsley X-Patchwork-Id: 1907521 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 92829DF25A for ; Mon, 24 Dec 2012 01:27:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752592Ab2LXB11 (ORCPT ); Sun, 23 Dec 2012 20:27:27 -0500 Received: from utopia.booyaka.com ([74.50.51.50]:57202 "EHLO utopia.booyaka.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752325Ab2LXB1Z (ORCPT ); Sun, 23 Dec 2012 20:27:25 -0500 Received: (qmail 19652 invoked by uid 1019); 24 Dec 2012 01:27:24 -0000 MBOX-Line: From nobody Sun Dec 23 18:24:58 2012 Subject: [PATCH 1/3] ARM: OMAP: 32k counter: resolve sparse warnings To: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Paul Walmsley Cc: Kevin Hilman , Tony Lindgren , Santosh Shilimkar , Felipe Balbi , Vaibhav Hiremath Date: Sun, 23 Dec 2012 18:24:58 -0700 Message-ID: <20121224012456.13698.41839.stgit@dusk.lan> In-Reply-To: <20121224012304.13698.43551.stgit@dusk.lan> References: <20121224012304.13698.43551.stgit@dusk.lan> User-Agent: StGit/0.16-37-g27ac3 MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Commit 1fe97c8f6a1de67a5f56e029a818903d5bed8017 ("ARM: OMAP: Make OMAP clocksource source selection using kernel param") results in a new warning from sparse: arch/arm/plat-omap/counter_32k.c:86:12: warning: symbol 'omap_init_clocksource_32k' was not declared. Should it be static? Fix by adding a temporary header file, needed until the 32k counter code is moved to drivers/. arch/arm/plat-omap/include/plat/counter-32k.h can't be added due to ARM CONFIG_ARCH_MULTIPLATFORM restrictions on the use of the "plat/" include path shortcut. Signed-off-by: Paul Walmsley Cc: Vaibhav Hiremath Cc: Felipe Balbi Cc: Santosh Shilimkar Cc: Kevin Hilman Cc: Tony Lindgren --- arch/arm/plat-omap/counter_32k.c | 2 ++ arch/arm/plat-omap/counter_32k.h | 20 ++++++++++++++++++++ 2 files changed, 22 insertions(+) create mode 100644 arch/arm/plat-omap/counter_32k.h -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/plat-omap/counter_32k.c b/arch/arm/plat-omap/counter_32k.c index f3771cd..1d129d3 100644 --- a/arch/arm/plat-omap/counter_32k.c +++ b/arch/arm/plat-omap/counter_32k.c @@ -22,6 +22,8 @@ #include #include +#include "counter_32k.h" + /* OMAP2_32KSYNCNT_CR_OFF: offset of 32ksync counter register */ #define OMAP2_32KSYNCNT_REV_OFF 0x0 #define OMAP2_32KSYNCNT_REV_SCHEME (0x3 << 30) diff --git a/arch/arm/plat-omap/counter_32k.h b/arch/arm/plat-omap/counter_32k.h new file mode 100644 index 0000000..4366ce5 --- /dev/null +++ b/arch/arm/plat-omap/counter_32k.h @@ -0,0 +1,20 @@ +/* + * OMAP 32k counter function prototypes + * + * Copyright (C) 2012 Texas Instruments, Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + * + * XXX Needed until the OMAP 32k counter code is moved to somewhere under + * drivers/. + */ +#ifndef __ARCH_ARM_PLAT_OMAP_COUNTER_32K_H +#define __ARCH_ARM_PLAT_OMAP_COUNTER_32K_H + +#include + +extern int omap_init_clocksource_32k(void __iomem *vbase); + +#endif